From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C6F275AE4 for ; Sun, 26 Oct 2025 08:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761466371; cv=none; b=kktLbiyAOaU55zZx2E1vEhrSuMN1YB+fPN3S+wcFBdzKVJ3T8N8Oz2VcgkY6uThswwSL4F93oz+eEXAre899ETU6EFxDZ/JNdltsqZ6ZGR6ciQsP5OJuCVyxDVasbyuPrJyOFvQ/W4E+0x76RnQaXYgKau4PjlmXH9N3mi62WD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761466371; c=relaxed/simple; bh=KNQiFIatDFDW/ugWS3KsTuNPGeunfC6QHOJzplAW0hI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X5dOukO76p6PXR5nrb8qzNlI8Vm/cjY8oLy2MjdmIXt94Cgug4PGIbFNI9PJT48gktey/QwINUY5JUFxaXQoSqcAHDbjLC0cT+Km+K7RUsnmRjGb81FtE7WhgVMKKKoaRdylI4a1XM7KgOmWDuQzPj8plAuqluY/j43B9s04ZEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X5loQGbD; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X5loQGbD" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-33ff5149ae8so546985a91.3 for ; Sun, 26 Oct 2025 01:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761466369; x=1762071169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I04xuq3ZlAMJMmWZbV+GGOpvIwMx+dHIGrDI5rSwvUs=; b=X5loQGbDDPfBjYea5QXDpUQFoe52Lst5nPJrhMmhjjEjmvszhCEJa4ThyKczkUG+lF R91atu1/0k8znmmAbZRsbrf7Qm2e+U7KDZlG/sT+R/DKy541Y3OJ0I0IB1yQ5udzC1eo AsMjnKXMk6LgsaMUxR2FBrXIyEJ23yYYILx8tgNqCDb4vd2Wo2VAVE+fUdXhQ50w++S8 kHYItCLyx0d8eWVZPZSWt5Hc5WK1Y2BNvepNEhlJtTjgpty0gyjk5AfiG8jQJYjWSSfU kQpA4StoDpQfnIuEG97PWherfdgBNsQ9nxWZG+3Ssfl/aje9ynEXqFjH4eub2SYOxZ3l 5THg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761466369; x=1762071169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I04xuq3ZlAMJMmWZbV+GGOpvIwMx+dHIGrDI5rSwvUs=; b=dls5Gt5ovgJ1k0p6+PaSpBmshqxrHA0ntDy0B7pS3CJ/1dPMwxTGXFcP0TBAxE809u 9xwIXhiDGA4ibF0x2lOKbPe5oug2tzfwNp//MstDsd8mNHA/G4ooH11GYFpyOrNQyCV2 q+UewyDDW5jdj0MZHdoliqrF+8M15QbQBQLfhWRxz1QNXTdWxnhrn1YIuJ5JQZaz3bCl lMZDYwcwNmfG5kMOBQZEJVhZvBX4bGY1C3GJ6M7gDgccosl+JRMr+oTgbeuH7xxktO+l yb//1LjXyKiQoTxZL/6Q73wTtaGGw63YfQBbHNgBO/6O1STixjK9EUVHTidgOzLE2TZN QVuA== X-Forwarded-Encrypted: i=1; AJvYcCUAHbEeOyJ9s0JL5REX3FNDCVId2VL/SW5xjkKINQLUfOSkNd/8bdiWj3QkHbhRhlU5a5wwKVEHzto=@vger.kernel.org X-Gm-Message-State: AOJu0YxGVxa+CUNclueDpcPQseA6OcrCDK/gkoMYyD3J+RZah8Obdmff f0H+rXI5cQ1fR6NKiyBVbrJnuauBng0yla9ErXV/FpFDLjZP11N+Sig9 X-Gm-Gg: ASbGncvdZnvVROb3ldaxfsRUHEQ7Q4GWSOykbeZ9qu0gGmactCW8FhENO4b76w7OOBM X9U+aDRE6h2lgSi9O5ZIBzFV9kfzs9l9nf9+ajp7tdnkFQlWON8aacLFE3lbAK4sg8f1GvykqP/ FKvLNdflyaNGWO8xvxflkq6SYRWA9juNdwNk8DjvA8I5goob/E+tD/mERnmro7u+HDaVEvvvWnS vkLE/EwmUfq0VpUkEW8QJwsWD40hEZUqZpxm824U1GYtWtD7REVuM6QVkEzAIuS7Hv9RFDnD8BP kGvbxjeK8oRSraKMv8p1/mku9qN3mbJXk3V2n4wNHiJVJ0LQ5nK/b6ayX1xovt4dEprZfWtMwmP WVYwY925O/u0p8HUCObKpL/jEdzAsOEtOEZpnhe188+saBjcuLrarVtj0c8Fjw6pD0Oy8cX6ljM NFxcijk0ZQf8pbkf0+DKGpxmagzb3hNLLmsrVUNeyP4d+jpLrCXAoT3eF3u5gn7iJUv9k= X-Google-Smtp-Source: AGHT+IH3N+rTZmae0YIHzKhUxnKjJn04vmCm4zs9XWx4XwHFbqlNVNo4C6bScayA3iX7peruw5FJSQ== X-Received: by 2002:a17:90b:1dd2:b0:327:9e88:7714 with SMTP id 98e67ed59e1d1-33bcf926c1bmr40699771a91.37.1761466368907; Sun, 26 Oct 2025 01:12:48 -0700 (PDT) Received: from bliptop (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33fee8014f6sm2374654a91.0.2025.10.26.01.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Oct 2025 01:12:48 -0700 (PDT) From: "Derek J. Clark" To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Armin Wolf , Len Brown , "Rafael J . Wysocki" , Jonathan Corbet Cc: Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 3/3] platform/x86: lenovo-wmi-gamezone Use explicit allow list Date: Sun, 26 Oct 2025 01:12:40 -0700 Message-ID: <20251026081240.997038-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026081240.997038-1-derekjohn.clark@gmail.com> References: <20251026081240.997038-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The stubbed extreme mode issue seems to be more prevalent than previously thought with multiple users having reported BIOS bugs from setting "performance" when using userspace tools such as PPD. To avoid this ever being possible, make enabling extreme mode an explicit allow list instead. These users will still be able to set extreme mode using the Fn+Q keyboard chord, so no functionality is lost. Currently no models have been validated with extreme mode. Signed-off-by: Derek J. Clark --- .../wmi/devices/lenovo-wmi-gamezone.rst | 10 +++--- drivers/platform/x86/lenovo/wmi-gamezone.c | 33 ++----------------- 2 files changed, 8 insertions(+), 35 deletions(-) diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst index 6c908f44a08e..79051dc62022 100644 --- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst +++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst @@ -31,11 +31,11 @@ The following platform profiles are supported: Extreme ~~~~~~~~~~~~~~~~~~~~ Some newer Lenovo "Gaming Series" laptops have an "Extreme Mode" profile -enabled in their BIOS. - -For some newer devices the "Extreme Mode" profile is incomplete in the BIOS -and setting it will cause undefined behavior. A BIOS bug quirk table is -provided to ensure these devices cannot set "Extreme Mode" from the driver. +enabled in their BIOS. For some newer devices the "Extreme Mode" profile +is incomplete in the BIOS and setting it will cause undefined behavior. To +prevent ever setting this on unsupported hardware, an explicit allow quirk +table is provided with all validated devices. This ensures only fully +supported devices can set "Extreme Mode" from the driver. Custom Profile ~~~~~~~~~~~~~~ diff --git a/drivers/platform/x86/lenovo/wmi-gamezone.c b/drivers/platform/x86/lenovo/wmi-gamezone.c index faabbd4657bd..0488162a7194 100644 --- a/drivers/platform/x86/lenovo/wmi-gamezone.c +++ b/drivers/platform/x86/lenovo/wmi-gamezone.c @@ -47,10 +47,6 @@ struct quirk_entry { bool extreme_supported; }; -static struct quirk_entry quirk_no_extreme_bug = { - .extreme_supported = false, -}; - /** * lwmi_gz_mode_call() - Call method for lenovo-wmi-other driver notifier. * @@ -241,31 +237,8 @@ static int lwmi_gz_profile_set(struct device *dev, return 0; } +/* Explicit allow list */ static const struct dmi_system_id fwbug_list[] = { - { - .ident = "Legion Go 8APU1", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"), - }, - .driver_data = &quirk_no_extreme_bug, - }, - { - .ident = "Legion Go S 8APU1", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8APU1"), - }, - .driver_data = &quirk_no_extreme_bug, - }, - { - .ident = "Legion Go S 8ARP1", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8ARP1"), - }, - .driver_data = &quirk_no_extreme_bug, - }, {}, }; @@ -278,7 +251,7 @@ static const struct dmi_system_id fwbug_list[] = { * Anything version 5 or lower does not. For devices with a version 6 or * greater do a DMI check, as some devices report a version that supports * extreme mode but have an incomplete entry in the BIOS. To ensure this - * cannot be set, quirk them to prevent assignment. + * cannot be set, quirk them to enable assignment. * * Return: bool. */ @@ -292,7 +265,7 @@ static bool lwmi_gz_extreme_supported(int profile_support_ver) dmi_id = dmi_first_match(fwbug_list); if (!dmi_id) - return true; + return false; quirks = dmi_id->driver_data; -- 2.51.1