From: Jakub Kicinski <kuba@kernel.org>
To: Yibo Dong <dong100@mucse.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, corbet@lwn.net, andrew+netdev@lunn.ch,
danishanwar@ti.com, vadim.fedorenko@linux.dev,
geert+renesas@glider.be, mpe@ellerman.id.au, lorenzo@kernel.org,
lukas.bulwahn@redhat.com, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v16 5/5] net: rnpgbe: Add register_netdev
Date: Thu, 30 Oct 2025 19:05:58 -0700 [thread overview]
Message-ID: <20251030190558.302a3ec8@kernel.org> (raw)
In-Reply-To: <7D45894046CE41CC+20251031014410.GA49419@nic-Precision-5820-Tower>
On Fri, 31 Oct 2025 09:44:10 +0800 Yibo Dong wrote:
> > > It is for 'u8 perm_addr[ETH_ALEN];'
> > > Maybe I should just "#include <linux/if_ether.h>" for this patch.
> >
> > I see, that's fine. Then again, I'm not sure why you store the perm
> > addr in the struct in the first place. It's already stored in netdevice.
> >
>
> I get 'mac_addr' from fw, and store it to hw->perm_addr 'before'
> registe netdev (rnpgbe_get_permanent_mac in rnpgbe_chip.c).
> You mean I can use a local variable to store mac_addr from fw,
> and then use it to registe netdev?
>
> Maybe like this?
> int rnpgbe_get_permanent_mac(struct mucse_hw *hw, u8 *perm_addr)
> ...
> u8 perm_addr[ETH_ALEN]
> ...
> err = rnpgbe_get_permanent_mac(hw, perm_addr);
> if (!err) {
> eth_hw_addr_set(netdev, perm_addr);
Yes, LGTM.
prev parent reply other threads:[~2025-10-31 2:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 3:29 [PATCH net-next v16 0/5] Add driver for 1Gbe network chips from MUCSE Dong Yibo
2025-10-27 3:29 ` [PATCH net-next v16 1/5] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-10-27 3:29 ` [PATCH net-next v16 2/5] net: rnpgbe: Add n500/n210 chip support with BAR2 mapping Dong Yibo
2025-10-27 3:29 ` [PATCH net-next v16 3/5] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-10-27 3:29 ` [PATCH net-next v16 4/5] net: rnpgbe: Add basic mbx_fw support Dong Yibo
2025-10-28 15:17 ` Vadim Fedorenko
2025-10-27 3:29 ` [PATCH net-next v16 5/5] net: rnpgbe: Add register_netdev Dong Yibo
2025-10-30 2:21 ` Jakub Kicinski
2025-10-30 2:38 ` Yibo Dong
2025-10-30 15:16 ` Jakub Kicinski
2025-10-31 1:44 ` Yibo Dong
2025-10-31 2:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030190558.302a3ec8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).