Re: [PATCH 1/2] dt-bindings: hwmon: temperature: add support for EMC1812

[Conor Dooley <conor.dooley@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]

On Mon, Nov 03, 2025 at 04:35:27PM +0000, Marius.Cristea@microchip.com wrote:
> Hi Conor,
> 
> On Wed, 2025-10-29 at 18:25 +0000, Conor Dooley wrote:
> > On Wed, Oct 29, 2025 at 05:50:58PM +0200, Marius Cristea wrote:
> > > This is the devicetree schema for Microchip EMC1812/13/14/15/33
> > > Multichannel Low-Voltage Remote Diode Sensor Family.
> > > 
> > > Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> > > ---
> > >  .../bindings/hwmon/microchip,emc1812.yaml          | 176
> > > +++++++++++++++++++++
> > >  MAINTAINERS                                        |   6 +
> > >  2 files changed, 182 insertions(+)
> > > 
> > 
> 
> ...
> > You should be able to just move this into interrupts:
> >   interrupts:
> >     items:
> >       - description:
> >           alert-therm2 asserts when a diode temperature exceeds the
> > ALERT
> >           threshold.
> >       - description:
> >           therm-addr asserts low when the hardware-set THERM limit
> > threshold is
> >           exceeded by one of the temperature sensors.
> > 
> > > +    items:
> > > +      - const: alert-therm2
> > > +      - const: therm-addr
> > 
> > Also, should this and interrupts have minItems: 1? Are both actually
> > required? Can you have therm-addr without alert-therm2?
> > 
> 
> Right now the driver doesn't support any interrupts, but it may support
> in future. The "alert-therm2" is a maskable interrupt and the "therm-
> addr" can't be masked and is "always enabled" into the chip.
> 
> I didn't use "minItems: 1" because I wanted to leave to the user the
> decision if he needs any interrupts into their system

Unfortunately, this doesn't work the way you expected. If you don't set
minItems: 1, then anyone who wants to use an interrupt must use both.

If someone that would connect therm-addr would always also connect
alert-therm2, then minItems: 1 is enough to add. If someone might want to
use therm-addr but not use alter-therm2, then this needs to be changed
to permit these in any order. You can do that by adding the names as an
enum, eg
items:
 - enum: [ foo, bar]
 - bar


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]