linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Linux Documentation <linux-doc@vger.kernel.org>,
	linux-kbuild@vger.kernel.org,
	Nicolas Schier <nicolas.schier@linux.dev>
Subject: Re: [PATCH] Makefile: Let kernel-doc.py use PYTHON3 override
Date: Fri, 7 Nov 2025 21:45:23 +0100	[thread overview]
Message-ID: <20251107214523.50648778@foz.lan> (raw)
In-Reply-To: <20251107192624.78b8a8cf@endymion>

Em Fri, 7 Nov 2025 19:26:24 +0100
Jean Delvare <jdelvare@suse.de> escreveu:

> Hi Mauro,
> 
> On Fri, 7 Nov 2025 07:13:42 -0300, Mauro Carvalho Chehab wrote:
> > Please notice, however, that kERNEL_DOC env var is also called at some
> > DRM makefiles. Perhaps the issue you're getting is there.  
> 
> I'm getting the warnings from a simple "make" call with W=1, and for
> pretty much all C files, not just drm drivers. For example:
> 
> $ nice make CC=/usr/bin/gcc-8 PYTHON3=/usr/bin/python3.12 W=1
> (...)
>   CC      arch/x86/events/intel/core.o
> Warning: Python 3.7 or later is required for correct results
> Warning: arch/x86/events/intel/core.c:0 Python 3.7 or later is required for correct results
>   CC      arch/x86/events/intel/bts.o
> Warning: Python 3.7 or later is required for correct results
> Warning: arch/x86/events/intel/bts.c:0 Python 3.7 or later is required for correct results
>   CC      arch/x86/events/intel/ds.o
> Warning: Python 3.7 or later is required for correct results
> Warning: arch/x86/events/intel/ds.c:0 Python 3.7 or later is required for correct results
>   CC      arch/x86/events/intel/knc.o
> Warning: Python 3.7 or later is required for correct results
> Warning: arch/x86/events/intel/knc.c:0 Python 3.7 or later is required for correct results
> 
> So without my patch, PYTHON3= is ignored for part of the build, and
> these recurrent warnings make it difficult to spot other warnings.

I was kind of expecting such issues on SUSE/openSUSE. That's why
I proposed a logic which auto-detects if a newer python was present,
using it when python version is < 3.7. However, most people didn't like
such approach.

> Which is the reason why I proposed a fix. Alas, I see that my first candidate
> fix breaks "make htmldocs" as reported by Nathan. I'll send a different
> fix which doesn't seem to break anything in my tests.

The second patch seems to be the correct approach to make PYTHON3
override work for kernel-doc. Sent my R-B to it.

Thanks,
Mauro

      reply	other threads:[~2025-11-07 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251103131419.5e504ae2@endymion>
     [not found] ` <20251103185609.GB672460@ax162>
2025-11-03 19:00   ` [PATCH] Makefile: Let kernel-doc.py use PYTHON3 override Randy Dunlap
2025-11-07 10:13     ` Mauro Carvalho Chehab
2025-11-07 18:26       ` Jean Delvare
2025-11-07 20:45         ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251107214523.50648778@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).