From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFFDE306482; Wed, 12 Nov 2025 12:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762951995; cv=none; b=I5QbYiCgJHiJBdoqjanxKRrDRZkgjukdHtZA9NzvN5akXiYWBxp+RkDYu9qu1uPRS8XzVPce8rQ7dUW2NEVqasHWV8oNtglYVAB1LErIsu/zEpm3vQUHIlFxdQYNAsJpnw9YMLJ0FoHom4Uja8Gebi96QgaHX44TIlAsGWRxRek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762951995; c=relaxed/simple; bh=Xq4laesBhXBU8cnsibjlgRX7+Xd6QHEEQNRsfNd8xHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NQ4pbjzO97X0KZ1jQhrRH2YoHE8RXksZuKS0auAVNSyLmN7e+36GSwjhztrfCqtQYEzU/VhnWLA86ClRqizzxIZKmSG+Lu3anEXA5Ui4nMQ7bEi6JIwMlgkDn9MHo31suM0+CwpQkvL+9HabNSDsCZHaW6hZvspbf/o/xX8k00c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MgbNA+aN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MgbNA+aN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD60C4AF0B; Wed, 12 Nov 2025 12:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762951994; bh=Xq4laesBhXBU8cnsibjlgRX7+Xd6QHEEQNRsfNd8xHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgbNA+aNi66iHWuzy6LKut7QTLt+D+/WXgdFltYAbxJCNbzgA1InxXNZhXB1n5p0c vnaW4LMGTXWq3iqK+mCrPfR/wgZ3CmaTYYbgSRIL+gsVedu2ksUj6iZV9eWJ1VDx8L 2t0dYDDlC7uKsojwf3BaUVsp/1kxfrK/qs3b/tQL4PlVsjE6+lxoNCV4z50uPZEu0c IZ7IeyRYTrjvIwKCeVpl50DpVm5RZpwxhGxt3aVEGIxSEwIzBVQiTRda3iQYX8yVoG FLcPcsS+iUYDO9jpoGvblj2BtEDt27fgN3g5T5VkFwZycgbBRxR4Axqu2EhuuHABrh i4BX+X/MEfm9A== Date: Wed, 12 Nov 2025 06:53:12 -0600 From: Rob Herring To: Shenwei Wang Cc: Bjorn Andersson , Mathieu Poirier , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Jonathan Corbet , Linus Walleij , Bartosz Golaszewski , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH v5 1/5] dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support Message-ID: <20251112125312.GA1319094-robh@kernel.org> References: <20251104203315.85706-1-shenwei.wang@nxp.com> <20251104203315.85706-2-shenwei.wang@nxp.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251104203315.85706-2-shenwei.wang@nxp.com> On Tue, Nov 04, 2025 at 02:33:11PM -0600, Shenwei Wang wrote: > Remote processors may announce multiple devices (e.g., I2C, GPIO) over > an RPMSG channel. These devices may require corresponding device tree > nodes, especially when acting as providers, to supply phandles for their > consumers. > > Define an RPMSG node to work as a container for a group of RPMSG channels > under the imx_rproc node. > > Each subnode within "rpmsg" represents an individual RPMSG channel. The > name of each subnode corresponds to the channel name as defined by the > remote processor. > > All remote devices associated with a given channel are defined as child > nodes under the corresponding channel node. > > Signed-off-by: Shenwei Wang > --- > .../bindings/remoteproc/fsl,imx-rproc.yaml | 123 ++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > index 57d75acb0b5e..897a16c4f7db 100644 > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > @@ -84,6 +84,92 @@ properties: > This property is to specify the resource id of the remote processor in SoC > which supports SCFW > > + rpmsg: > + type: object > + additionalProperties: false > + description: > + Present a group of RPMSG channel devices. > + > + properties: > + rpmsg-io-channel: > + type: object > + additionalProperties: false > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + patternProperties: > + "gpio@[0-9a-f]+$": > + type: object > + unevaluatedProperties: false > + properties: > + compatible: > + enum: > + - fsl,imx-rpmsg-gpio > + > + reg: > + maxItems: 1 I still don't understand what the numbers for 'reg' mean here. You explained it and I still don't understand. In any case, it needs to be explained in the schema. For example, why do GPIO and I2C each have their own number space? > + > + "#gpio-cells": > + const: 2 > + > + gpio-controller: true > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > + required: > + - compatible > + - reg > + - "#gpio-cells" > + - "#interrupt-cells" > + > + allOf: > + - $ref: /schemas/gpio/gpio.yaml# > + - $ref: /schemas/interrupt-controller.yaml# > + > + required: > + - '#address-cells' > + - '#size-cells' > + > + rpmsg-i2c-channel: > + type: object > + unevaluatedProperties: false > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + patternProperties: > + "i2c@[0-9a-f]+$": > + type: object > + unevaluatedProperties: false > + properties: > + compatible: > + enum: > + - fsl,imx-rpmsg-i2c > + > + reg: > + maxItems: 1 > + > + required: > + - compatible > + - reg > + > + allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > + required: > + - '#address-cells' > + - '#size-cells' > + > required: > - compatible > > @@ -146,5 +232,42 @@ examples: > &mu 3 1>; > memory-region = <&vdev0buffer>, <&vdev0vring0>, <&vdev0vring1>, <&rsc_table>; > syscon = <&src>; > + > + rpmsg { > + rpmsg-io-channel { > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio@0 { > + compatible = "fsl,imx-rpmsg-gpio"; > + reg = <0>; > + gpio-controller; > + #gpio-cells = <2>; > + #interrupt-cells = <2>; > + interrupt-controller; > + interrupt-parent = <&rpmsg_gpioa>; > + }; > + > + gpio@1 { > + compatible = "fsl,imx-rpmsg-gpio"; > + reg = <1>; > + gpio-controller; > + #gpio-cells = <2>; > + #interrupt-cells = <2>; > + interrupt-controller; > + interrupt-parent = <&rpmsg_gpiob>; > + }; > + }; > + > + rpmsg-i2c-channel { > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c@0 { > + compatible = "fsl,imx-rpmsg-i2c"; > + reg = <0>; > + }; > + }; > + }; > }; > ... > -- > 2.43.0 >