linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure
@ 2025-11-13  6:49 Bhanu Seshu Kumar Valluri
  2025-11-24 16:55 ` Bhanu Seshu Kumar Valluri
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bhanu Seshu Kumar Valluri @ 2025-11-13  6:49 UTC (permalink / raw)
  To: Vinod Koul, Jonathan Corbet
  Cc: dmaengine, linux-doc, linux-kernel, khalid, linux-kernel-mentees,
	skhan, david.hunter.linux, bhanuseshukumar

Describe the need to initialize the phys field in the dma_async_tx_descriptor
structure during its initialization.

Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
---
 Documentation/driver-api/dmaengine/provider.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentation/driver-api/dmaengine/provider.rst
index 1594598b3..f4ed98f70 100644
--- a/Documentation/driver-api/dmaengine/provider.rst
+++ b/Documentation/driver-api/dmaengine/provider.rst
@@ -411,7 +411,7 @@ supported.
   - This structure can be initialized using the function
     ``dma_async_tx_descriptor_init``.
 
-  - You'll also need to set two fields in this structure:
+  - You'll also need to set following fields in this structure:
 
     - flags:
       TODO: Can it be modified by the driver itself, or
@@ -421,6 +421,9 @@ supported.
       that is supposed to push the current transaction descriptor to a
       pending queue, waiting for issue_pending to be called.
 
+    - phys: Physical address of the descriptor which is used later by
+      the dma engine to read the descriptor and initiate transfer.
+
   - In this structure the function pointer callback_result can be
     initialized in order for the submitter to be notified that a
     transaction has completed. In the earlier code the function pointer
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure
  2025-11-13  6:49 [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure Bhanu Seshu Kumar Valluri
@ 2025-11-24 16:55 ` Bhanu Seshu Kumar Valluri
  2025-11-26  3:27 ` Bagas Sanjaya
  2025-12-16 16:59 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bhanu Seshu Kumar Valluri @ 2025-11-24 16:55 UTC (permalink / raw)
  To: Vinod Koul, Jonathan Corbet
  Cc: dmaengine, linux-doc, linux-kernel, khalid, linux-kernel-mentees,
	skhan, david.hunter.linux

On 13/11/25 12:19, Bhanu Seshu Kumar Valluri wrote:
> Describe the need to initialize the phys field in the dma_async_tx_descriptor
> structure during its initialization.
> 
> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
> ---
>  Documentation/driver-api/dmaengine/provider.rst | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentation/driver-api/dmaengine/provider.rst
> index 1594598b3..f4ed98f70 100644
> --- a/Documentation/driver-api/dmaengine/provider.rst
> +++ b/Documentation/driver-api/dmaengine/provider.rst
> @@ -411,7 +411,7 @@ supported.
>    - This structure can be initialized using the function
>      ``dma_async_tx_descriptor_init``.
>  
> -  - You'll also need to set two fields in this structure:
> +  - You'll also need to set following fields in this structure:
>  
>      - flags:
>        TODO: Can it be modified by the driver itself, or
> @@ -421,6 +421,9 @@ supported.
>        that is supposed to push the current transaction descriptor to a
>        pending queue, waiting for issue_pending to be called.
>  
> +    - phys: Physical address of the descriptor which is used later by
> +      the dma engine to read the descriptor and initiate transfer.
> +
>    - In this structure the function pointer callback_result can be
>      initialized in order for the submitter to be notified that a
>      transaction has completed. In the earlier code the function pointer

Hi,

I just wanted to check if you had a chance to review it or if any changes are needed from my side.

Regards,
Bhanu Seshu Kumar Valluri

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure
  2025-11-13  6:49 [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure Bhanu Seshu Kumar Valluri
  2025-11-24 16:55 ` Bhanu Seshu Kumar Valluri
@ 2025-11-26  3:27 ` Bagas Sanjaya
  2025-12-16 16:59 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2025-11-26  3:27 UTC (permalink / raw)
  To: Bhanu Seshu Kumar Valluri, Vinod Koul, Jonathan Corbet
  Cc: dmaengine, linux-doc, linux-kernel, khalid, linux-kernel-mentees,
	skhan, david.hunter.linux

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Thu, Nov 13, 2025 at 12:19:37PM +0530, Bhanu Seshu Kumar Valluri wrote:
> diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentation/driver-api/dmaengine/provider.rst
> index 1594598b3..f4ed98f70 100644
> --- a/Documentation/driver-api/dmaengine/provider.rst
> +++ b/Documentation/driver-api/dmaengine/provider.rst
> @@ -411,7 +411,7 @@ supported.
>    - This structure can be initialized using the function
>      ``dma_async_tx_descriptor_init``.
>  
> -  - You'll also need to set two fields in this structure:
> +  - You'll also need to set following fields in this structure:
>  
>      - flags:
>        TODO: Can it be modified by the driver itself, or
> @@ -421,6 +421,9 @@ supported.
>        that is supposed to push the current transaction descriptor to a
>        pending queue, waiting for issue_pending to be called.
>  
> +    - phys: Physical address of the descriptor which is used later by
> +      the dma engine to read the descriptor and initiate transfer.
> +
>    - In this structure the function pointer callback_result can be
>      initialized in order for the submitter to be notified that a
>      transaction has completed. In the earlier code the function pointer

The wording LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure
  2025-11-13  6:49 [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure Bhanu Seshu Kumar Valluri
  2025-11-24 16:55 ` Bhanu Seshu Kumar Valluri
  2025-11-26  3:27 ` Bagas Sanjaya
@ 2025-12-16 16:59 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2025-12-16 16:59 UTC (permalink / raw)
  To: Jonathan Corbet, Bhanu Seshu Kumar Valluri
  Cc: dmaengine, linux-doc, linux-kernel, khalid, linux-kernel-mentees,
	skhan, david.hunter.linux


On Thu, 13 Nov 2025 12:19:37 +0530, Bhanu Seshu Kumar Valluri wrote:
> Describe the need to initialize the phys field in the dma_async_tx_descriptor
> structure during its initialization.
> 
> 

Applied, thanks!

[1/1] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure
      commit: 08be54a9e56f9523b50d1923a94a48ef5890c0bc

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-16 16:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-13  6:49 [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure Bhanu Seshu Kumar Valluri
2025-11-24 16:55 ` Bhanu Seshu Kumar Valluri
2025-11-26  3:27 ` Bagas Sanjaya
2025-12-16 16:59 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).