From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 420D23358B5; Fri, 14 Nov 2025 17:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763140314; cv=none; b=Vm222Dk0T0xzwj/NrVdPZysPxv7hVtuyKsMCql8/v8RUL2nBaSvR8u0CU0QtVmFMkJaymQEchAqn3mcbWPVpK0wGAMoxr3c6wCcOxwhwWeW2DeApZl+K9mhUOaKzgs3M9mB6c+j6oBTsausYmpE35EP5gGwOvecPzlsvPCBpzr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763140314; c=relaxed/simple; bh=WlbXwYIISbc9OIhLL3wAoAgqK0p6o8kpKTuAtUHBtw0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X/CvFZmC+U8VLyiEuWdludg1NJ7ZxbN3DCLlayMqibPaE6Et/mIGSuVxSLaenwGMuCxmRomPCH1BPjOZCruSnP/+nTB7EnmOJnRIgdLtlHDCAd3eUemsIWlL0QxqyloH+iFEbixj6Nl/2KKmhGrGfadEnoZhGTFmyBybg3HP1q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=iO5UYGYr; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iO5UYGYr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763140310; bh=WlbXwYIISbc9OIhLL3wAoAgqK0p6o8kpKTuAtUHBtw0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iO5UYGYreCQecXg4Cf7etlTDF+O+an0YK++LVDcKAgJ4mGZnEV6zcqe2ZpNckJyNL bVAHVrKEvGWrvd2zu2ZnxInpBqi8GOkGZkEq7zoFMxsScHD/Bx9x/PEnzfJqra/F9W +cT6OKCbmlnOPSZQI/IMuRRXfSzKVIrJ3wBomNEXCnblZzjFAS/2GevNrLmBDatZUE WBuNyfpg1nV2FRCxk6dZuxFanfvcnEQdMhIKuDhrrvykrUTywnqjID/cm/Xn/GJa82 1bOt+WNJh1GXksFSohsIy5WA71wVXhYwe8QLxWUoAs2dCI9boQDhCo+t5mIB/ECm+z zD6ls0I09fXKg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4768617E12D5; Fri, 14 Nov 2025 18:11:49 +0100 (CET) Date: Fri, 14 Nov 2025 18:11:44 +0100 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v9 06/11] drm/v3d: Use huge tmpfs mountpoint helpers Message-ID: <20251114181144.51b44c8b@fedora> In-Reply-To: <20251114170303.2800-7-loic.molinari@collabora.com> References: <20251114170303.2800-1-loic.molinari@collabora.com> <20251114170303.2800-7-loic.molinari@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 14 Nov 2025 18:02:57 +0100 Lo=C3=AFc Molinari wrote: > Make use of the new drm_gem_huge_mnt_create() and > drm_gem_get_huge_mnt() helpers to avoid code duplication. Now that > it's just a few lines long, the single function in v3d_gemfs.c is > moved into v3d_gem.c. >=20 > v3: > - use huge tmpfs mountpoint in drm_device > - move v3d_gemfs.c into v3d_gem.c >=20 > v4: > - clean up mountpoint creation error handling >=20 > v5: > - fix CONFIG_TRANSPARENT_HUGEPAGE check > - use drm_gem_has_huge_mnt() helper >=20 > v8: > - don't access huge_mnt field with CONFIG_TRANSPARENT_HUGEPAGE=3Dn >=20 > v9: > - replace drm_gem_has_huge_mnt() by drm_gem_get_huge_mnt() >=20 > Signed-off-by: Lo=C3=AFc Molinari > --- > drivers/gpu/drm/v3d/Makefile | 3 +- > drivers/gpu/drm/v3d/v3d_bo.c | 9 +++-- > drivers/gpu/drm/v3d/v3d_drv.c | 2 +- > drivers/gpu/drm/v3d/v3d_drv.h | 11 +----- > drivers/gpu/drm/v3d/v3d_gem.c | 27 ++++++++++++-- > drivers/gpu/drm/v3d/v3d_gemfs.c | 62 --------------------------------- > 6 files changed, 34 insertions(+), 80 deletions(-) > delete mode 100644 drivers/gpu/drm/v3d/v3d_gemfs.c >=20 > diff --git a/drivers/gpu/drm/v3d/Makefile b/drivers/gpu/drm/v3d/Makefile > index fcf710926057..b7d673f1153b 100644 > --- a/drivers/gpu/drm/v3d/Makefile > +++ b/drivers/gpu/drm/v3d/Makefile > @@ -13,8 +13,7 @@ v3d-y :=3D \ > v3d_trace_points.o \ > v3d_sched.o \ > v3d_sysfs.o \ > - v3d_submit.o \ > - v3d_gemfs.o > + v3d_submit.o > =20 > v3d-$(CONFIG_DEBUG_FS) +=3D v3d_debugfs.o > =20 > diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c > index d9547f5117b9..211578abf9b6 100644 > --- a/drivers/gpu/drm/v3d/v3d_bo.c > +++ b/drivers/gpu/drm/v3d/v3d_bo.c > @@ -114,7 +114,7 @@ v3d_bo_create_finish(struct drm_gem_object *obj) > if (IS_ERR(sgt)) > return PTR_ERR(sgt); > =20 > - if (!v3d->gemfs) > + if (!drm_gem_get_huge_mnt(obj->dev)) > align =3D SZ_4K; > else if (obj->size >=3D SZ_1M) > align =3D SZ_1M; > @@ -150,12 +150,15 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev= , struct drm_file *file_priv, > size_t unaligned_size) > { > struct drm_gem_shmem_object *shmem_obj; > - struct v3d_dev *v3d =3D to_v3d_dev(dev); > struct v3d_bo *bo; > int ret; > =20 > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > shmem_obj =3D drm_gem_shmem_create_with_mnt(dev, unaligned_size, > - v3d->gemfs); > + dev->huge_mnt); > +#else > + shmem_obj =3D drm_gem_shmem_create(dev, unaligned_size); > +#endif Why not drop the ifdef and go for shmem_obj =3D drm_gem_shmem_create_with_mnt(dev, unaligned_size, drm_gem_get_huge_mnt(obj->dev)); ? > if (IS_ERR(shmem_obj)) > return ERR_CAST(shmem_obj); > bo =3D to_v3d_bo(&shmem_obj->base);