From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C911935A12E for ; Wed, 19 Nov 2025 13:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763559432; cv=none; b=MjOnjb0F0RUtm1ocrKMa2o4tu7XtjzDuyZoowhhqZrAFNH3LzFj/BYenwcROLRZVuWEiFQaPCcCFrB5nfYa4juba2ko0vOh+xyHw9A48iw2dZrIIa3r1K6HX3WldxdUHTj9f3tUHn+rd1eSsVaofItPOQwGzCxibW8AfRA2zNwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763559432; c=relaxed/simple; bh=xHij0HoeROljwYVIzlugVWfpQyDCueEmuef+LW2XwsE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gymeCRaZBafXZMoPpxmw01L8W33wFJ0MKI9t+7o5GjmZiDJWg2dkxu3TImU9GtbpLDp/68yaFVmTmn+p8vsrTxHHt8fg0f/TiypY8H/S451te/Sy7GCZDqc4+8+q61p4bm3l8xM2tc72kBN09QqCzSP5UbWx29tbHe/jMV/MRLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=fbXe4Vjx; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fbXe4Vjx" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8804650ca32so61216846d6.0 for ; Wed, 19 Nov 2025 05:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1763559430; x=1764164230; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bEA8ekCp1nrcWXcrdpDKlGp67cbKmmAmKoKYvVWnAsI=; b=fbXe4VjxC23iYkeLY6whMHNkkabBkvJIbJP5uWEZ9VyfGmzFQGzB51LkWHp8IJDAfy bc+eLn4USPmSpsqj3w8yzTCbSWrINyQaCzhx2fEyFsGqHQot9GoulHgvevmJK/p+6YJe uuqgBjlYy9SZ2oFV1DyKPu/HDjlNaS7AdAB3/WXAttezKn3TRJQih2HNbzrWUBTHOeu0 UJ2OeI0gafI/ERIzGOe9pXUqUOsEzFQpKb1VF8JKgbox0izii7oPTuI8eo/HdU9yTM8m sWOXfMhDn1cdFkJBrCL78GFZ1KRdezr14MAtsv1TRUBQrZyIN8Rm6LRdR8ltbAsYsTUe 42Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763559430; x=1764164230; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bEA8ekCp1nrcWXcrdpDKlGp67cbKmmAmKoKYvVWnAsI=; b=W3Xxzc58Tgm2rU6/l6RqCn6cwIzd999pFQe3UaJRt22WNmTSJJdKxnn0a7krXS/zEk hZa86aXyC9Q0qQyhDXB/N7v4Wroz9W1mlHlblZ0ABdFAEhD4s1XNTyu9YL8olHadG4yJ 527+E/CotfZaW8lM8otGKEbEjH5yQ/Mzw8y5kczYXg11cJNUvhKkes7im6SQj9+kCWvN /8deTvlNSQIy5cB5H1zjTkvBWp0Umfy/P39/1kz6E7hCyxQwsbmwuU4VeEG4IQng8DLA e7Ton7j//xMPcdp9Wg7SIMgmD+ngIslSxMHldYwvsQh49Syu3gKjvzJj8CqtsFnCjwNU phkg== X-Forwarded-Encrypted: i=1; AJvYcCXJy6N38ipd4N7ZsSxRsWuvxqH0nmNg8/xeg35vUN818GgUQ67SuigL5qOYblojXAPbUcA8mrQzwU8=@vger.kernel.org X-Gm-Message-State: AOJu0YySRvOI26xlWCpS/A7MOpSGkeKdOimeGlQ6wqJuc2KQ0A9763Si hQPkuhwQUKSZXgPkGXkEjYuzLP5YixTjjhfdlEL5tqE9A3lR2CQ+NgpfV0uNYEVcTlw= X-Gm-Gg: ASbGncv11gmrvvaYslvzB1OyPyO8HhzZfc9+epKcnup5aMTtVCeF5WtwynBcyYRhKEA PWcX7HqTJaD20XFAMDb2/YZ6jp9pqmxFRB80DlmHPMJ/QcpteR8njlC6vrVZuX+Q6usO22GIUug 839muvV7OeShEQmmpwlcLpawRiAZHGPArB08+LB5yCjXkQLty+Sz0akQ/Ke9Nm7FScAmA60/vbj Qfq1CUuWsrhwuICTGW3GcrSlMJgezPoHMpqBqWiLm3dvynqCwzkqwAkOHUilguEHOPceqxpR1je a1w5gYJDB/gFmnUhwC+feCxUe6qIoOYzm0dNTU/VNkCUSCRtbfSNSGXTWcKxv8qowPIfdM2xCMN lbHYTqibkb3vxKmvG8yY07gp1x/WDscC6kLY/EZUlTgqx+5oRaef8bxn2z2Rk+iXiqUdcza9TDr AWMIGUPAQsjhPFK/WVAxP6kA27OdJYizHO/E8oYs3xdIFEhupe4+ktXbUv04LFRHI7cHI= X-Google-Smtp-Source: AGHT+IGopBrMkEkq4/9KDO3x1qdzFmkcFO+Cz6Is5DlvxN8PyWRrz38DMZOLki2k1pBf80D+Z8AYkg== X-Received: by 2002:a05:6214:419f:b0:880:22f3:3376 with SMTP id 6a1803df08f44-8845fc3e0f0mr26190076d6.10.1763559429603; Wed, 19 Nov 2025 05:37:09 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8828613962esm135128356d6.0.2025.11.19.05.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 05:37:09 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vLiMu-00000000ZAY-2EdI; Wed, 19 Nov 2025 09:37:08 -0400 Date: Wed, 19 Nov 2025 09:37:08 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: "Tian, Kevin" , Bjorn Helgaas , Logan Gunthorpe , Jens Axboe , Robin Murphy , Joerg Roedel , Will Deacon , Marek Szyprowski , Andrew Morton , Jonathan Corbet , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Kees Cook , "Gustavo A. R. Silva" , Ankit Agrawal , Yishai Hadas , Shameer Kolothum , Alex Williamson , Krishnakant Jaju , Matt Ochs , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , "kvm@vger.kernel.org" , "linux-hardening@vger.kernel.org" , Alex Mastro , Nicolin Chen Subject: Re: [PATCH v8 06/11] dma-buf: provide phys_vec to scatter-gather mapping routine Message-ID: <20251119133708.GM17968@ziepe.ca> References: <20251111-dmabuf-vfio-v8-0-fd9aa5df478f@nvidia.com> <20251111-dmabuf-vfio-v8-6-fd9aa5df478f@nvidia.com> <20251119133000.GB18335@unreal> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119133000.GB18335@unreal> On Wed, Nov 19, 2025 at 03:30:00PM +0200, Leon Romanovsky wrote: > On Wed, Nov 19, 2025 at 05:54:55AM +0000, Tian, Kevin wrote: > > > From: Leon Romanovsky > > > Sent: Tuesday, November 11, 2025 5:58 PM > > > + > > > + if (dma->state && dma_use_iova(dma->state)) { > > > + WARN_ON_ONCE(mapped_len != size); > > > > then "goto err_unmap_dma". > > It never should happen, there is no need to provide error unwind to > something that you won't get. It is expected that WARN_ON has recovery code, if it is possible and not burdensome. Jason