From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985F226ED51 for ; Fri, 28 Nov 2025 14:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764339662; cv=none; b=Pk+CtLoazlk7DFRe7U53TbzOYttrNyGWrfq3k6CaXQqLKGKAvB8Rq26i4Fin5KNE13zkjoWHVnEnfIue5HVxuwp4ke7tF9MLDDm80UZZq94BhtngaLDNrDMgDyTVzgTlEkNe4fAMk4yrWjbH593Pv36M+mIBlc9PitjMb6JSygg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764339662; c=relaxed/simple; bh=dn83itIlZUWLQ+U+eA+BuY6G1TrO1GUvpGmFX9B58mE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NkWJAAGCGzYz4assZNWs4Hm1+N3v6XpSo7RQZBR+c52g672At5KFEL+lZOsg389iguQWcccDcTw4U698Z/TN8ZUlikDgkPvn8I0oABaorAK6YCdWMocVcsRSNNsB6u7nsDFr8pN0Bn6VAtBLyRahz2hbkZa9Fw02zoqYJgVnqx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-45033024e45so746621b6e.0 for ; Fri, 28 Nov 2025 06:20:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764339659; x=1764944459; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xVc8Vi5dk8JoHKkvwNwpd9Rz/OBPsAa4UA1kUPWE0N4=; b=qbyDCr43qoOtu78FLdB/OWoE5FjXtxmW7k3Q9Fr6rz+NrXwmvl4RxCcxBFb4bHcBUv Ix3NiWaOlUBdZhY/ItdNXrAd8igTobdc1LdzCloTDzngzmYvfIqWOsWuzcsO/kHEPBgk xvQiM8miam05jObVoMCSWKPjDSWCy24xos0+XJkwQeI1c5LZNJq/FxnZtkJz/obBJ7Lk pVUg0y+O6Vke01tvl3yLE3m2y1k/yceTQF7AJNcS5+F//MWm8qrfEXRajolImorFF3tb anixcO+XI+9RrO8WFJUUGIIjZajdKQOVsVw6LHnNYT4FDZ05+1b1BOerPRBhBrRcM/29 +YMg== X-Forwarded-Encrypted: i=1; AJvYcCXneki2NsmSE12i0tkrwF4XkwmuHeZTd8QeKD8WNziZQs2FjtaP3Sd9XF+784aOot9s2AkLE8Mpua8=@vger.kernel.org X-Gm-Message-State: AOJu0YzhhQwGh6D5IgmuUAZJrDXVl84r59oSCWuJ9hZj/gYD+5wZwxOm cFi6kViA12wIgwW6lQNZZyMiqGXonYbScNzzdenQX4L8Bz83L055DU3e X-Gm-Gg: ASbGncsTpIw8eArkYf3NK51Lo/PbAuTxLkNY8+li2eSR4UN15zfrT3ekRlpsWtn004Z piaipdXhnIadrCRPzU3Y7n1o6bOFuXVxsXEmKSANVkY0CTJS7f9T6/TG6OEsrJUU3nhgyu0mnia BGx/YlNmBI8yhu9i9JvhpRaTVO5Loa97NxcaCAbQKBea6oJIU9rtzbJORWBr0sGueRKj9Gb6bIy m4fRsYcjf60Nzd1xotOVJ94RlvHcfVWvX+jGMGMASsvaD8IwzqdSGr8rciaiPw0X83hMMlxeZ8u 0HwNohlp8JJJKQR938pJxAID2UUtdNQgQQmjtZudg5EKcOToCG/FSGZvxBNF3pKI/JEL8MGSwX2 Z+lYA9UlapE9r6lr2cUoYHvxKXKWk6mquwpFvOIyFO/+Ti90rM0hcSixFp/Nm8d5NCe8lZpMqWQ zxaPCp+8wwuYtyZA== X-Google-Smtp-Source: AGHT+IFwD7RpsIfEFgpcmxfYEZy5hKSIijVY3yZmFrgV5YRT+F+kpxQb8bm0YGtDkXzW4eF+67kIXw== X-Received: by 2002:a05:6808:894c:b0:450:3ff9:f501 with SMTP id 5614622812f47-4511290fd1dmr13040281b6e.7.1764339658257; Fri, 28 Nov 2025 06:20:58 -0800 (PST) Received: from localhost ([2a03:2880:10ff:41::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-659332e1480sm950537eaf.7.2025.11.28.06.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 06:20:57 -0800 (PST) From: Breno Leitao Date: Fri, 28 Nov 2025 06:20:47 -0800 Subject: [PATCH net-next 2/4] netconsole: Add configfs attribute for direct message sending Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251128-netconsole_send_msg-v1-2-8cca4bbce9bc@debian.org> References: <20251128-netconsole_send_msg-v1-0-8cca4bbce9bc@debian.org> In-Reply-To: <20251128-netconsole_send_msg-v1-0-8cca4bbce9bc@debian.org> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman , Jonathan Corbet Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, gustavold@gmail.com, asantostc@gmail.com, calvin@wbinvd.org, kernel-team@meta.com X-Mailer: b4 0.15-dev-a6db3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2745; i=leitao@debian.org; h=from:subject:message-id; bh=dn83itIlZUWLQ+U+eA+BuY6G1TrO1GUvpGmFX9B58mE=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpKa/FqDVOsFZ8329Lx8kfljFJl1ghgku9drY0/ AXGcDnSjzWJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaSmvxQAKCRA1o5Of/Hh3 bRTFD/0Tu3SmDZIjSP/ODQfN9yDeyLXcHnrAF9W8o4lc9Z5qBaMIegPzgfCChdgS4l0zwd2IwHD LD3CsR5N+YvzA30Thp+Zu8F7Q2Re3L+6ai1dieyBHutSl/V9LfSLR7WU8GVswYP+d5iETinR3jC hhhzf4d98d/0kd6pExSOKwsFlT19wEIH3T2Bad7IWqrnZALyLVQwzfkVEcJW7W0dmiClW+VdYid rVdeqld6a7zkqCrdHf6DZsZ/y7YUzgJsNi09EeqT3k+HABD/KQXvRsPKIJK1zSOwsrhhpKwOaFG JiDNBwUkmb7wCwPV+GkwkFCyb6jwMMR8qaL85HSE2QuazfTw1rrAFRI9V5kvGjCuvf1zrVcjrOd QlIYi8A1zHyl6Zk5dleTIzrdzHLogwj301mKRxgEFMtEBq6BzUBo1GNkIsFW1dAvYmZ8G9vF7+s Kdv99GHXtSx3FpdDJi11tcBG9ZVc30lFu9qQJ85JVCPeFteXYbMf9H9zQt/4ern0fmEB2OKDVBb JTnjaEZ6LnW6nm06keF2OWv1BTxSoUBIFG0Rss0jMdlOG+8QEsylTV2MqHocI2X3ABuqB0zKF89 UGyX96WZIHo4WpkIORZgwXMdsOTTXup0GSNZIsuMpsWpS5GsUkk9ejOhT+cc7l/GSWTwAlSL4Z+ PD3Ybkt+pdrnXMg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Add a new write-only configfs attribute "send_msg" to netconsole targets that allows sending arbitrary messages directly through netconsole. This feature enables users to send custom messages through netconsole without having to go through the kernel logging infrastructure. Messages can be sent by simply writing to: /sys/kernel/config/netconsole//send_msg The implementation: - Checks if the target is enabled before sending - Verifies the network interface is running - Handles both basic and extended message formats - Fragments large messages when needed for basic targets - Reuses existing send_msg_udp() and send_ext_msg_udp() functions Unfortunately this patch has two forward declaration, which is not ideal, but, moving send_msg_udp() functions earlier would cause too many changes, and this could be done in an idependent patch. Signed-off-by: Breno Leitao --- drivers/net/netconsole.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index dc3bd7c9b049..245ed2584bbb 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -1194,6 +1194,39 @@ static const struct config_item_type userdata_type = { .ct_owner = THIS_MODULE, }; +/* Forward declarations */ +static void send_ext_msg_udp(struct netconsole_target *nt, const char *msg, + int msg_len); +static void send_msg_udp(struct netconsole_target *nt, const char *msg, + unsigned int len); + +static ssize_t send_msg_store(struct config_item *item, const char *buf, + size_t count) +{ + struct netconsole_target *nt = to_target(item); + ssize_t ret = -EINVAL; + unsigned long flags; + + mutex_lock(&dynamic_netconsole_mutex); + if (!nt->enabled) + goto out; + + if (!netif_running(nt->np.dev)) + goto out; + + spin_lock_irqsave(&target_list_lock, flags); + if (nt->extended) + send_ext_msg_udp(nt, buf, count); + else + send_msg_udp(nt, buf, count); + spin_unlock_irqrestore(&target_list_lock, flags); + + ret = count; +out: + mutex_unlock(&dynamic_netconsole_mutex); + + return ret; +} CONFIGFS_ATTR(, enabled); CONFIGFS_ATTR(, extended); CONFIGFS_ATTR(, dev_name); @@ -1205,6 +1238,7 @@ CONFIGFS_ATTR_RO(, local_mac); CONFIGFS_ATTR(, remote_mac); CONFIGFS_ATTR(, release); CONFIGFS_ATTR_RO(, transmit_errors); +CONFIGFS_ATTR_WO(, send_msg); static struct configfs_attribute *netconsole_target_attrs[] = { &attr_enabled, @@ -1218,6 +1252,7 @@ static struct configfs_attribute *netconsole_target_attrs[] = { &attr_local_mac, &attr_remote_mac, &attr_transmit_errors, + &attr_send_msg, NULL, }; -- 2.47.3