From: Vishnu Sankar <vishnuocv@gmail.com>
To: corbet@lwn.net, dmitry.torokhov@gmail.com, hmh@hmh.eng.br,
derekjohn.clark@gmail.com, hansg@kernel.org,
ilpo.jarvinen@linux.intel.com
Cc: mpearson-lenovo@squebb.ca, linux-doc@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org, vsankar@lenovo.com,
Vishnu Sankar <vishnuocv@gmail.com>
Subject: [PATCH v4 0/3] TrackPoint doubletap enablement and user control
Date: Sat, 29 Nov 2025 09:25:30 +0900 [thread overview]
Message-ID: <20251129002533.9070-1-vishnuocv@gmail.com> (raw)
This patch series adds doubletap support for TrackPoint devices with
a clean separation of concerns:
1. Firmware enablement (trackpoint.c): Automatically enables doubletap
on capable hardware during device detection
2. User control (thinkpad_acpi.c): Provides sysfs interface for
controlling event filtering
The simplified approach follows KISS principle:
- Trackpoint driver enables hardware functionality by default
- Thinkpad_acpi driver provides user control via existing filtering
- No cross-driver dependencies or complex interactions
Changes in v4:
- Complete redesign based on reviewer feedback
- trackpoint.c: Simplified to only enable doubletap by default
- trackpoint.c: Removed all sysfs attributes and global variables
- trackpoint.c: Uses firmware ID detection with deny list
- thinkpad_acpi.c: Added simple sysfs interface for event filtering
- thinkpad_acpi.c: Uses clear naming (doubletap_filter)
- thinkpad_acpi.c: No cross-driver dependencies
- Documentation: Updated to reflect simplified sysfs approach
Changes in v3:
- No changes
Changes in v2:
- Improved commit messages
- Removed unnecessary comments and debug messages
- Using strstarts() instead of strcmp()
- Modified is_trackpoint_dt_capable()
- Removed _BIT suffix and used BIT() define
This version addresses the core reviewer feedback by:
- Removing dual filtering complexity
- Following KISS principle with clear separation
- Providing immediate functionality without configuration
Vishnu Sankar (3):
input: trackpoint - Enable doubletap by default on capable devices
platform/x86: thinkpad_acpi - Add doubletap_filter sysfs interface
Documentation: thinkpad-acpi - Document doubletap_filter attribute
.../admin-guide/laptops/thinkpad-acpi.rst | 20 +++++++
drivers/input/mouse/trackpoint.c | 51 ++++++++++++++++++
drivers/input/mouse/trackpoint.h | 5 ++
drivers/platform/x86/lenovo/thinkpad_acpi.c | 54 +++++++++++++++++--
4 files changed, 125 insertions(+), 5 deletions(-)
--
2.51.0
next reply other threads:[~2025-11-29 0:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 0:25 Vishnu Sankar [this message]
2025-11-29 0:25 ` [PATCH v4 1/3] input: trackpoint - Enable doubletap by default on capable devices Vishnu Sankar
2025-12-11 6:49 ` Dmitry Torokhov
2025-12-11 14:46 ` Vishnu Sankar
2025-11-29 0:25 ` [PATCH v4 2/3] platform/x86: thinkpad_acpi - Add doubletap_filter sysfs interface Vishnu Sankar
2025-11-29 14:48 ` Hans de Goede
2025-11-29 0:25 ` [PATCH v4 3/3] Documentation: thinkpad-acpi - Document doubletap_filter attribute Vishnu Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251129002533.9070-1-vishnuocv@gmail.com \
--to=vishnuocv@gmail.com \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).