From: Brian Masney <bmasney@redhat.com>
To: Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, Brian Masney <bmasney@redhat.com>
Subject: [PATCH 2/3] clk: composite: convert from round_rate() to determine_rate()
Date: Fri, 12 Dec 2025 08:41:41 +0900 [thread overview]
Message-ID: <20251212-clk-remove-round-rate-v1-2-5c3d5f3edc78@redhat.com> (raw)
In-Reply-To: <20251212-clk-remove-round-rate-v1-0-5c3d5f3edc78@redhat.com>
The round_rate() clk ops is deprecated and going away, so migrate
this driver from round_rate() to determine_rate().
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
drivers/clk/clk-composite.c | 38 +++++---------------------------------
1 file changed, 5 insertions(+), 33 deletions(-)
diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
index 66759fe28fad67f98b6c723ce70849490a022e26..0d96d46712b7258cf23d7b3768a5e75690e2c9d9 100644
--- a/drivers/clk/clk-composite.c
+++ b/drivers/clk/clk-composite.c
@@ -47,22 +47,10 @@ static int clk_composite_determine_rate_for_parent(struct clk_hw *rate_hw,
struct clk_hw *parent_hw,
const struct clk_ops *rate_ops)
{
- long rate;
-
req->best_parent_hw = parent_hw;
req->best_parent_rate = clk_hw_get_rate(parent_hw);
- if (rate_ops->determine_rate)
- return rate_ops->determine_rate(rate_hw, req);
-
- rate = rate_ops->round_rate(rate_hw, req->rate,
- &req->best_parent_rate);
- if (rate < 0)
- return rate;
-
- req->rate = rate;
-
- return 0;
+ return rate_ops->determine_rate(rate_hw, req);
}
static int clk_composite_determine_rate(struct clk_hw *hw,
@@ -79,8 +67,7 @@ static int clk_composite_determine_rate(struct clk_hw *hw,
unsigned long best_rate = 0;
int i, ret;
- if (rate_hw && rate_ops &&
- (rate_ops->determine_rate || rate_ops->round_rate) &&
+ if (rate_hw && rate_ops && rate_ops->determine_rate &&
mux_hw && mux_ops && mux_ops->set_parent) {
req->best_parent_hw = NULL;
@@ -150,18 +137,6 @@ static int clk_composite_determine_rate(struct clk_hw *hw,
}
}
-static long clk_composite_round_rate(struct clk_hw *hw, unsigned long rate,
- unsigned long *prate)
-{
- struct clk_composite *composite = to_clk_composite(hw);
- const struct clk_ops *rate_ops = composite->rate_ops;
- struct clk_hw *rate_hw = composite->rate_hw;
-
- __clk_hw_set_clk(rate_hw, hw);
-
- return rate_ops->round_rate(rate_hw, rate, prate);
-}
-
static int clk_composite_set_rate(struct clk_hw *hw, unsigned long rate,
unsigned long parent_rate)
{
@@ -288,17 +263,14 @@ static struct clk_hw *__clk_hw_register_composite(struct device *dev,
if (rate_ops->determine_rate)
clk_composite_ops->determine_rate =
clk_composite_determine_rate;
- else if (rate_ops->round_rate)
- clk_composite_ops->round_rate =
- clk_composite_round_rate;
- /* .set_rate requires either .round_rate or .determine_rate */
+ /* .set_rate requires .determine_rate */
if (rate_ops->set_rate) {
- if (rate_ops->determine_rate || rate_ops->round_rate)
+ if (rate_ops->determine_rate)
clk_composite_ops->set_rate =
clk_composite_set_rate;
else
- WARN(1, "%s: missing round_rate op is required\n",
+ WARN(1, "%s: missing determine_rate op is required\n",
__func__);
}
--
2.52.0
next prev parent reply other threads:[~2025-12-11 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 23:41 [PATCH 0/3] clk: remove round_rate clk op from the clk core Brian Masney
2025-12-11 23:41 ` [PATCH 1/3] clk: test: remove references to clk_ops.round_rate Brian Masney
2025-12-11 23:41 ` Brian Masney [this message]
2025-12-11 23:41 ` [PATCH 3/3] clk: remove round_rate() clk ops Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212-clk-remove-round-rate-v1-2-5c3d5f3edc78@redhat.com \
--to=bmasney@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).