linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Graham Roff <grahamr@qti.qualcomm.com>,
	Nicolas Schier <nsc@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH v2] Support conditional deps using "depends on X if Y"
Date: Sat, 13 Dec 2025 10:40:09 +0900	[thread overview]
Message-ID: <20251213014009.GA3115176@ax162> (raw)
In-Reply-To: <1f2376e39dc46772e630e2cc9f9b40a2ef20993d@intel.com>

On Wed, Dec 10, 2025 at 05:07:39PM +0200, Jani Nikula wrote:
> On Fri, 05 Dec 2025, Nathan Chancellor <nathan@kernel.org> wrote:
> > On Fri, Dec 05, 2025 at 09:01:51AM +0100, Arnd Bergmann wrote:
> >> This is the bit that frequently confuses developers with the
> >> current syntax, and I agree it would be nice to have a better
> >> way,  but I'm not sure the proposal actually helps enough to
> >> warrant a mass-conversion of existing Kconfig files.
> >
> > I do agree that the 'depends on A || !A' syntax is confusing and that
> > this does not really address that but I think that is besides the point
> > here. I also agree that it is probably not worth converting existing
> > users to this syntax (unless there is solid reasoning), I would not want
> > to see cleanup patches of that nature, just use in new code.
> 
> I think "depends on A if A" is an improvement over "A || !A". But not a
> drastic improvement.

Agreed.

> I think the question is, can we figure out an even better syntax for
> that use case? Something that conveys the "optionally depends on A"
> meaning? Is there something so good that it would warrant cleanup
> conversions just for the improved clarity?

I cannot think of anything off the top of my head but given how new I am
to actually maintaining Kconfig, maybe something else will come up over
time (or maybe Nicolas has some thoughts).

> If we can't come up with anything, let's just roll with what we have
> here?

This is my plan personally, as I feel like this (or the future v3) is
good enough (and brings consistency to "depends" with regards to
supporting "if" like "prompt" and "select" do). I am a firm believer in
"don't let perfect be the enemy of good".

Cheers,
Nathan

  reply	other threads:[~2025-12-13  1:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 18:46 [PATCH v2] Support conditional deps using "depends on X if Y" Graham Roff
2025-12-05  1:53 ` Nathan Chancellor
2025-12-05  8:01   ` Arnd Bergmann
2025-12-05 16:14     ` Nicolas Pitre
2025-12-05 18:23     ` Nathan Chancellor
2025-12-09 22:45       ` Graham Roff
2025-12-10 15:07       ` Jani Nikula
2025-12-13  1:40         ` Nathan Chancellor [this message]
2025-12-05  9:06 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251213014009.GA3115176@ax162 \
    --to=nathan@kernel.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=grahamr@qti.qualcomm.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=nsc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).