From: Nathan Chancellor <nathan@kernel.org>
To: Graham Roff <grahamr@qti.qualcomm.com>
Cc: Nicolas Schier <nsc@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] kconfig: Support conditional deps using "depends on X if Y"
Date: Fri, 19 Dec 2025 12:56:57 -0700 [thread overview]
Message-ID: <20251219195657.GA1404453@ax162> (raw)
In-Reply-To: <20251215-kconfig_conditional_deps-v3-1-59519af0a5df@qti.qualcomm.com>
Hi Graham,
On Mon, Dec 15, 2025 at 03:06:54PM -0800, Graham Roff wrote:
> From: Nicolas Pitre <nico@fluxnic.net>
>
> Extend the "depends on" syntax to support conditional dependencies
> using "depends on X if Y". While functionally equivalent to "depends
> on X || (Y == n)", "depends on X if Y" is much more readable and
> makes the kconfig language uniform in supporting the "if <expr>"
> suffix.
> This also improves readability for "optional" dependencies, which
> are the subset of conditional dependencies where X is Y.
> Previously such optional dependencies had to be expressed as
> the counterintuitive "depends on X || !X", now this can be
> represented as "depends on X if X".
>
> The change is implemented by converting the "X if Y" syntax into the
> "X || (Y == n)" syntax during "depends on" token processing.
>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
>
> [Graham Roff: Rewrote commit message, updated patch, added tests]
>
> Signed-off-by: Graham Roff <grahamr@qti.qualcomm.com>
Thanks, I think this is a reasonable extension and the updates to v3
clear up all of my concerns.
I plan to apply this to kbuild-next in a week or so to give adequate
time for people to comment and review it.
Cheers,
Nathan
next prev parent reply other threads:[~2025-12-19 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 23:06 [PATCH v3] kconfig: Support conditional deps using "depends on X if Y" Graham Roff
2025-12-19 19:56 ` Nathan Chancellor [this message]
2026-01-04 22:49 ` Randy Dunlap
2026-01-06 22:06 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219195657.GA1404453@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=grahamr@qti.qualcomm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).