From: Krzysztof Kozlowski <krzk@kernel.org>
To: Janani Sunil <janani.sunil@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
jan.sun97@gmail.com
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add max22007
Date: Fri, 9 Jan 2026 09:26:25 +0100 [thread overview]
Message-ID: <20260109-frisky-giga-ammonite-3fd8ca@quoll> (raw)
In-Reply-To: <20260108-max22007-dev-v2-1-2506c738784f@analog.com>
On Thu, Jan 08, 2026 at 01:58:23PM +0100, Janani Sunil wrote:
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> + - hvdd-supply
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/iio/addac/adi,ad74413r.h>
> +
> + vdd_reg: regulator-vdd {
This was not here, drop entire node.
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + hvdd_reg: regulator-hvdd {
Same here.
With these two fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-09 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 12:58 [PATCH v2 0/2] Subject: [PATCH v1 0/3] iio: dac: Add support for MAX22007 DAC Janani Sunil
2026-01-08 12:58 ` [PATCH v2 1/2] dt-bindings: iio: dac: Add max22007 Janani Sunil
2026-01-09 8:26 ` Krzysztof Kozlowski [this message]
2026-01-09 12:44 ` Marcelo Schmitt
2026-01-09 14:08 ` Janani Sunil
2026-01-08 12:58 ` [PATCH v2 2/2] iio: dac: Add MAX22007 DAC driver support Janani Sunil
2026-01-09 14:11 ` Marcelo Schmitt
2026-01-09 15:36 ` Janani Sunil
2026-01-11 15:56 ` Jonathan Cameron
2026-01-11 16:09 ` Jonathan Cameron
2026-01-12 20:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109-frisky-giga-ammonite-3fd8ca@quoll \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jan.sun97@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox