Re: [PATCH v4 2/2] iio: adc: Initial support for AD4134

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 7 Jan 2026 18:22:23 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jan 07, 2026 at 11:47:59AM -0300, Marcelo Schmitt wrote:
> > AD4134 is a 24-bit, 4-channel, simultaneous sampling, precision
> > analog-to-digital converter (ADC). The device can be managed through SPI or
> > direct control of pin logical levels (pin control mode). The AD4134 design
> > also features a dedicated bus for ADC sample data output. Though, this
> > initial driver for AD4134 only supports usual SPI connections.
> > 
> > Add basic support for AD4134 that enables single-shot ADC sample read.  
> 
> I have been on a few weeks leave and do not remember much, but it looks like
> this version has all my previous comments being addressed.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I tweaked to drop the explicit bits.h include and applied to the togreg
branch of iio.git, initially pushed out as testing.

thanks,

Jonathan

> 
> ...
> 
> > +#include <linux/array_size.h>
> > +#include <linux/bitfield.h>  
> 
> > +#include <linux/bitops.h>  
> 
> > +#include <linux/bits.h>  
> 
> No need, as bitops.h implies (and guarantees) that BIT()/GENMASK() are provided
> with it.
> 
> > +#include <linux/clk.h>
> > +#include <linux/crc8.h>
> > +#include <linux/delay.h>
> > +#include <linux/dev_printk.h>
> > +#include <linux/err.h>
> > +#include <linux/export.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/iio/iio.h>
> > +#include <linux/iio/types.h>
> > +#include <linux/module.h>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/regmap.h>
> > +#include <linux/regulator/consumer.h>
> > +#include <linux/reset.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/time.h>
> > +#include <linux/types.h>
> > +#include <linux/unaligned.h>
> > +#include <linux/units.h>  
>