From: Bjorn Helgaas <helgaas@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH v3 3/3] PCI: dw-rockchip: Add pcie_ltssm_state_transition trace support
Date: Tue, 13 Jan 2026 16:03:11 -0600 [thread overview]
Message-ID: <20260113220311.GA782180@bhelgaas> (raw)
In-Reply-To: <1768180800-63364-4-git-send-email-shawn.lin@rock-chips.com>
On Mon, Jan 12, 2026 at 09:20:00AM +0800, Shawn Lin wrote:
> Rockchip platforms provide a 64x4 bytes debug FIFO to trace the
> LTSSM history. Any LTSSM change will be recorded. It's userful
> for debug purpose, for example link failure, etc.
s/userful/useful/
> + * Hardware Mechanism: The ring FIFO employs two tracking counters:
> + * - 'last-read-point': maintains the user's last read position
> + * - 'last-valid-point': tracks the hardware's last state update
> + *
> + * Software Handling: When two consecutive LTSSM states are identical,
> + * it indicates invalid subsequent data in the FIFO. In this case, we
> + * skip the remaining entries. The dual-counter design ensures that on
> + * the next state transition, reading can resume from the last user
> + * position.
Wrap this to fit in 80 columns like the rest of the file. Occasional
code lines that don't fit because of indentation or long meaningful
names are tolerable, but reading plain English text that doesn't fit
for no real reason is just annoying.
prev parent reply other threads:[~2026-01-13 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 1:19 [PATCH v3 0/3] PCI Controller event and LTSSM tracepoint support Shawn Lin
2026-01-12 1:19 ` [PATCH v3 1/3] PCI: trace: Add PCI controller LTSSM transition tracepoint Shawn Lin
2026-01-12 1:19 ` [PATCH v3 2/3] Documentation: tracing: Add PCI controller event documentation Shawn Lin
2026-01-12 1:20 ` [PATCH v3 3/3] PCI: dw-rockchip: Add pcie_ltssm_state_transition trace support Shawn Lin
2026-01-12 6:42 ` kernel test robot
2026-01-12 7:19 ` Shawn Lin
2026-01-12 9:31 ` kernel test robot
2026-01-12 10:15 ` kernel test robot
2026-01-12 15:16 ` Steven Rostedt
2026-01-13 3:55 ` Shawn Lin
2026-01-13 22:03 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113220311.GA782180@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox