Re: [PATCH] Rework the jobserver open logic

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Wed, 14 Jan 2026 09:25:35 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:

> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
> 
> > On all prints, please use file=sys.stderr.  
> 
> I was thinking, as I wrote all those, that I needed a warn() function,
> but then it slipped my mind.

well, you could logging. As this is called also inside kernel-doc,
this could be a good idea.

> 
> >> +            return
> >> +        fds = split_opt[1]
> >> +        #
> >> +        # As of GNU Make 4.4, we'll be looking for a named pipe
> >> +        # identified as fifo:path
> >> +        #
> >> +        if fds.startswith('fifo:'):
> >> +            path = fds[5:]  
> >
> > Hmm... moving from partition() to startswith might be problematic...
> > are we sure that "fifo:" can't be in the middle of the string?  
> 
> If we don't get fifo:file then it's something unexpected and it should
> complain.  At least with these changes it will actually complain.
> 
> > If so, instead of using "5" magic number, I would use len("fifo:")  
> 
> I guess, though that's just replacing one constant with another; if
> something changes, both have to be tweaked either way.

I meant:

	FIFO = "fifo:"
	if fds.startswith(FIFO):
	    path = fds[len(FIFO):]

(or encapsulate it on a function)

> 
> Thanks,
> 
> jon



Thanks,
Mauro