From: Sasha Levin <sashal@kernel.org>
To: jic23@kernel.org
Cc: Michael.Hennerich@analog.com, andy@kernel.org, brgl@bgdev.pl,
conor+dt@kernel.org, corbet@lwn.net, devicetree@vger.kernel.org,
dlechner@baylibre.com, jorge.marques@analog.com,
krzk+dt@kernel.org, lars@metafoo.de, linus.walleij@linaro.org,
linusw@kernel.org, linux-doc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, nuno.sa@analog.com,
robh@kernel.org
Subject: Re: [PATCH v4 0/9] Add support for AD4062 device family
Date: Sat, 17 Jan 2026 10:12:32 -0500 [thread overview]
Message-ID: <20260117151232.215213-1-sashal@kernel.org> (raw)
In-Reply-To: <20251227163506.2fb90815@jic23-huawei>
Hi Jonathan, Jorge,
Heads up: the AD4062 driver uses the deprecated I3C API which was
removed in commit 9904232ae30bc ("i3c: drop i3c_priv_xfer and
i3c_device_do_priv_xfers()"). This causes build failures when
merged with trees containing that commit:
drivers/iio/adc/ad4062.c:471:24: error: variable 'xfer_trigger' has initializer but incomplete type
471 | struct i3c_priv_xfer xfer_trigger = {
| ^~~~~~~~~~~~~
drivers/iio/adc/ad4062.c:472:26: error: 'struct i3c_priv_xfer' has no member named 'data'
...
The fix is straightforward - migrate to the new API:
- struct i3c_priv_xfer -> struct i3c_xfer
- i3c_device_do_priv_xfers(dev, xfers, n) -> i3c_device_do_xfers(dev, xfers, n, I3C_SDR)
The struct fields are identical (i3c_priv_xfer was just a #define
alias), and I3C_SDR is what the old wrapper used internally.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-01-17 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 12:13 [PATCH v4 0/9] Add support for AD4062 device family Jorge Marques
2025-12-17 12:13 ` [PATCH v4 1/9] dt-bindings: iio: adc: Add adi,ad4062 Jorge Marques
2025-12-19 21:04 ` Rob Herring (Arm)
2025-12-17 12:13 ` [PATCH v4 2/9] docs: iio: New docs for ad4062 driver Jorge Marques
2025-12-17 12:13 ` [PATCH v4 3/9] iio: adc: Add support for ad4062 Jorge Marques
2025-12-17 12:13 ` [PATCH v4 4/9] docs: iio: ad4062: Add IIO Trigger support Jorge Marques
2025-12-17 12:13 ` [PATCH v4 5/9] iio: adc: " Jorge Marques
2025-12-17 12:13 ` [PATCH v4 6/9] docs: iio: ad4062: Add IIO Events support Jorge Marques
2025-12-17 12:13 ` [PATCH v4 7/9] iio: adc: " Jorge Marques
2025-12-17 12:13 ` [PATCH v4 8/9] docs: iio: ad4062: Add GPIO Controller support Jorge Marques
2025-12-17 12:13 ` [PATCH v4 9/9] iio: adc: " Jorge Marques
2025-12-17 15:28 ` Bartosz Golaszewski
2025-12-27 16:35 ` [PATCH v4 0/9] Add support for AD4062 device family Jonathan Cameron
2026-01-17 15:12 ` Sasha Levin [this message]
2026-01-19 21:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117151232.215213-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jorge.marques@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox