Re: [PATCH v4 0/9] Add support for AD4062 device family

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 17 Jan 2026 10:12:32 -0500
Sasha Levin <sashal@kernel.org> wrote:

> Hi Jonathan, Jorge,
> 
> Heads up: the AD4062 driver uses the deprecated I3C API which was
> removed in commit 9904232ae30bc ("i3c: drop i3c_priv_xfer and
> i3c_device_do_priv_xfers()"). This causes build failures when
> merged with trees containing that commit:
> 
>   drivers/iio/adc/ad4062.c:471:24: error: variable 'xfer_trigger' has initializer but incomplete type
>     471 |                 struct i3c_priv_xfer xfer_trigger = {
>         |                        ^~~~~~~~~~~~~
>   drivers/iio/adc/ad4062.c:472:26: error: 'struct i3c_priv_xfer' has no member named 'data'
>   ...
> 
> The fix is straightforward - migrate to the new API:
> 
>   - struct i3c_priv_xfer -> struct i3c_xfer
>   - i3c_device_do_priv_xfers(dev, xfers, n) -> i3c_device_do_xfers(dev, xfers, n, I3C_SDR)
> 
> The struct fields are identical (i3c_priv_xfer was just a #define
> alias), and I3C_SDR is what the old wrapper used internally.
> 
Thanks for the heads up! Given this driver was quite a way back in my tree and I'd
rather avoid a rebase, I've sent out a patch on top that makes the changes
you suggest. I'll carry it on the iio/togreg tree now just to avoid causing
build mess in linux-next and just rebase the top the tree if any issues
turn up in review (or to add tags)

Cheers
Jonathan