From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] tools/docs: sphinx-build-wrapper: avoid spurious rust docs generation
Date: Tue, 20 Jan 2026 23:43:17 +0100 [thread overview]
Message-ID: <20260120234317.48887b52@foz.lan> (raw)
In-Reply-To: <20260118-docs-spurious-rust-v1-0-998e14b9ed9e@weissschuh.net>
On Sun, 18 Jan 2026 00:26:20 +0100
Thomas Weißschuh <linux@weissschuh.net> wrote:
> Currently the rust docs are generated for each entry of SPHINXDIRS,
> even those not mentioning the rust directory.
>
> Only generate the rust docs only once and only when requested.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (4):
> tools/docs: sphinx-build-wrapper: generate rust docs only once
> tools/docs: sphinx-build-wrapper: make 'rustdoc' a local variable
> tools/docs: sphinx-build-wrapper: compute sphinxdirs_list earlier
> tools/docs: sphinx-build-wrapper: only generate rust docs when requested
>
> tools/docs/sphinx-build-wrapper | 80 +++++++++++++++++++++--------------------
> 1 file changed, 41 insertions(+), 39 deletions(-)
Patches in this series look ok. Code reviewed and I also did some
tests, and all LGTM.
So, for this series:
[mchehab: tested building with and without config RUST, doing
a full build and also passing --sphinxdirs rust peci and just
--sphinxdirs rust]
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tested-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks,
Mauro
next prev parent reply other threads:[~2026-01-20 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-17 23:26 [PATCH 0/4] tools/docs: sphinx-build-wrapper: avoid spurious rust docs generation Thomas Weißschuh
2026-01-17 23:26 ` [PATCH 1/4] tools/docs: sphinx-build-wrapper: generate rust docs only once Thomas Weißschuh
2026-01-17 23:26 ` [PATCH 2/4] tools/docs: sphinx-build-wrapper: make 'rustdoc' a local variable Thomas Weißschuh
2026-01-17 23:26 ` [PATCH 3/4] tools/docs: sphinx-build-wrapper: compute sphinxdirs_list earlier Thomas Weißschuh
2026-01-17 23:26 ` [PATCH 4/4] tools/docs: sphinx-build-wrapper: only generate rust docs when requested Thomas Weißschuh
2026-01-20 22:43 ` Mauro Carvalho Chehab [this message]
2026-01-23 18:34 ` [PATCH 0/4] tools/docs: sphinx-build-wrapper: avoid spurious rust docs generation Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120234317.48887b52@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox