From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
lihuisong <lihuisong@huawei.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH RFT 3/5] hwmon: Add support for updating thermal zones
Date: Fri, 23 Jan 2026 10:22:06 -0800 [thread overview]
Message-ID: <20260123182208.2229670-4-linux@roeck-us.net> (raw)
In-Reply-To: <20260123182208.2229670-1-linux@roeck-us.net>
Implement support for updating thermal zones. This is necessary
to be able to handle updates to sysfs attribute visibility.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/hwmon.c | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index 1f35285ca7a0..cb89218a0b6a 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -276,7 +276,7 @@ static struct hwmon_thermal_data *hwmon_thermal_find_tz(struct device *dev, int
return NULL;
}
-static int hwmon_thermal_register_sensors(struct device *dev)
+static int hwmon_thermal_handle_sensors(struct device *dev, bool update)
{
struct hwmon_device *hwdev = to_hwmon_device(dev);
const struct hwmon_chip_info *chip = hwdev->chip;
@@ -294,22 +294,42 @@ static int hwmon_thermal_register_sensors(struct device *dev)
continue;
for (j = 0; info[i]->config[j]; j++) {
+ umode_t mode;
int err;
- if (!(info[i]->config[j] & HWMON_T_INPUT) ||
- !hwmon_is_visible(chip->ops, drvdata, hwmon_temp,
- hwmon_temp_input, j))
+ if (!(info[i]->config[j] & HWMON_T_INPUT))
continue;
+ mode = hwmon_is_visible(chip->ops, drvdata, hwmon_temp,
+ hwmon_temp_input, j);
+ if (!mode) {
+ struct hwmon_thermal_data *tzdata;
- err = hwmon_thermal_add_sensor(dev, j);
- if (err)
- return err;
+ if (!update)
+ continue;
+ tzdata = hwmon_thermal_find_tz(dev, j);
+ if (tzdata) {
+ devm_thermal_of_zone_unregister(dev, tzdata->tzd);
+ devm_release_action(dev, hwmon_thermal_remove_sensor,
+ &tzdata->node);
+ }
+ } else {
+ if (!update || !hwmon_thermal_find_tz(dev, j)) {
+ err = hwmon_thermal_add_sensor(dev, j);
+ if (err)
+ return err;
+ }
+ }
}
}
return 0;
}
+static int hwmon_thermal_register_sensors(struct device *dev)
+{
+ return hwmon_thermal_handle_sensors(dev, false);
+}
+
static void hwmon_thermal_notify(struct device *dev, int index)
{
struct hwmon_thermal_data *tzdata = hwmon_thermal_find_tz(dev, index);
--
2.45.2
next prev parent reply other threads:[~2026-01-23 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 18:22 [PATCH RFT 0/5] hwmon: Introduce hwmon_update_groups() Guenter Roeck
2026-01-23 18:22 ` [PATCH RFT 1/5] hwmon: Handle attribute visibility evaluation in device core Guenter Roeck
2026-01-23 18:22 ` [PATCH RFT 2/5] hwmon: Provide helper function to find thermal zones Guenter Roeck
2026-01-23 18:22 ` Guenter Roeck [this message]
2026-01-30 15:44 ` [PATCH RFT 3/5] hwmon: Add support for updating " Guenter Roeck
2026-01-23 18:22 ` [PATCH RFT 4/5] hwmon: Implement hwmon_update_groups() Guenter Roeck
2026-01-23 18:22 ` [PATCH RFT 5/5] hwmon: (acpi_power_meter) Use hwmon_update_groups() to update sensor visibility Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123182208.2229670-4-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jaroslav.pulchart@gooddata.com \
--cc=lihuisong@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox