From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Philipp Stanner <phasta@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
driver-core@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: [PATCH v1 3/3] pinctrl: core: Remove duplicate error messages
Date: Tue, 27 Jan 2026 11:32:08 +0100 [thread overview]
Message-ID: <20260127103325.3925173-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260127103325.3925173-1-andriy.shevchenko@linux.intel.com>
pinctrl_claim_hogs() is covered to report any error via message.
Since that it's not needed in the callers.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index ebf803bff867..342bda2a1bd6 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -2187,10 +2187,8 @@ int pinctrl_enable(struct pinctrl_dev *pctldev)
int error;
error = pinctrl_claim_hogs(pctldev);
- if (error) {
- dev_err(pctldev->dev, "could not claim hogs: %i\n", error);
+ if (error)
return error;
- }
mutex_lock(&pinctrldev_list_mutex);
list_add_tail(&pctldev->node, &pinctrldev_list);
--
2.50.1
next prev parent reply other threads:[~2026-01-27 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 10:32 [PATCH v1 0/3] pinctrl: core: managed resource handling cleanup Andy Shevchenko
2026-01-27 10:32 ` [PATCH v1 1/3] pinctrl: core: Remove unused devm_pinctrl_unregister() Andy Shevchenko
2026-01-28 8:57 ` Bartosz Golaszewski
2026-01-27 10:32 ` [PATCH v1 2/3] pinctrl: core: Simplify devm_pinctrl_*() Andy Shevchenko
2026-01-28 8:59 ` Bartosz Golaszewski
2026-01-27 10:32 ` Andy Shevchenko [this message]
2026-01-28 9:00 ` [PATCH v1 3/3] pinctrl: core: Remove duplicate error messages Bartosz Golaszewski
2026-01-28 13:30 ` [PATCH v1 0/3] pinctrl: core: managed resource handling cleanup Andy Shevchenko
2026-02-03 0:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127103325.3925173-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=rafael@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox