From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E16531AA99 for ; Sun, 1 Feb 2026 09:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769936714; cv=none; b=tfYKcjV3bcGRNopUHmb7xcwk65iOtTy1V4jDwEbybrNv8oNIg5Pmi6nlTd1uR8Y29s/l687+35Qdq3cJMbXACAT/+wyF1gGzfciMbKLjpeBxBOi4WqNSwXf3w59dODvG09Pfh/qZU5zbNsqzcun07MFOlDEajjdE5fmIsipBuKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769936714; c=relaxed/simple; bh=QEWaTUGYIM3AUbjp29sbAba2kUUYgtptVEBxmi5dzvQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d7p1XT1Om/an+Uj+b4UV/UVZ1ze+RfjkOoLKqfRiVEIRKZUtyrsY3db1rpJZNbm2tzqpia06+Ydx1fCamYb0V4oI32ciTovCPC3L0HxHIiFXcWOp1bXVIm7lKa6IotwsSuF1PJl2sIbR/M+cR/AHkAEb+4yXspHRSieeA1RjLww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ejGiy0yY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=s9jbkz2e; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ejGiy0yY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="s9jbkz2e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769936710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n3PpGZtslxQ3EtKo9C9Fdk6vH37O76cwSZfkhQe8fSc=; b=ejGiy0yYrlzERbxn0s2DBF3yBt8IdYwD/wc6fstiXSGud87n2f//XjK6JbPl+8sN0CqxXh e5RnJobBpuccb2BgpDlvWNN+Y49gydQtD8bou+OoRdNJdeCEG3plp2zxAzVxIIRU65rQn7 fXo2u1zIfUNIwTjqlAJukEWIKD6zlN4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-V338XGVXMNKkjBk2k0S7Jg-1; Sun, 01 Feb 2026 04:05:09 -0500 X-MC-Unique: V338XGVXMNKkjBk2k0S7Jg-1 X-Mimecast-MFC-AGG-ID: V338XGVXMNKkjBk2k0S7Jg_1769936708 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4806fc58fa5so31727235e9.2 for ; Sun, 01 Feb 2026 01:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769936708; x=1770541508; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n3PpGZtslxQ3EtKo9C9Fdk6vH37O76cwSZfkhQe8fSc=; b=s9jbkz2eN7gN8syjeRgCFBcAIhMN4Cqa7RPo2gQzAk7QQaEaNTrdAEQ3fo0ittNrUc tWpHk2fyq5itdr4wZDZ8TYYruwRCJbdGhZ97rsSjgO6Cc9eHzgynsc5xxHa2kiebCW3T 3pFO7TBti+J8H2dgL/KU+qk8Lrz36ii3SyNG5cxOC4UlsqnybTlmPXpwtEDOHdS36pJf J6PFL9bjzJ1oKiYQ12pzv/S0WIlfQ0H4rldQtethFVKKlCYYZBvqKSHuRhew8xL7KGmY sxD+oxG70O6OG90PBqxLRwTOUtfO19jRRqRlXYB/Dpt016wHR/C+9wrJztGJdDtmf4yW Ijog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769936708; x=1770541508; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n3PpGZtslxQ3EtKo9C9Fdk6vH37O76cwSZfkhQe8fSc=; b=JLvGp7ZP7Ynp0CFhrSELu1UUrdhhx/jeF1d9/6T4dW7qslO2+p7r8Rg7CTOygT1UoB Oe+P/2pjSjopXkqL5rqfeYi31VCICoTwDTIh/8YncRO6CssmUReLti1BwwR70nIQaW7h eKPBT01HL+8BnCA7aahVyPqYgqH4EbBt+sF3isa95I+v4F7b5PQzRH1/2EXwBexBWG5H t+Hu5+BpfcnmEjnXRMFIjo2q2uCshCYA8Pl2RFn0kZOoXm8xezdDEPdbmZ9G+4TJj5CL s1GfIgyZmNTyfB5d1Wp0TKi00wajsLTOOtDZA/zNhYxLS6mGJTNbU+IGakViMqd2srvB 6z3w== X-Forwarded-Encrypted: i=1; AJvYcCWHvNPEJUDbnMs2T4uXglqJLhe5m1ODAJK1+kh5FAd5nwdNy6kYJZb039qzGOsN/AXPv6oH1Ta7FQw=@vger.kernel.org X-Gm-Message-State: AOJu0YzBD7dlTdRY6RIx/pcMQ62fClqi07XuVNp3CU81hpnubChC+GNf CFeYy39SCXFAB5cbY20rw8OjPShstXzLEuJpKXM74/Eba7s4wltrKGxx2y8rI19E41ncCuHR4bf sLXr+cz5BanfniZ7gvHzF4SQC93jQD2YO80qQWk6Saf0A5fxZWKK6DjQ0Y/Y/rA== X-Gm-Gg: AZuq6aKRdhnd8zMPZNvWJSMiS6lWuhd72CzBv23Oqc2xkF0mC669BVPP+52k1hNcFhm ycgZXKvnNnDApBFqOtBtqWMsvV96J8u5Z7NQRC78Ltw5ok/DQ2MlooLagz0bzwv7980kN2D1d57 gAPKuiDkJED/bM3C814wgiI39nmetTiEZj/+ZwY0DNi0Tp9fXfD9VwMAgf1G6PcHnvWZLp2c+SU Sd6MliqVDv85x8vctx9gtvwbhzLjSpCoakT/XpYQKmtvocFSHXJO4/KGiD02+XypUXnevaxkqZU zo6LuLQOnhXDIDq7fxbP1c4rNoUiAl27WZdOlIRYaSsM3YPsAqee9nxDv6e0mA+1ddC/eeuJWob hUtUajnjGxLzKxnu5YF1UKiPPTzJyOedyRg== X-Received: by 2002:a05:600c:4e56:b0:47e:f481:24b7 with SMTP id 5b1f17b1804b1-482db47cd9emr108399685e9.17.1769936708016; Sun, 01 Feb 2026 01:05:08 -0800 (PST) X-Received: by 2002:a05:600c:4e56:b0:47e:f481:24b7 with SMTP id 5b1f17b1804b1-482db47cd9emr108399225e9.17.1769936707599; Sun, 01 Feb 2026 01:05:07 -0800 (PST) Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e04c13a2sm61038245e9.5.2026.02.01.01.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 01:05:07 -0800 (PST) Date: Sun, 1 Feb 2026 04:05:02 -0500 From: "Michael S. Tsirkin" To: chia-yu.chang@nokia-bell-labs.com Cc: tariqt@nvidia.com, linux-rdma@vger.kernel.org, shaojijie@huawei.com, shenjian15@huawei.com, salil.mehta@huawei.com, mbloch@nvidia.com, saeedm@nvidia.com, leon@kernel.org, eperezma@redhat.com, brett.creeley@amd.com, jasowang@redhat.com, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com, pabeni@redhat.com, edumazet@google.com, parav@nvidia.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@google.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com Subject: Re: [PATCH v1 net-next 2/3] net: hns3/mlx5e: avoid corrupting CWR flag when receiving GRO packet Message-ID: <20260201040151-mutt-send-email-mst@kernel.org> References: <20260131225510.2946-1-chia-yu.chang@nokia-bell-labs.com> <20260131225510.2946-3-chia-yu.chang@nokia-bell-labs.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131225510.2946-3-chia-yu.chang@nokia-bell-labs.com> On Sat, Jan 31, 2026 at 11:55:09PM +0100, chia-yu.chang@nokia-bell-labs.com wrote: > From: Chia-Yu Chang > > In Accurate ECN, ACE counter (AE, ECE, CWR flags) changes only when new > CE packets arrive, while setting SKB_GSO_TCP_ECN in case of not knowing > the ECN variant can result in header change that corrupts the ACE field. > The new flag SKB_GSO_TCP_ACCECN is to prevent SKB_GSO_TCP_ECN or > NETIF_F_TSO_ECN offloading to be used because they would corrupt CWR > flag somewhere. > > Signed-off-by: Chia-Yu Chang Not my driver, but a better format is something along the lines of: Currently .... this is wrong because ... as the result .... fix this by ... so that .... the coding style does say that you should use the imperative form. > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index a47464a22751..3a1cf4335477 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -3897,7 +3897,7 @@ static int hns3_gro_complete(struct sk_buff *skb, u32 l234info) > > skb_shinfo(skb)->gso_segs = NAPI_GRO_CB(skb)->count; > if (th->cwr) > - skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ECN; > + skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ACCECN; > > if (l234info & BIT(HNS3_RXD_GRO_FIXID_B)) > skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_FIXEDID; > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > index 1fc3720d2201..d174f83478a3 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > @@ -1311,7 +1311,7 @@ static void mlx5e_shampo_update_ipv4_tcp_hdr(struct mlx5e_rq *rq, struct iphdr * > skb->csum_offset = offsetof(struct tcphdr, check); > > if (tcp->cwr) > - skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ECN; > + skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ACCECN; > } > > static void mlx5e_shampo_update_ipv6_tcp_hdr(struct mlx5e_rq *rq, struct ipv6hdr *ipv6, > @@ -1332,7 +1332,7 @@ static void mlx5e_shampo_update_ipv6_tcp_hdr(struct mlx5e_rq *rq, struct ipv6hdr > skb->csum_offset = offsetof(struct tcphdr, check); > > if (tcp->cwr) > - skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ECN; > + skb_shinfo(skb)->gso_type |= SKB_GSO_TCP_ACCECN; > } > > static void mlx5e_shampo_update_hdr(struct mlx5e_rq *rq, struct mlx5_cqe64 *cqe, bool match) > -- > 2.34.1