From: Conor Dooley <conor@kernel.org>
To: Marius Cristea <marius.cristea@microchip.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: hwmon: temperature: add support for EMC1812
Date: Thu, 12 Feb 2026 18:12:50 +0000 [thread overview]
Message-ID: <20260212-unsaved-delta-a49468049f10@spud> (raw)
In-Reply-To: <20260212-hw_mon-emc1812-v6-1-e37e9b38d898@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Thu, Feb 12, 2026 at 11:54:07AM +0200, Marius Cristea wrote:
> +
> + # EMC1815: 4 Channels, Supports APD, REC on 1-2 and 3-4
> + - if:
> + properties:
> + compatible:
> + const: microchip,emc1815
> + then:
> + # No restrictions needed, but explicitly allowing them is good documentation
Uh, I don't agree. If we applied this across the board in the name of
"good documentation" we'd end up bloating up so many bindings.
Other than this,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> + properties:
> + microchip,enable-anti-parallel: true
> + microchip,parasitic-res-on-channel1-2: true
> + microchip,parasitic-res-on-channel3-4: true
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-02-12 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 9:54 [PATCH v6 0/2] Add support for Microchip EMC1812 Marius Cristea
2026-02-12 9:54 ` [PATCH v6 1/2] dt-bindings: hwmon: temperature: add support for EMC1812 Marius Cristea
2026-02-12 18:12 ` Conor Dooley [this message]
2026-02-12 9:54 ` [PATCH v6 2/2] " Marius Cristea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212-unsaved-delta-a49468049f10@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marius.cristea@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox