From: Bjorn Helgaas <helgaas@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
Philipp Stanner <phasta@kernel.org>
Subject: Re: [PATCH v2 0/3] Clarify pci_free_irq_vectors() usage constraints
Date: Thu, 12 Feb 2026 15:28:29 -0600 [thread overview]
Message-ID: <20260212212829.GA3089824@bhelgaas> (raw)
In-Reply-To: <1770798299-202288-1-git-send-email-shawn.lin@rock-chips.com>
On Wed, Feb 11, 2026 at 04:24:56PM +0800, Shawn Lin wrote:
> pcim_enable_device() automatically manages IRQ vectors, which can cause
> double-free issues if drivers manually call pci_free_irq_vectors().
>
> This series adds documentation and warnings to prevent this:
> 1. msi-howto.rst guidance
> 2. kernel-doc warning
> 3. TODO comment for future cleanup
>
>
> Changes in v2:
> - rework the commit message and documentation
>
> Shawn Lin (3):
> Documentation: PCI: Clarify pci_free_irq_vectors() usage for managed
> devices
> PCI/MSI: Add warning to pci_free_irq_vectors() documentation
> PCI/MSI: Add TODO comment about legacy pcim_enable_device()
> side-effect
>
> Documentation/PCI/msi-howto.rst | 7 +++++--
> drivers/pci/msi/api.c | 5 +++++
> drivers/pci/msi/msi.c | 10 ++++++++++
> 3 files changed, 20 insertions(+), 2 deletions(-)
Squashed the first two patches and applied to pci/msi for v7.1,
thanks!
This will be rebased to v7.0-rc1 after it is tagged.
prev parent reply other threads:[~2026-02-12 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 8:24 [PATCH v2 0/3] Clarify pci_free_irq_vectors() usage constraints Shawn Lin
2026-02-11 8:24 ` [PATCH v2 1/3] Documentation: PCI: Clarify pci_free_irq_vectors() usage for managed devices Shawn Lin
2026-02-11 8:24 ` [PATCH v2 2/3] PCI/MSI: Add warning to pci_free_irq_vectors() documentation Shawn Lin
2026-02-11 8:24 ` [PATCH v2 3/3] PCI/MSI: Add TODO comment about legacy pcim_enable_device() side-effect Shawn Lin
2026-02-12 21:28 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212212829.GA3089824@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox