From: Jonathan Cameron <jic23@kernel.org>
To: Taha Ed-Dafili <0rayn.dev@gmail.com>
Cc: dlechner@baylibre.com, rdunlap@infradead.org,
skhan@linuxfoundation.org,
linux-kernel-mentees-archive@lists.linuxfoundation.org,
nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] iio: accel: adxl345: Add event scaling and doc fixes
Date: Sat, 14 Feb 2026 17:21:45 +0000 [thread overview]
Message-ID: <20260214172145.69cab531@jic23-huawei> (raw)
In-Reply-To: <20260208150515.14798-1-0rayn.dev@gmail.com>
On Sun, 8 Feb 2026 10:05:01 -0500
Taha Ed-Dafili <0rayn.dev@gmail.com> wrote:
> This series addresses ADXL345 driver non-compliance with the IIO ABI
> for event thresholds.
>
> Currently, the driver exposes raw values for thresholds (e.g., tap,
> activity) without providing the necessary scale factor to convert them
> to SI units (m/s^2), as mandated by the ABI.
>
> This series implements `IIO_EV_INFO_SCALE` in the IIO core and applies
> it to the ADXL345 driver, ensuring that userspace can correctly
> interpret threshold values. It also cleans up existing documentation
> errors and typos.
Nice series thanks!
Applied to the testing branch of iio.git which I'll rebase once rc1 is available.
Jonathan
>
> Changes in v3:
> - Patch 1: Reverted "axis" -> "axes" change in documentation as it is
> used as an adjective (Randy Dunlap).
> - Patch 2: Reworded commit message to "Implement support for..." instead
> of "missing from..." (David Lechner).
> - Patch 4: Simplified documentation table by removing repetitive scale
> values from every row. Added explicit table entries for the new
> `in_accel_gesture_scale` and `in_accel_mag_scale` attributes instead
> (Jonathan Cameron).
> - Patch 4: Fixed "inscale" typo in commit message.
>
> Changes in v2:
> - Added core infrastructure for IIO_EV_INFO_SCALE.
> - Implemented event scaling (0.612915 m/s^2) for ADXL345.
> - Fixed technical math/decimal errors in existing documentation.
> - Cleaned up grammar and pluralization issues in .rst file.
>
> Taha Ed-Dafili (4):
> docs: iio: adxl345: fix typos and grammar
> iio: core: Add IIO_EV_INFO_SCALE to event info
> iio: accel: adxl345: Implement event scaling for ABI compliance
> docs: iio: adxl345: update math and examples for scaling
>
> Documentation/iio/adxl345.rst | 65 +++++++++++++++++++-------------
> drivers/iio/accel/adxl345_core.c | 28 +++++++++++---
> drivers/iio/industrialio-event.c | 1 +
> include/linux/iio/types.h | 1 +
> 4 files changed, 63 insertions(+), 32 deletions(-)
>
next prev parent reply other threads:[~2026-02-14 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 15:05 [PATCH v3 0/4] iio: accel: adxl345: Add event scaling and doc fixes Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 1/4] docs: iio: adxl345: fix typos and grammar Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-08 15:05 ` [PATCH v3 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-14 17:02 ` David Lechner
2026-02-14 17:09 ` David Lechner
2026-02-14 18:22 ` Andy Shevchenko
2026-02-14 21:49 ` Randy Dunlap
2026-02-08 15:05 ` [PATCH v3 4/4] docs: iio: adxl345: update math and examples for scaling Taha Ed-Dafili
2026-02-14 17:11 ` David Lechner
2026-02-15 19:29 ` Jonathan Cameron
2026-02-14 17:21 ` Jonathan Cameron [this message]
2026-02-15 15:57 ` [PATCH v3 0/4] iio: accel: adxl345: Add event scaling and doc fixes Jonathan Cameron
2026-02-15 17:11 ` Taha Ed-Dafili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260214172145.69cab531@jic23-huawei \
--to=jic23@kernel.org \
--cc=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox