From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: linux-iio@vger.kernel.org, jic23@kernel.org
Cc: dlechner@baylibre.com, rdunlap@infradead.org,
skhan@linuxfoundation.org,
linux-kernel-mentees-archive@lists.linuxfoundation.org,
nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Taha Ed-Dafili <0rayn.dev@gmail.com>
Subject: [PATCH v5 0/5] iio: accel: adxl345: Implement event scaling and ABI compliance
Date: Tue, 24 Feb 2026 14:03:43 +0000 [thread overview]
Message-ID: <20260224140351.27288-1-0rayn.dev@gmail.com> (raw)
This series addresses ADXL345 driver non-compliance with the IIO ABI.
Currently, the driver exposes raw threshold values without a scale factor
to convert them to SI units (m/s^2). It also hides the double tap
threshold value because it shares a hardware register with single tap,
which violates ABI expectations.
This series implements `IIO_EV_INFO_SCALE` in the IIO core and applies it
to the ADXL345 driver. It also exposes the missing `IIO_EV_INFO_VALUE` for
double tap, ensuring userspace can correctly interpret all events, and
cleans up related documentation.
Changes in v5:
- Split the series into 5 patches for better logical separation.
- Patch 1: Moved alphabetical sorting of the event attribute table here
(David Lechner).
- Patch 3 (new): Expose `IIO_EV_INFO_VALUE` for the double tap event to
ensure ABI compliance (Jonathan Cameron).
- Patch 5: Add the newly exposed `in_accel_gesture_doubletap_value` to
the documentation.
Changes in v4:
- Fixed missing IIO_EV_INFO_SCALE handling for MAG/MAG_ADAPTIVE events.
- Explicitly rejected writes to IIO_EV_INFO_SCALE with -EINVAL.
- Fixed bitmask ordering and whitespace alignment.
- Updated documentation with exact sysfs scale attributes.
Changes in v3:
- Reverted "axis" to "axes" in documentation.
- Removed repetitive scale values from documentation table.
Changes in v2:
- Added core infrastructure for IIO_EV_INFO_SCALE.
- Implemented event scaling (0.612915 m/s^2) for ADXL345.
Thanks to David Lechner for the structural patch feedback and Jonathan
Cameron for the architectural guidance on ABI compliance.
Taha Ed-Dafili (5):
docs: iio: adxl345: grammar and formatting cleanups
iio: core: Add IIO_EV_INFO_SCALE to event info
iio: accel: adxl345: Expose IIO_EV_INFO_VALUE for double tap
iio: accel: adxl345: Implement event scaling for ABI compliance
docs: iio: adxl345: update event attributes and scaling math
Documentation/iio/adxl345.rst | 81 ++++++++++++++++++++------------
drivers/iio/accel/adxl345_core.c | 38 ++++++++++-----
drivers/iio/industrialio-event.c | 1 +
include/linux/iio/types.h | 1 +
4 files changed, 81 insertions(+), 40 deletions(-)
--
2.47.3
next reply other threads:[~2026-02-24 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 14:03 Taha Ed-Dafili [this message]
2026-02-24 14:03 ` [PATCH v5 1/5] docs: iio: adxl345: grammar and formatting cleanups Taha Ed-Dafili
2026-02-24 14:03 ` [PATCH v5 2/5] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-24 14:03 ` [PATCH v5 3/5] iio: accel: adxl345: Expose IIO_EV_INFO_VALUE for double tap Taha Ed-Dafili
2026-02-24 14:55 ` Andy Shevchenko
2026-02-24 15:03 ` Andy Shevchenko
2026-02-26 15:03 ` Taha Ed-Dafili
2026-02-26 16:02 ` Andy Shevchenko
2026-02-24 14:03 ` [PATCH v5 4/5] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-24 14:58 ` Andy Shevchenko
2026-02-24 14:03 ` [PATCH v5 5/5] docs: iio: adxl345: update event attributes and scaling math Taha Ed-Dafili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224140351.27288-1-0rayn.dev@gmail.com \
--to=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox