From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDAA236405F; Tue, 24 Feb 2026 15:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771946740; cv=none; b=COxJB89gsIq6+szC+G6CNJXwmPM0aYwsCl08IxIm/giCSa9pY3R4kVvrHLeYucDvD+tlIE+RoDcdtFiKC6byzTDXSchvrYr3c+zLazcReKphggCICFhF1but7VMbXWtHMnyyLkuikouYbih9QR+S57T2fAohrViCiU0ZgGj9HsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771946740; c=relaxed/simple; bh=6BF5HaruXzs6cSNgyt8FXFsH8ahTogOeLQmutq2pJzk=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KNxpIlU53VtVilstJBOx2+arB79aENW5fc2eE3GtXypYhTe9DAZx4EjgKxiNkY7/Mr17SlF5+ged63cm0dHSSD7wfsAlXnegXmr5xP6AhLq+P2mn/v1JCCq0ScG/CWJ4MpS0hkAVsK2GHCUCsWIv7sd3jkStiOuQGP/NZpor9iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4fL1k03LybzHnHWN; Tue, 24 Feb 2026 23:24:56 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id 9A2B740570; Tue, 24 Feb 2026 23:25:36 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 24 Feb 2026 15:25:35 +0000 Date: Tue, 24 Feb 2026 15:25:34 +0000 From: Jonathan Cameron To: Ahmed Tiba CC: , , , , , , , , , , , , , Subject: Re: [PATCH v2 02/11] ACPI: APEI: GHES: add ghes_cper.o stub Message-ID: <20260224152534.000040b6@huawei.com> In-Reply-To: <20260220-topics-ahmtib01-ras_ffh_arm_internal_review-v2-2-347fa2d7351b@arm.com> References: <20260220-topics-ahmtib01-ras_ffh_arm_internal_review-v2-0-347fa2d7351b@arm.com> <20260220-topics-ahmtib01-ras_ffh_arm_internal_review-v2-2-347fa2d7351b@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500012.china.huawei.com (7.191.174.4) To dubpeml500005.china.huawei.com (7.214.145.207) On Fri, 20 Feb 2026 13:42:20 +0000 Ahmed Tiba wrote: > Introduce a dedicated ghes_cper translation unit so that follow-on commits > can move helpers out of ghes.c without touching the build logic twice. > This keeps the object in the tree while remaining functionally identical. I'd probably do this with the first move patch not as a separate patch. That would resolve the question of headers etc below. > > Signed-off-by: Ahmed Tiba > --- > drivers/acpi/apei/Makefile | 2 +- > drivers/acpi/apei/ghes_cper.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/Makefile b/drivers/acpi/apei/Makefile > index 1a0b85923cd4..b3774af70883 100644 > --- a/drivers/acpi/apei/Makefile > +++ b/drivers/acpi/apei/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_ACPI_APEI) += apei.o > -obj-$(CONFIG_ACPI_APEI_GHES) += ghes.o > +obj-$(CONFIG_ACPI_APEI_GHES) += ghes.o ghes_cper.o > # clang versions prior to 18 may blow out the stack with KASAN > ifeq ($(CONFIG_COMPILE_TEST)_$(CONFIG_CC_IS_CLANG)_$(call clang-min-version, 180000),y_y_) > KASAN_SANITIZE_ghes.o := n > diff --git a/drivers/acpi/apei/ghes_cper.c b/drivers/acpi/apei/ghes_cper.c > new file mode 100644 > index 000000000000..63047322a3d9 > --- /dev/null > +++ b/drivers/acpi/apei/ghes_cper.c > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * As below. > + * APEI GHES CPER helper translation unit - staging file for helper moves > + * > + * Copyright (C) 2026 ARM Ltd. As before. If there isn't significant new content copyright doesn't make sense yet. > + * Author: Ahmed Tiba > + * Based on ACPI APEI GHES driver. > + * No obvious benefit in this blank line so I'd drop it. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include Build includes up as they become relevant. That way we can see whether they are needed or not. Right now none of them are.. > + > +#include > + > +#include > +#include > + > +#include "apei-internal.h" > + > +/* Helper bodies will be moved here in follow-up commits. */ >