[PATCH] Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>

[PATCH] Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>

[Afkari Zergaw]

firewire: net: fix FIXME comment punctuation

Add a missing colon after the FIXME tag in the comment to follow
the standard kernel comment style.

Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>
---
 drivers/firewire/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index f1a2bee39bf1..70ceab772208 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -121,7 +121,7 @@ struct fwnet_partial_datagram {
 	struct list_head pd_link;
 	struct list_head fi_list;
 	struct sk_buff *skb;
-	/* FIXME Why not use skb->data? */
+	/* FIXME: Why not use skb->data? */
 	char *pbuf;
 	u16 datagram_label;
 	u16 ether_type;
-- 
2.43.0

Re: [PATCH] Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>

[Takashi Sakamoto]

Hi,

On Sun, Mar 01, 2026 at 08:36:12AM +0000, Afkari Zergaw wrote:
> firewire: net: fix FIXME comment punctuation
> 
> Add a missing colon after the FIXME tag in the comment to follow
> the standard kernel comment style.
> 
> Signed-off-by: Afkari Zergaw <afkarizergaw12@gmail.com>
> ---
>  drivers/firewire/net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
> index f1a2bee39bf1..70ceab772208 100644
> --- a/drivers/firewire/net.c
> +++ b/drivers/firewire/net.c
> @@ -121,7 +121,7 @@ struct fwnet_partial_datagram {
>  	struct list_head pd_link;
>  	struct list_head fi_list;
>  	struct sk_buff *skb;
> -	/* FIXME Why not use skb->data? */
> +	/* FIXME: Why not use skb->data? */
>  	char *pbuf;
>  	u16 datagram_label;
>  	u16 ether_type;
> -- 
> 2.43.0

I'm sorry but in my polocy to maintain this subsystem this kind of
cosmetic change would not be applied.

And next time please send your change to my address, being CCed to both
lkml and linux1394-devel would be preferable.

For recent status of this subsystem, this document would provide good
information to you:
https://ieee1394.docs.kernel.org/


Thanks

Takashi Sakamoto