Re: [PATCH net-next 2/2] net/smc: Add documentation for limit_smc_hs and hs_ctrl

["D. Wythe" <alibuda@linux.alibaba.com >]

On Fri, Mar 06, 2026 at 01:40:39AM +0900, Kyoji Ogasawara wrote:
> > > +hs_ctrl - STRING
> > > +     Select the SMC handshake control profile by name.
> > > +
> > > +     The selected profile controls whether SMC options are advertised
> > > +     during TCP SYN/SYN-ACK handshake.
> > > +
> > > +     Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
> > > +     Write an empty string to clear the current profile.
> >
> > It would be better to clarify that this string refers to the name of a
> > BPF struct_ops (type smc_hs_ctrl) implemented by the user.
> >
> 
> Thanks for the suggestion.
> I updated the hs_ctrl description to clarify that the string is the
> name of a user-implemented BPF struct_ops instance of type
> smc_hs_ctrl.
> Does this address your comment?
> 
> ```
>  hs_ctrl - STRING
>         Select the SMC handshake control profile by name.
> 
> +       This string refers to the name of a user-implemented
> +       BPF struct_ops instance of type smc_hs_ctrl.
> +
>         The selected profile controls whether SMC options are advertised
>         during TCP SYN/SYN-ACK handshake.
> 
>         Only available when CONFIG_SMC_HS_CTRL_BPF is enabled.
>         Write an empty string to clear the current profile.
> 
>         Default: empty string
> ```

LGTM. Thanks for your contribution.

D. Wythe