public inbox for linux-doc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] docs: netdev: improve wording of reviewer guidance
@ 2026-04-06 17:53 Jakub Kicinski
  2026-04-06 18:09 ` Joe Damato
  2026-04-06 18:37 ` Nicolai Buchwitz
  0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2026-04-06 17:53 UTC (permalink / raw)
  To: davem
  Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
	corbet, skhan, workflows, linux-doc

Reword the reviewer guidance based on behavior we see on the list.
Steer folks:
 - towards sending tags
 - away from process issues.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: corbet@lwn.net
CC: skhan@linuxfoundation.org
CC: workflows@vger.kernel.org
CC: linux-doc@vger.kernel.org
---
 Documentation/process/maintainer-netdev.rst | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
index 3aa13bc2405d..bda93b459a05 100644
--- a/Documentation/process/maintainer-netdev.rst
+++ b/Documentation/process/maintainer-netdev.rst
@@ -551,10 +551,12 @@ helpful tips please see :ref:`development_advancedtopics_reviews`.
 
 It's safe to assume that netdev maintainers know the community and the level
 of expertise of the reviewers. The reviewers should not be concerned about
-their comments impeding or derailing the patch flow.
+their comments impeding or derailing the patch flow. A Reviewed-by tag
+is understood to mean "I have reviewed this code to the best of my ability"
+rather than "I can attest this code is correct".
 
-Less experienced reviewers are highly encouraged to do more in-depth
-review of submissions and not focus exclusively on trivial or subjective
+Reviewers are highly encouraged to do more in-depth review of submissions
+and not focus exclusively on process issues, trivial or subjective
 matters like code formatting, tags etc.
 
 Testimonials / feedback
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] docs: netdev: improve wording of reviewer guidance
  2026-04-06 17:53 [PATCH net-next] docs: netdev: improve wording of reviewer guidance Jakub Kicinski
@ 2026-04-06 18:09 ` Joe Damato
  2026-04-06 18:37 ` Nicolai Buchwitz
  1 sibling, 0 replies; 3+ messages in thread
From: Joe Damato @ 2026-04-06 18:09 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, corbet,
	skhan, workflows, linux-doc

On Mon, Apr 06, 2026 at 10:53:34AM -0700, Jakub Kicinski wrote:
> Reword the reviewer guidance based on behavior we see on the list.
> Steer folks:
>  - towards sending tags
>  - away from process issues.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: skhan@linuxfoundation.org
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org
> ---
>  Documentation/process/maintainer-netdev.rst | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Joe Damato <joe@dama.to>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] docs: netdev: improve wording of reviewer guidance
  2026-04-06 17:53 [PATCH net-next] docs: netdev: improve wording of reviewer guidance Jakub Kicinski
  2026-04-06 18:09 ` Joe Damato
@ 2026-04-06 18:37 ` Nicolai Buchwitz
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolai Buchwitz @ 2026-04-06 18:37 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, corbet,
	skhan, workflows, linux-doc

On 6.4.2026 19:53, Jakub Kicinski wrote:
> Reword the reviewer guidance based on behavior we see on the list.
> Steer folks:
>  - towards sending tags
>  - away from process issues.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: corbet@lwn.net
> CC: skhan@linuxfoundation.org
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org
> ---
>  Documentation/process/maintainer-netdev.rst | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst 
> b/Documentation/process/maintainer-netdev.rst
> index 3aa13bc2405d..bda93b459a05 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -551,10 +551,12 @@ helpful tips please see 
> :ref:`development_advancedtopics_reviews`.
> 
>  It's safe to assume that netdev maintainers know the community and the 
> level
>  of expertise of the reviewers. The reviewers should not be concerned 
> about
> -their comments impeding or derailing the patch flow.
> +their comments impeding or derailing the patch flow. A Reviewed-by tag
> +is understood to mean "I have reviewed this code to the best of my 
> ability"
> +rather than "I can attest this code is correct".
> 

I had the same hesitation when starting to review on netdev, unsure if 
my R-b
carried any value. Therefore I appreciate the addition.

> -Less experienced reviewers are highly encouraged to do more in-depth
> -review of submissions and not focus exclusively on trivial or 
> subjective
> +Reviewers are highly encouraged to do more in-depth review of 
> submissions
> +and not focus exclusively on process issues, trivial or subjective
>  matters like code formatting, tags etc.
> 
>  Testimonials / feedback

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-06 18:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-06 17:53 [PATCH net-next] docs: netdev: improve wording of reviewer guidance Jakub Kicinski
2026-04-06 18:09 ` Joe Damato
2026-04-06 18:37 ` Nicolai Buchwitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox