From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4B63B9D8C; Tue, 7 Apr 2026 13:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568165; cv=none; b=ghk9IurjDnFehRi0wHpxGWB0ak/PHeH9doNWwGvVb2TcJ/nB2fNy9TL07pbGDjkvt14+947CqQ3Pyhcr1NVPPKhpFYqFOQqjZH4L0BtlAG5X9kgRHK+VxqmITnh4MqGNW9Be0Dqa/dNAV2IXO6WiLayRJEjBll6A3bAPq9u5s90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568165; c=relaxed/simple; bh=QsfWLs2tuIZnRN7M+rne4mPXGqyvfLmtMwoip+RYIUc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=reEBi98IIOllzV84g19oGfI9J7du9rtyzlDC+7t8VcseOZ4b5RfFFYb3+qHK+APJZ77B2qkeF2YdORL+sykuqoO0AYJzesXFbA1hU1ihSpQ0yZd7dAvaLDR8gApfNZVReiAboukRkDpCY0XHNgOJ2nfjajgHOZtz42Gj9aA6v6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RxW1oL4I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RxW1oL4I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57780C19424; Tue, 7 Apr 2026 13:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775568165; bh=QsfWLs2tuIZnRN7M+rne4mPXGqyvfLmtMwoip+RYIUc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RxW1oL4IZBowPtl0gZvIpDpo3h/HT7kNNvUc0kstM9e1pi+wdlYeavmx8twbMr7R1 aYu6NNwpoxXOMgUQrcvaNZ0o8DhAkBHUIMF4hRisjgeJV/9fNDPKXKjTmJzV2/JhGt aQCQF6V7hzDignfgMPTmFJ+Wn+Rsk1GUl9BiewxR/OM9j4yo9EEcosFvvr8a9ciJ0C Xp/PZyapPfB/FsNI+mU1hQDOkfZcXm87sJX8/HNgiPwXPGMtIMUzQDpPHuX5/sqjod E9WLzeoKe740fBfmQmIO0AsBXiR3jJ9iAi6N3aVkKmbtWkBDMr2+0h7I7Jbl+zgHrj 1rZaBrNIJ378A== From: Jeff Layton Date: Tue, 07 Apr 2026 09:21:23 -0400 Subject: [PATCH 10/24] nfsd: add callback encoding and decoding linkages for CB_NOTIFY Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260407-dir-deleg-v1-10-aaf68c478abd@kernel.org> References: <20260407-dir-deleg-v1-0-aaf68c478abd@kernel.org> In-Reply-To: <20260407-dir-deleg-v1-0-aaf68c478abd@kernel.org> To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Alexander Aring , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Amir Goldstein Cc: Calum Mackay , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3990; i=jlayton@kernel.org; h=from:subject:message-id; bh=QsfWLs2tuIZnRN7M+rne4mPXGqyvfLmtMwoip+RYIUc=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBp1QUGGQBA59bo7BEIDhxHETnkunHictFtwHMbl xfsKUrQixOJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCadUFBgAKCRAADmhBGVaC FTXcEACW/CYK7/vpVn7qgSBZE+ENIo4OvJlBFQ7Lii/m9yQJGwPIPFZ6SP7R0tMY7lGVfv2K82K 1+ZM/O8BJ7xx8CGU3Ww2d4yv+LsWfWoFgkU1w4EncV1zHVRrHvan69yqrJ2AHof5JCz8fbK41uZ +v87NAzr/qXyRP2HaoxISq5PU5AfmrnsKCSd2DmU5gK0wTmcgEVtJwkHRpt+pA+t8te6ZIOYFfT Tmx1N+IZY8SmorIIDhC4evRL9Mhm/pb+zm4sETqPTOfu2ukpYopo+rFJ+vVClrAw2a3pBk2k/Z4 x1HvdRCy2Y/wFPTgvwUIdQNYJpmRepqboRZ9O3QToMz/Wvpuc4H7tiuPQIgLYtRDQQ6JsaFXfw0 HfZq/+N1Z71ij2Cg4tusYG9S0Q6PtsbNtWrGOjP1iR+LLi6uLNomLb1kzO/Hvj7HFHyPpre7f2R 4g3wliMECBABoYzMohgsATzJOJxSGNmgNXuHIpijFlAj2NPeCINlEgyJVMsdZedL3izLKj+/xwU GEqwnqxaVG2Y+VbG/GAnwlP4tZPHqVy6/5pYgL+pLrHX5d3I19du+eMe5nR7VYLQv2W54vbuscP dlBrqySUJwBPCxDUIca7TFSg10U0PmobL3GIVRV7RB5FwQ3pY3PuRn0TPotiM0cUrGoSZRpZBpe iyKxVEBvw0pIRiA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Add routines for encoding and decoding CB_NOTIFY messages. These call into the code generated by xdrgen to do the actual encoding and decoding. Signed-off-by: Jeff Layton --- fs/nfsd/nfs4callback.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ fs/nfsd/state.h | 8 ++++++++ fs/nfsd/xdr4cb.h | 12 ++++++++++++ 3 files changed, 66 insertions(+) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 25bbf5b8814d..ea3e7deb06fa 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -865,6 +865,51 @@ static void encode_stateowner(struct xdr_stream *xdr, struct nfs4_stateowner *so xdr_encode_opaque(p, so->so_owner.data, so->so_owner.len); } +static void nfs4_xdr_enc_cb_notify(struct rpc_rqst *req, + struct xdr_stream *xdr, + const void *data) +{ + const struct nfsd4_callback *cb = data; + struct nfs4_cb_compound_hdr hdr = { + .ident = 0, + .minorversion = cb->cb_clp->cl_minorversion, + }; + struct CB_NOTIFY4args args = { }; + + WARN_ON_ONCE(hdr.minorversion == 0); + + encode_cb_compound4args(xdr, &hdr); + encode_cb_sequence4args(xdr, cb, &hdr); + + /* + * FIXME: get stateid and fh from delegation. Inline the cna_changes + * buffer, and zero it. + */ + WARN_ON_ONCE(!xdrgen_encode_CB_NOTIFY4args(xdr, &args)); + + hdr.nops++; + encode_cb_nops(&hdr); +} + +static int nfs4_xdr_dec_cb_notify(struct rpc_rqst *rqstp, + struct xdr_stream *xdr, + void *data) +{ + struct nfsd4_callback *cb = data; + struct nfs4_cb_compound_hdr hdr; + int status; + + status = decode_cb_compound4res(xdr, &hdr); + if (unlikely(status)) + return status; + + status = decode_cb_sequence4res(xdr, cb); + if (unlikely(status || cb->cb_seq_status)) + return status; + + return decode_cb_op_status(xdr, OP_CB_NOTIFY, &cb->cb_status); +} + static void nfs4_xdr_enc_cb_notify_lock(struct rpc_rqst *req, struct xdr_stream *xdr, const void *data) @@ -1026,6 +1071,7 @@ static const struct rpc_procinfo nfs4_cb_procedures[] = { #ifdef CONFIG_NFSD_PNFS PROC(CB_LAYOUT, COMPOUND, cb_layout, cb_layout), #endif + PROC(CB_NOTIFY, COMPOUND, cb_notify, cb_notify), PROC(CB_NOTIFY_LOCK, COMPOUND, cb_notify_lock, cb_notify_lock), PROC(CB_OFFLOAD, COMPOUND, cb_offload, cb_offload), PROC(CB_RECALL_ANY, COMPOUND, cb_recall_any, cb_recall_any), diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h index 7d2afe7dcc3e..22c9a1e7d8fd 100644 --- a/fs/nfsd/state.h +++ b/fs/nfsd/state.h @@ -190,6 +190,13 @@ struct nfs4_cb_fattr { u64 ncf_cur_fsize; }; +/* + * FIXME: the current backchannel encoder can't handle a send buffer longer + * than a single page (see bc_alloc/bc_free). + */ +#define NOTIFY4_EVENT_QUEUE_SIZE 3 +#define NOTIFY4_PAGE_ARRAY_SIZE 1 + /* * Represents a delegation stateid. The nfs4_client holds references to these * and they are put when it is being destroyed or when the delegation is @@ -774,6 +781,7 @@ enum nfsd4_cb_op { NFSPROC4_CLNT_CB_NOTIFY_LOCK, NFSPROC4_CLNT_CB_RECALL_ANY, NFSPROC4_CLNT_CB_GETATTR, + NFSPROC4_CLNT_CB_NOTIFY, }; /* Returns true iff a is later than b: */ diff --git a/fs/nfsd/xdr4cb.h b/fs/nfsd/xdr4cb.h index f4e29c0c701c..b06d0170d7c4 100644 --- a/fs/nfsd/xdr4cb.h +++ b/fs/nfsd/xdr4cb.h @@ -33,6 +33,18 @@ cb_sequence_dec_sz + \ op_dec_sz) +#define NFS4_enc_cb_notify_sz (cb_compound_enc_hdr_sz + \ + cb_sequence_enc_sz + \ + 1 + enc_stateid_sz + \ + enc_nfs4_fh_sz + \ + 1 + \ + NOTIFY4_EVENT_QUEUE_SIZE * \ + (2 + (NFS4_OPAQUE_LIMIT >> 2))) + +#define NFS4_dec_cb_notify_sz (cb_compound_dec_hdr_sz + \ + cb_sequence_dec_sz + \ + op_dec_sz) + #define NFS4_enc_cb_notify_lock_sz (cb_compound_enc_hdr_sz + \ cb_sequence_enc_sz + \ 2 + 1 + \ -- 2.53.0