From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>
Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-doc@vger.kernel.org,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: [PATCH v13 05/27] drm/display: bridge_connector: Use HDMI color format for HDMI conns
Date: Mon, 13 Apr 2026 12:07:19 +0200 [thread overview]
Message-ID: <20260413-color-format-v13-5-ab37d4dfba48@collabora.com> (raw)
In-Reply-To: <20260413-color-format-v13-0-ab37d4dfba48@collabora.com>
For bridge connectors which contain an HDMI bridge at some stage, the
HDMI state helpers' format selection logic should be involved.
Add an implementation for the drm_bridge_funcs color_format function,
which translates from the HDMI state's output format to a connector
format for bridge connectors involving an HDMI bridge, but return the
connector state's color_format member unchanged otherwise.
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
drivers/gpu/drm/display/drm_bridge_connector.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c
index 39cc18f78eda..bcfa4f2ca3e4 100644
--- a/drivers/gpu/drm/display/drm_bridge_connector.c
+++ b/drivers/gpu/drm/display/drm_bridge_connector.c
@@ -276,6 +276,29 @@ static void drm_bridge_connector_reset(struct drm_connector *connector)
connector->state);
}
+static enum drm_connector_color_format
+drm_bridge_connector_color_format(const struct drm_connector_state *conn_state)
+{
+ struct drm_bridge_connector *bridge_connector =
+ to_drm_bridge_connector(conn_state->connector);
+
+ if (bridge_connector->bridge_hdmi) {
+ switch (conn_state->hdmi.output_format) {
+ default:
+ case DRM_OUTPUT_COLOR_FORMAT_RGB444:
+ return DRM_CONNECTOR_COLOR_FORMAT_RGB444;
+ case DRM_OUTPUT_COLOR_FORMAT_YCBCR444:
+ return DRM_CONNECTOR_COLOR_FORMAT_YCBCR444;
+ case DRM_OUTPUT_COLOR_FORMAT_YCBCR422:
+ return DRM_CONNECTOR_COLOR_FORMAT_YCBCR422;
+ case DRM_OUTPUT_COLOR_FORMAT_YCBCR420:
+ return DRM_CONNECTOR_COLOR_FORMAT_YCBCR420;
+ }
+ }
+
+ return conn_state->color_format;
+}
+
static const struct drm_connector_funcs drm_bridge_connector_funcs = {
.reset = drm_bridge_connector_reset,
.detect = drm_bridge_connector_detect,
@@ -285,6 +308,7 @@ static const struct drm_connector_funcs drm_bridge_connector_funcs = {
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
.debugfs_init = drm_bridge_connector_debugfs_init,
.oob_hotplug_event = drm_bridge_connector_oob_hotplug_event,
+ .color_format = drm_bridge_connector_color_format,
};
/* -----------------------------------------------------------------------------
--
2.53.0
next prev parent reply other threads:[~2026-04-13 10:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 10:07 [PATCH v13 00/27] Add new general DRM property "color format" Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 01/27] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 02/27] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 03/27] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 04/27] drm/connector: Let connectors have a say in their color format Nicolas Frattaroli
2026-04-13 10:07 ` Nicolas Frattaroli [this message]
2026-04-13 10:07 ` [PATCH v13 06/27] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 07/27] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 08/27] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 09/27] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 10/27] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 11/27] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-04-13 18:58 ` Ville Syrjälä
2026-04-13 19:04 ` Ville Syrjälä
2026-04-13 10:07 ` [PATCH v13 12/27] drm/i915/dp: " Nicolas Frattaroli
2026-04-13 19:08 ` Ville Syrjälä
2026-04-13 10:07 ` [PATCH v13 13/27] drm/i915: Implement the "color format" DRM property Nicolas Frattaroli
2026-04-13 19:21 ` Ville Syrjälä
2026-04-13 10:07 ` [PATCH v13 14/27] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 15/27] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 16/27] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 17/27] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 18/27] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 19/27] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 20/27] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 21/27] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 22/27] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 23/27] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 24/27] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 25/27] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 26/27] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-04-13 10:07 ` [PATCH v13 27/27] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-04-13 10:26 ` [PATCH v13 00/27] Add new general DRM property "color format" Nicolas Frattaroli
2026-04-13 18:45 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413-color-format-v13-5-ab37d4dfba48@collabora.com \
--to=nicolas.frattaroli@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=skhan@linuxfoundation.org \
--cc=sunpeng.li@amd.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox