Re: [PATCH v11 02/20] gpu: nova-core: gsp: Extract usable FB region from GSP

John Hubbard
2026-04-16T23:26:59Z

On 4/15/26 2:05 PM, Joel Fernandes wrote:
...

Apologies, I found one more minor thing, while looking at a
subsequent patch in this series:

> impl MessageFromGsp for GetGspStaticInfoReply {
> const FUNCTION: MsgFunction = MsgFunction::GetGspStaticInfo;
> type Message = GspStaticConfigInfo;
> - type InitError = Infallible;
> + type InitError = Error;
>
> fn read(
> msg: &Self::Message,
> @@ -205,6 +209,7 @@ fn read(
> ) -> Result<Self, Self::InitError> {
> Ok(GetGspStaticInfoReply {
> gpu_name: msg.gpu_name_str(),
> + usable_fb_region: msg.first_usable_fb_region().ok_or(ENODEV)?,

OK, failing out is correct here. But in addition, we should also
log this at dev_err!() level. This is rare, surprising, and actionable,
so perfect for that level of logging.

thanks,
--
John Hubbard