From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C32CC1C3BEB; Thu, 23 Apr 2026 19:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776971185; cv=pass; b=gJO9E1EtcxMvR4K/CKLR+Xnx+ZiQY01UeO5Z3JNLh3asNHYciTH9NhE8D/MeQp3oJhHitWKN0Ao9kHRWQva/cV1Q5dIYDJNx/+7OTJQHn/dcT4FB7qhZddJHfZPLZFlHlBMKWgIFHDo+AzFzM2NowkHb3jutp0ti1p86p1CFNmw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776971185; c=relaxed/simple; bh=s1y9rWsoDNhgRkgDBdgQMZia9jen7aPYWfVpz3yCCTU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ets++DBD10eG/JcHSKJCCW43Git6xyBt+E097kUq/71elOH+lNdG+fKHKBamIcFJBFBT9U92A9v6g+P2yAal4yuCRlkbU2JGXxlsPzvE9E/svFV7MnN07fpGXHw35TEgFUNFfEiLD98a5cBm3apHPkYKLgWf9brH11YVhOgK6Ng= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=UxcZ3haJ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="UxcZ3haJ" ARC-Seal: i=1; a=rsa-sha256; t=1776971134; cv=none; d=zohomail.com; s=zohoarc; b=oFow9WYgtYk+WKV0A3fifWOMhE6+rvlh3Ym/kv7vOv39miVBXzdXlNtNcZPTlKs/5Ps3ZITcmPYCOKF2snNA3Yq5zr7CVpe+84007h1SIuP0Sw9aJGZUKbjYad6bsXIArw6bedxN+pknUuJXy5tNs3wBVSYAqedZ8CZyCoJRseI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776971134; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=53RBc1lGTuBax+28h56F7t1ON1oKsPpFcrSgYXNV1RI=; b=mK+sGPZlC3Dye3XUinTNL+xl6Ba00049U6c7dzrA45ntW4eVWh+AOQfgRXDAxMYk1Hc0ClXUN/6N/sqktyGOl7IVoyXKhebLDsp2x8fBYVfoamg0fqWoCHKtXx24ej4yaQCgpoBzLj4C2P8qjKkAADe0OU8xPJT0NV8y/2KpKoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776971134; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=53RBc1lGTuBax+28h56F7t1ON1oKsPpFcrSgYXNV1RI=; b=UxcZ3haJNfi9jorIt3rqsezAnORa3f6subDdSuL33bqZVvaEirGmrjt78//GEsU/ CUKd6KdadExMGY86mJQm+qKXvrPipF/KKS5I2bhdF2GofTEJXjaHk2qGae8P6GylzyU HYHtpc5asJ+D0sG3M0dS+UTxDcK82aF5oeLGYF4g= Received: by mx.zohomail.com with SMTPS id 1776971132383933.8636431830912; Thu, 23 Apr 2026 12:05:32 -0700 (PDT) From: Nicolas Frattaroli Date: Thu, 23 Apr 2026 21:03:36 +0200 Subject: [PATCH v14 13/28] drm/i915/hdmi: Implement "color format" DRM property Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-color-format-v14-13-449a419ccbd4@collabora.com> References: <20260423-color-format-v14-0-449a419ccbd4@collabora.com> In-Reply-To: <20260423-color-format-v14-0-449a419ccbd4@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 Implement the "color format" DRM property for HDMI. The values of the property include RGB, YCbCr420, YCbCr444 and Auto. Auto will pick RGB, with a fallback to YCbCr420. The mask of supported formats by the source exposed by the property is an optimistic scenario, as specific DFP-related caveats can't be established before an EDID is present. Should the explicitly requested color format not be supported by the sink (or by the source in combination with the sink), then an error is returned to userspace, so that it can make a better choice. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/i915/display/intel_hdmi.c | 52 ++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index ee7a7655e9b4..f11658f0f1f4 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2330,10 +2330,10 @@ static int intel_hdmi_compute_output_format(struct intel_encoder *encoder, return intel_hdmi_compute_clock(encoder, crtc_state, respect_downstream_limits); } -static int intel_hdmi_compute_formats(struct intel_encoder *encoder, - struct intel_crtc_state *crtc_state, - const struct drm_connector_state *conn_state, - bool respect_downstream_limits) +static int intel_hdmi_compute_formats_auto(struct intel_encoder *encoder, + struct intel_crtc_state *crtc_state, + const struct drm_connector_state *conn_state, + bool respect_downstream_limits) { struct intel_display *display = to_intel_display(encoder); struct intel_connector *connector = to_intel_connector(conn_state->connector); @@ -2368,6 +2368,35 @@ static int intel_hdmi_compute_formats(struct intel_encoder *encoder, return ret; } +static int intel_hdmi_compute_formats(struct intel_encoder *encoder, + struct intel_crtc_state *crtc_state, + const struct drm_connector_state *conn_state, + bool respect_downstream_limits) +{ + struct intel_connector *connector = to_intel_connector(conn_state->connector); + + switch (conn_state->color_format) { + case DRM_CONNECTOR_COLOR_FORMAT_RGB444: + return intel_hdmi_compute_output_format(encoder, crtc_state, connector, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_RGB); + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR444: + return intel_hdmi_compute_output_format(encoder, crtc_state, connector, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_YCBCR444); + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR420: + return intel_hdmi_compute_output_format(encoder, crtc_state, connector, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_YCBCR420); + case DRM_CONNECTOR_COLOR_FORMAT_AUTO: + return intel_hdmi_compute_formats_auto(encoder, crtc_state, conn_state, + respect_downstream_limits); + default: + MISSING_CASE(conn_state->color_format); + return -EINVAL; + } +} + static bool intel_hdmi_is_cloned(const struct intel_crtc_state *crtc_state) { return crtc_state->uapi.encoder_mask && @@ -2740,6 +2769,20 @@ static const struct drm_connector_helper_funcs intel_hdmi_connector_helper_funcs .atomic_check = intel_hdmi_connector_atomic_check, }; +static void +intel_hdmi_attach_color_format_property(struct intel_connector *connector) +{ + unsigned long fmts = BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444); + + if (connector->base.ycbcr_420_allowed) + fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420); + + if (intel_hdmi_can_ycbcr444(connector)) + fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444); + + drm_connector_attach_color_format_property(&connector->base, fmts); +} + static void intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *_connector) { @@ -2752,6 +2795,7 @@ intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *_ intel_attach_hdmi_colorspace_property(&connector->base); drm_connector_attach_content_type_property(&connector->base); + intel_hdmi_attach_color_format_property(connector); if (DISPLAY_VER(display) >= 10) drm_connector_attach_hdr_output_metadata_property(&connector->base); -- 2.53.0