Re: [PATCH v1 v1] Documentation: proc: fix ext4 section numbering in table of contents

Randy Dunlap
2026-04-24T02:54:54Z

On 4/23/26 7:44 PM, liubaolin wrote:
>
>
> 在 2026/4/23 23:55, Randy Dunlap 写道:
>> Hi--
>>
>> Why is "ext4" in the Subject?
>> Probably just drop that word?
>>
>>
>> On 4/22/26 11:56 PM, Baolin Liu wrote:
>>> From: Baolin Liu <liubaolin@kylinos.cn>
>>>
>>> Commit e24ccaaf7ec4 ("block: remove last remaining traces of IDE
>>> documentation") removed the IDE section but left its table of
>>> contents entry behind.
>>> Fix the stale entry and renumber the following sections.
>>>
>>> Fixes: e24ccaaf7ec4 ("block: remove last remaining traces of IDE documentation")
>>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
>>> ---
>>>   Documentation/filesystems/proc.rst | 14 +++++++-------
>>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
>>> index 7ce02573a3d9..70db35987ee1 100644
>>> --- a/Documentation/filesystems/proc.rst
>>> +++ b/Documentation/filesystems/proc.rst
>>> @@ -23,13 +23,13 @@ fixes/update part 1.1  Stefani Seibold <stefani@seibold.net>    June 9 2009
>>>     1    Collecting System Information
>>>     1.1    Process-Specific Subdirectories
>>>     1.2    Kernel data
>>> -  1.3    IDE devices in /proc/ide
>>> -  1.4    Networking info in /proc/net
>>> -  1.5    SCSI info
>>> -  1.6    Parallel port info in /proc/parport
>>> -  1.7    TTY info in /proc/tty
>>> -  1.8    Miscellaneous kernel statistics in /proc/stat
>>> -  1.9    Ext4 file system parameters
>>> +  1.3    Networking info in /proc/net
>>> +  1.4    SCSI info
>>> +  1.5    Parallel port info in /proc/parport
>>> +  1.6    TTY info in /proc/tty
>>> +  1.7    Miscellaneous kernel statistics in /proc/stat
>>> +  1.8    Ext4 file system parameters
>>> +  1.9    /proc/consoles - Shows registered system consoles
>>>       2    Modifying System Parameters
>>>
>>
>> Where/how is this Table of Contents used?
>>
>> But yes, the intent of the patch is good.
>> Thanks.
>>
> Hello, this directory contains the subsequent content of the file proc.rst.
>
> My modification is due to a previous commit e24ccaaf7ec4 ("block: remove last remaining traces of IDE documentation")
> which removed "1.3 IDE devices in /proc/ide" from the subsequent content and modified the labels of the various items.
> However, this previous commit forgot to remove "1.3 IDE devices in /proc/ide" from the directory itself.
> This caused a misalignment between the directory entry and the actual subsequent content items.
>
> My modification is to remove the "1.3 IDE devices in /proc/ide" that was forgotten in the previous commit and correct the labels of the other subsequent items.

Yes, I understood all of that, but I had questions (which you ignored).

--
~Randy