From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 438B217D6; Fri, 24 Apr 2026 10:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777025941; cv=none; b=jvzOXJOkqDD12hjL75xwo+ZKb/Q5k2XkVZkBoq0ebvp6xVHw49dEC+qiRj1UyI9fQyzB8ICjLiFNpHAhfqnsH2GD/WQeuHpHSxLczI/WmA9Fzwm5gYszw2E/Ysy2yDmKwsBnE3qanAANK4cIhJ7OhGsFe8a1v1UXCDYpnNXXwWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777025941; c=relaxed/simple; bh=skKWtWqkXldvhuwp2U5Xxf4qnnjX9+jASZIFkxD8u5A=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=BLUlpmy52Ci2AA+c16HdPqxvrc/5SnZPifvX4lr2BTKmPQAztV4adngCo1IJObfjw0Xv4+yQP5ItOgI/JNGCQTAYIiuv7PXvT/1HsyZCw3E2Pc5W7Vo3uvG+78CDAEcDa+fzNz0ktAU4a4oJ5xPNdaPhEFmEjXy1imnokbd3h+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ktmbp0HM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ktmbp0HM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65ABAC19425; Fri, 24 Apr 2026 10:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777025940; bh=skKWtWqkXldvhuwp2U5Xxf4qnnjX9+jASZIFkxD8u5A=; h=From:Subject:Date:To:Cc:From; b=ktmbp0HMb1o1k4DysM7B9s5h1qZV0xna6q9YwN4vEAztRVoDL6VGwSWQYquevBe+o f99L+5orLNJsTzArL+0Dl6QZ7ITMcrjJcJLM5LXattMJ/+QVWaidln47K6Ee+QvOpu qSgkSZDedqM9+rtQeVKcYw9wXTE7YoisGFZOKhmXICJxBOYAsV0GDURSDBpB9HPoqd DkskDce8a86oOkWdG8LedWKfFafm4LvXU0JK17X6fCIz+pbBkd1G4DHVQhUnpRH+E4 1LI3HMVhtqZF2qCgpoVYR0WXR/D+TIRgC/ns/RhuUzsf2o50a+ALXVoQzqd+uxZWgt SPaN7UhOfaQDQ== From: Maxime Ripard Subject: [PATCH v3 00/20] drm/atomic: Rework initial state allocation Date: Fri, 24 Apr 2026 12:18:40 +0200 Message-Id: <20260424-drm-mode-config-init-v3-0-8b68d9db0d8b@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/33OTQ7CIBAF4Ks0rB3DT23VlfcwLlo61IkWFLDRm N5dihtd6Io8Ju+bebKAnjCwbfFkHkcK5GwKalEwfWxsj0BdykxyWXElOHR+gMF1CNpZQz2QpQg ChVnJti5XHWepevFo6J7Z/eGdPV5vSY/vT9Y2YSaGgeK2yCYFDRbvEeZVwMv0srl7pBCdf+QLR 5HL/48ZBaQJ1mpT6zUKbXYn9BbPS+f7LI7yQ5G/FJkUXSkjhCqxrvSXMk3TC7IQmFY7AQAA X-Change-ID: 20260310-drm-mode-config-init-1e1f52b745d0 To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Maxime Ripard , Laurent Pinchart , Laurent Pinchart X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5145; i=mripard@kernel.org; h=from:subject:message-id; bh=skKWtWqkXldvhuwp2U5Xxf4qnnjX9+jASZIFkxD8u5A=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDJmvnTu+rKlNXrLrWm7gxtQ3TnEv/tYfzFj67KW2r+62V BM2Xs7qjqksDMKcDLJiiixPZMJOL29fXOVgv/IHzBxWJpAhDFycAjCRPV2MtTI7blaWPP/C94VD voAnwOTX7xWy1wOSBH9nrpqkyc3XZXwsZNsmoXdztms1KGV1H7gygbG+pEpn2f9TNlN/nD8zSXf 1Xy/+6o7n8TqFky5bPek/nWJ8bcfprOrnxx7dual2Wf3rrBNvAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Hi, This series started from my work on the hardware state readout[1], and more specifically a discussion with Thomas[2]. This series expands the work that has been merged recently to make drm_private_obj and drm_private_state allocation a bit more consistent and ended up creating a new atomic_create_state callback to allocate a new state with no side effect. The first patches document the existing behaviour and fix a few cleanups and typos. Then, __drm_*_state_reset() helpers are renamed to __drm_*_state_init() to clarify that they initialize rather than reset state, and we add the new atomic_create_state callback to every other DRM object (planes, CRTCs, connectors, colorops). Next, we leverage those new callbacks to create a new helper, drm_mode_config_create_initial_state(), to create the initial state for all the objects of a driver, and update the driver skeleton to recommend it. Finally, we convert the tidss driver and the bridge_connector to the new pattern. This was tested on a TI SK-AM62, with the tidss driver. Let me know what you think, Maxime 1: https://lore.kernel.org/dri-devel/20250902-drm-state-readout-v1-0-14ad5315da3f@kernel.org/ 2: https://lore.kernel.org/dri-devel/5920ffe5-b6b1-484b-b320-332b9eb9db82@suse.de/ Signed-off-by: Maxime Ripard --- Changes in v3: - Reintroduce state documentation that was dropped by accident - Change name to drm_mode_config_create_initial_state() - Don't call drm_mode_config_create_initial_state() in drm_dev_register anymore - Drop __drm_atomic_helper_*_create_state - Improve documentation and commit messages where necessary - Collected tags - Link to v2: https://lore.kernel.org/r/20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org Changes in v2: - Change the _state_reset function names to _state_init - Change the colorop too - Various doc improvements - Link to v1: https://lore.kernel.org/r/20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org --- Maxime Ripard (20): drm/atomic: Document atomic state lifetime drm/colorop: Fix typos in the doc drm/atomic: Drop drm_private_obj.state assignment from create_state drm/atomic: Expand atomic_create_state expectations for drm_private_obj drm/mode-config: Document drm_private_obj exclusion from drm_mode_config_reset() drm/colorop: Rename __drm_colorop_state_reset() drm/colorop: Create drm_atomic_helper_colorop_create_state() drm/atomic-state-helper: Fix __drm_atomic_helper_plane_reset() doc typo drm/atomic-state-helper: Rename __drm_atomic_helper_plane_state_reset() drm/plane: Add new atomic_create_state callback drm/atomic-state-helper: Rename __drm_atomic_helper_crtc_state_reset() drm/crtc: Add new atomic_create_state callback drm/atomic-state-helper: Rename __drm_atomic_helper_connector_state_reset() drm/hdmi: Rename __drm_atomic_helper_connector_hdmi_reset() drm/connector: Add new atomic_create_state callback drm/mode-config: Create drm_mode_config_create_initial_state() drm/drv: Switch skeleton to drm_mode_config_create_initial_state() drm/tidss: Switch to drm_mode_config_create_initial_state() drm/tidss: Convert to atomic_create_state drm/bridge_connector: Convert to atomic_create_state Documentation/gpu/drm-kms.rst | 6 + drivers/gpu/drm/display/drm_bridge_connector.c | 17 ++- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 13 +- drivers/gpu/drm/drm_atomic.c | 63 +++++++++ drivers/gpu/drm/drm_atomic_state_helper.c | 136 +++++++++++++++--- drivers/gpu/drm/drm_colorop.c | 41 ++++-- drivers/gpu/drm/drm_drv.c | 4 +- drivers/gpu/drm/drm_mode_config.c | 154 ++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 +- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 2 +- drivers/gpu/drm/tidss/tidss_crtc.c | 17 +-- drivers/gpu/drm/tidss/tidss_drv.c | 6 +- drivers/gpu/drm/tidss/tidss_plane.c | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- include/drm/display/drm_hdmi_state_helper.h | 4 +- include/drm/drm_atomic.h | 5 +- include/drm/drm_atomic_state_helper.h | 14 +- include/drm/drm_colorop.h | 2 + include/drm/drm_connector.h | 16 +++ include/drm/drm_crtc.h | 16 +++ include/drm/drm_mode_config.h | 1 + include/drm/drm_plane.h | 16 +++ 24 files changed, 476 insertions(+), 67 deletions(-) --- base-commit: ea61048876a7137897da26dac49ee234fb38a35a change-id: 20260310-drm-mode-config-init-1e1f52b745d0 Best regards, -- Maxime Ripard