From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9D41361DC3; Mon, 27 Apr 2026 10:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777286972; cv=none; b=nExJnLY2279HygBspPMVD6c+T/3Xmx8O3hRpzya+H+3MsP6BKsf/9351BhvcA+BzOOP7G9/IPmy2U5y5Aa31/+bmIS3vlQQmoUPg3dEX3BfDRjxbwdykzbpB7175HO7IkYyOeAK86blIR+PDSVP8W/wj2Ts3gwBUdxdY4UO+9t0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777286972; c=relaxed/simple; bh=1NDqOAekPri/m4O8impoBtCDJFr+DiW4Ny0SINZ8vm4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rw3FAsf98LnPlKoDzIuH1oOpmLYyqj07Kfj7v/UEuyOClg+tdbHtmzQoitNzXF1NKF4atcgET9oBhofizOm1h6eScEaakdwKfvNqYLMjAZkTwmxWtQkRk3gPV9e8DbEWCh+ZEJBFn00G+QJ6w4XUdvu9VehQ9vT83l14tq5OkLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=HybofPmE; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="HybofPmE" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87BBB1684; Mon, 27 Apr 2026 03:49:24 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9BD633F62B; Mon, 27 Apr 2026 03:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777286970; bh=1NDqOAekPri/m4O8impoBtCDJFr+DiW4Ny0SINZ8vm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HybofPmElUWxhJiHsWQ0t8uWuAGLg77UZdYEmqbP0Vvm0a9mwb+0sCN01sSw/7Ah2 7Q409dAH+foOqVQ2Lo3Gun2f++NmwGlOfy5rXY9PrLwwi/GgeNHzZv1y9+pIPJxEaG rNrCwutKSV6vMlGLmesc0H4+GCSPYVfFvnAbT2ko= Date: Mon, 27 Apr 2026 11:49:14 +0100 From: Leo Yan To: Shashank Balaji Cc: Suzuki K Poulose , James Clark , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Richard Cochran , Jonathan Corbet , Shuah Khan , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Mike Leach , Rahul Bukte , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Daniel Palmer , Tim Bird , linux-modules@vger.kernel.org Subject: Re: [PATCH v4 2/4] coresight: pass THIS_MODULE implicitly through a macro Message-ID: <20260427104914.GG929984@e132581.arm.com> References: <20260427-acpi_mod_name-v4-0-22b42240c9bf@sony.com> <20260427-acpi_mod_name-v4-2-22b42240c9bf@sony.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427-acpi_mod_name-v4-2-22b42240c9bf@sony.com> Hi Shashank, On Mon, Apr 27, 2026 at 11:41:22AM +0900, Shashank Balaji wrote: [...] > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1694,7 +1694,7 @@ static void __exit coresight_exit(void) > module_init(coresight_init); > module_exit(coresight_exit); > > -int coresight_init_driver(const char *drv, struct amba_driver *amba_drv, > +int __coresight_init_driver(const char *drv, struct amba_driver *amba_drv, > struct platform_driver *pdev_drv, struct module *owner) > { > int ret; > @@ -1713,7 +1713,7 @@ int coresight_init_driver(const char *drv, struct amba_driver *amba_drv, > amba_driver_unregister(amba_drv); > return ret; > } > -EXPORT_SYMBOL_GPL(coresight_init_driver); > +EXPORT_SYMBOL_GPL(__coresight_init_driver); For consistency, we usually use prefix "__" for internal functions. Could you rename this function as: int coresight_init_driver_with_owner(..., struct module *owner); > +#define coresight_init_driver(drv, amba_drv, pdev_drv) \ > + __coresight_init_driver(drv, amba_drv, pdev_drv, THIS_MODULE) > +int __coresight_init_driver(const char *drv, struct amba_driver *amba_drv, > struct platform_driver *pdev_drv, struct module *owner); Please first function declaration, then followed by the macro to define coresight_init_driver(). With above changes: Reviewed-by: Leo Yan