From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f73.google.com (mail-oo1-f73.google.com [209.85.161.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E4BF3FF892 for ; Mon, 4 May 2026 21:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777929520; cv=none; b=P66t8KNzcPvc9kCe0Qvy3c7HR5TLyofyI69bPKW6kv4KcBJ+ld8dEq3+R8F3hXBsnvugKg2qh6bxCplFJJCay8X5LuCJWqFYmbWsIz9UNZk3EFPFq7NJJxoSRmXha7IIPbzpRgixmqzULJ3x9c/wD6SbslM2P7gyGeBHkrbjY68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777929520; c=relaxed/simple; bh=PCwE1U1S8GJICe1ZzrEReuZXJiFR/hMgArdNomzfnhs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VcvXsi+gFxNlFyx2VS+EHqShaIvvyUQNmukO8HI0ULvXB9YLUbSLw6+cD8cIXMfJP2Krz80nn5AjJ5/FzxyN+oTAKRBZxiukEviTYLU7v1PIZf1nGdiGo4prix9tope+lUTupHfKD1rzS68m9mHcdP5zmYsHlJvIQhONPNGEZO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pjHqI3Na; arc=none smtp.client-ip=209.85.161.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pjHqI3Na" Received: by mail-oo1-f73.google.com with SMTP id 006d021491bc7-6853c2438b9so8922135eaf.3 for ; Mon, 04 May 2026 14:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777929516; x=1778534316; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+6bOFPp2SwRqs2Ha+Wen4rE5RTS/9bf2wEDavZhr5Uo=; b=pjHqI3NaS8+5GOC3vXpZ67uVK0u4KEk599JziTFS4+OatSYh9rYTWD2582+R0XIhM3 qGi/C60UeBYF/ZWVZP3yvDO7lyu5MWM0xNAeACjgw0edwqtCVapSD6ZU1/J+XP0sJaSo dBdZC3iy2R0wsDyuOft9MG/nZTWwDYvPkEj1XGkzBqPm/tF0WR4h4ggB5WXDlUmsbiBt XcbGFqIHi6mWr9dvqSqOqovIJjqGElmOk3SlYu+3s5nqJZqE5rSiRhAgolTQB2kU7oHN kKiIeQbI176hQ6gg02Sg0bFoI5SuSDohPiWzWRZ99Kdkt6N3ly8WJqlzckRaHQIT5duU yq2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777929516; x=1778534316; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6bOFPp2SwRqs2Ha+Wen4rE5RTS/9bf2wEDavZhr5Uo=; b=FUtGojfTb+TEnJq9ZszRZG+OsS+f1kuAz4QGRbMJ7TYenowmCnmh9QE91+gTTBM0+3 35khikrA1foPDUs33gzpgh90F4tXLKlD15m195LZKtYuyvJJKyfv52mqBf8sPosgXO0f bUj5EPw/nyfBCWiKTbKCiC/eh9EGZGblqA7iKUbA0OkNF43Hg4Lm5LniYeAif2hUI4kX yMmG+vFOv63d9+RQXBpScvvri8to6SAZDhJale7kb6Bax7hx8vyX7L05605W5E1yY+Ql vpezU/x+Uxq3wHY1K3/9YAwaaQVvX+UN4/0yXi+3YvwcdZv95ZSbUaWK7aySkg+1M1T/ j8Gw== X-Forwarded-Encrypted: i=1; AFNElJ9AdJTUSRID7tmdWQXnyZPMsYKmIAfMUZapvF1KXnhjYiYSTNHOgvqiXQr2VABLvrQEPWXWVrNmrlY=@vger.kernel.org X-Gm-Message-State: AOJu0YwCoSUpANYqsTjY+8myRfJAa/cO9BIXg5RqP4BLcra9ZiVj75wh vhDIKczBxUC3rPQE4BKkQNiBPCvBBcrtxNIHEI6QUhNuNcX+D+5cfoMHUnWWSX7NXJZQ2kvllZJ 5zuMFQdmHhQIHYJdB8D8dcgN7Dg== X-Received: from ioel2.prod.google.com ([2002:a05:6602:2762:b0:963:c1c8:da0e]) (user=coltonlewis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6820:827:b0:696:155e:cd67 with SMTP id 006d021491bc7-6998d47028bmr144148eaf.57.1777929515654; Mon, 04 May 2026 14:18:35 -0700 (PDT) Date: Mon, 4 May 2026 21:17:59 +0000 In-Reply-To: <20260504211813.1804997-1-coltonlewis@google.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260504211813.1804997-1-coltonlewis@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260504211813.1804997-7-coltonlewis@google.com> Subject: [PATCH v7 06/20] perf: arm_pmuv3: Add method to partition the PMU From: Colton Lewis To: kvm@vger.kernel.org Cc: Alexandru Elisei , Paolo Bonzini , Jonathan Corbet , Russell King , Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Mingwei Zhang , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mark Rutland , Shuah Khan , Ganapatrao Kulkarni , James Clark , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org, Colton Lewis Content-Type: text/plain; charset="UTF-8" For PMUv3, the register field MDCR_EL2.HPMN partitiones the PMU counters into two ranges where counters 0..HPMN-1 are accessible by EL1 and, if allowed, EL0 while counters HPMN..N are only accessible by EL2. Create a module parameter reserved_host_counters to reserve a number of counters for the host. Counters not reserved for the host may be used by a guest VM when the PMU is partitioned. Add the function armv8pmu_partition() to check the validity of the reservation and record a partition has happened and the maximum allowable value for HPMN. Due to the difficulty this feature would create for the driver running in nVHE mode, partitioning is only allowed in VHE mode. In order to support a partitioning on nVHE we'd need to explicitly disable guest counters on every exit and reset HPMN to place all counters in the first range. Signed-off-by: Colton Lewis --- arch/arm/include/asm/arm_pmuv3.h | 4 ++ arch/arm64/include/asm/arm_pmuv3.h | 5 ++ arch/arm64/kvm/Makefile | 2 +- arch/arm64/kvm/pmu-direct.c | 22 +++++++++ drivers/perf/arm_pmuv3.c | 77 ++++++++++++++++++++++++++++-- include/kvm/arm_pmu.h | 8 ++++ include/linux/perf/arm_pmu.h | 2 + 7 files changed, 115 insertions(+), 5 deletions(-) create mode 100644 arch/arm64/kvm/pmu-direct.c diff --git a/arch/arm/include/asm/arm_pmuv3.h b/arch/arm/include/asm/arm_pmuv3.h index 2ec0e5e83fc98..154503f054886 100644 --- a/arch/arm/include/asm/arm_pmuv3.h +++ b/arch/arm/include/asm/arm_pmuv3.h @@ -221,6 +221,10 @@ static inline bool kvm_pmu_counter_deferred(struct perf_event_attr *attr) return false; } +static inline bool has_host_pmu_partition_support(void) +{ + return false; +} static inline bool kvm_set_pmuserenr(u64 val) { return false; diff --git a/arch/arm64/include/asm/arm_pmuv3.h b/arch/arm64/include/asm/arm_pmuv3.h index cf2b2212e00a2..27c4d6d47da31 100644 --- a/arch/arm64/include/asm/arm_pmuv3.h +++ b/arch/arm64/include/asm/arm_pmuv3.h @@ -171,6 +171,11 @@ static inline bool pmuv3_implemented(int pmuver) pmuver == ID_AA64DFR0_EL1_PMUVer_NI); } +static inline bool is_pmuv3p1(int pmuver) +{ + return pmuver >= ID_AA64DFR0_EL1_PMUVer_V3P1; +} + static inline bool is_pmuv3p4(int pmuver) { return pmuver >= ID_AA64DFR0_EL1_PMUVer_V3P4; diff --git a/arch/arm64/kvm/Makefile b/arch/arm64/kvm/Makefile index 3ebc0570345cc..baf0f296c0e53 100644 --- a/arch/arm64/kvm/Makefile +++ b/arch/arm64/kvm/Makefile @@ -26,7 +26,7 @@ kvm-y += arm.o mmu.o mmio.o psci.o hypercalls.o pvtime.o \ vgic/vgic-its.o vgic/vgic-debug.o vgic/vgic-v3-nested.o \ vgic/vgic-v5.o -kvm-$(CONFIG_HW_PERF_EVENTS) += pmu-emul.o pmu.o +kvm-$(CONFIG_HW_PERF_EVENTS) += pmu-emul.o pmu-direct.o pmu.o kvm-$(CONFIG_ARM64_PTR_AUTH) += pauth.o kvm-$(CONFIG_PTDUMP_STAGE2_DEBUGFS) += ptdump.o diff --git a/arch/arm64/kvm/pmu-direct.c b/arch/arm64/kvm/pmu-direct.c new file mode 100644 index 0000000000000..74e40e4915416 --- /dev/null +++ b/arch/arm64/kvm/pmu-direct.c @@ -0,0 +1,22 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2025 Google LLC + * Author: Colton Lewis + */ + +#include + +#include + +/** + * has_host_pmu_partition_support() - Determine if partitioning is possible + * + * Partitioning is only supported in VHE mode with PMUv3 + * + * Return: True if partitioning is possible, false otherwise + */ +bool has_host_pmu_partition_support(void) +{ + return has_vhe() && + system_supports_pmuv3(); +} diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 7ff3139dda893..6e447227d801f 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -42,6 +42,13 @@ #define ARMV8_THUNDER_PERFCTR_L1I_CACHE_PREF_ACCESS 0xEC #define ARMV8_THUNDER_PERFCTR_L1I_CACHE_PREF_MISS 0xED +static int reserved_host_counters __read_mostly = -1; +bool armv8pmu_is_partitioned; + +module_param(reserved_host_counters, int, 0); +MODULE_PARM_DESC(reserved_host_counters, + "PMU Partition: -1 = No partition; +N = Reserve N counters for the host"); + /* * ARMv8 Architectural defined events, not all of these may * be supported on any given implementation. Unsupported events will @@ -532,6 +539,11 @@ static void armv8pmu_pmcr_write(u64 val) write_pmcr(val); } +static u64 armv8pmu_pmcr_n_read(void) +{ + return FIELD_GET(ARMV8_PMU_PMCR_N, armv8pmu_pmcr_read()); +} + static int armv8pmu_has_overflowed(u64 pmovsr) { return !!(pmovsr & ARMV8_PMU_CNT_MASK_ALL); @@ -1312,6 +1324,54 @@ struct armv8pmu_probe_info { bool present; }; +/** + * armv8pmu_reservation_is_valid() - Determine if reservation is allowed + * @host_counters: Number of host counters to reserve + * + * Determine if the number of host counters in the argument is an + * allowed reservation, 0 to NR_COUNTERS inclusive. + * + * Return: True if reservation allowed, false otherwise + */ +static bool armv8pmu_reservation_is_valid(int host_counters) +{ + return host_counters >= 0 && + host_counters <= armv8pmu_pmcr_n_read(); +} + +/** + * armv8pmu_partition() - Partition the PMU + * @pmu: Pointer to pmu being partitioned + * @host_counters: Number of host counters to reserve + * + * Partition the given PMU by taking a number of host counters to + * reserve and, if it is a valid reservation, recording the + * corresponding HPMN value in the max_guest_counters field of the PMU and + * clearing the guest-reserved counters from the counter mask. + * + * Return: 0 on success, -ERROR otherwise + */ +static int armv8pmu_partition(struct arm_pmu *pmu, int host_counters) +{ + u8 nr_counters; + u8 hpmn; + + if (!armv8pmu_reservation_is_valid(host_counters)) { + pr_err("PMU partition reservation of %d host counters is not valid", host_counters); + return -EINVAL; + } + + nr_counters = armv8pmu_pmcr_n_read(); + hpmn = nr_counters - host_counters; + + pmu->max_guest_counters = hpmn; + armv8pmu_is_partitioned = true; + + pr_info("Partitioned PMU with %d host counters -> %u guest counters", host_counters, hpmn); + + return 0; +} + static void __armv8pmu_probe_pmu(void *info) { struct armv8pmu_probe_info *probe = info; @@ -1326,17 +1386,26 @@ static void __armv8pmu_probe_pmu(void *info) cpu_pmu->pmuver = pmuver; probe->present = true; + cpu_pmu->max_guest_counters = -1; /* Read the nb of CNTx counters supported from PMNC */ - bitmap_set(cpu_pmu->cntr_mask, - 0, FIELD_GET(ARMV8_PMU_PMCR_N, armv8pmu_pmcr_read())); + bitmap_set(cpu_pmu->hw_cntr_mask, 0, armv8pmu_pmcr_n_read()); /* Add the CPU cycles counter */ - set_bit(ARMV8_PMU_CYCLE_IDX, cpu_pmu->cntr_mask); + set_bit(ARMV8_PMU_CYCLE_IDX, cpu_pmu->hw_cntr_mask); /* Add the CPU instructions counter */ if (pmuv3_has_icntr()) - set_bit(ARMV8_PMU_INSTR_IDX, cpu_pmu->cntr_mask); + set_bit(ARMV8_PMU_INSTR_IDX, cpu_pmu->hw_cntr_mask); + + bitmap_copy(cpu_pmu->cntr_mask, cpu_pmu->hw_cntr_mask, ARMPMU_MAX_HWEVENTS); + + if (reserved_host_counters >= 0) { + if (has_host_pmu_partition_support()) + armv8pmu_partition(cpu_pmu, reserved_host_counters); + else + pr_err("PMU partition is not supported"); + } pmceid[0] = pmceid_raw[0] = read_pmceid0(); pmceid[1] = pmceid_raw[1] = read_pmceid1(); diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h index 24a471cf59d56..95f404cdcb2df 100644 --- a/include/kvm/arm_pmu.h +++ b/include/kvm/arm_pmu.h @@ -47,7 +47,10 @@ struct arm_pmu_entry { struct arm_pmu *arm_pmu; }; +extern bool armv8pmu_is_partitioned; + bool kvm_supports_guest_pmuv3(void); +bool has_host_pmu_partition_support(void); #define kvm_arm_pmu_irq_initialized(v) ((v)->arch.pmu.irq_num >= VGIC_NR_SGIS) u64 kvm_pmu_get_counter_value(struct kvm_vcpu *vcpu, u64 select_idx); void kvm_pmu_set_counter_value(struct kvm_vcpu *vcpu, u64 select_idx, u64 val); @@ -117,6 +120,11 @@ static inline bool kvm_supports_guest_pmuv3(void) return false; } +static inline bool has_host_pmu_partition_support(void) +{ + return false; +} + #define kvm_arm_pmu_irq_initialized(v) (false) static inline u64 kvm_pmu_get_counter_value(struct kvm_vcpu *vcpu, u64 select_idx) diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h index 52b37f7bdbf9e..f7b000bb3eca8 100644 --- a/include/linux/perf/arm_pmu.h +++ b/include/linux/perf/arm_pmu.h @@ -109,6 +109,7 @@ struct arm_pmu { */ int (*map_pmuv3_event)(unsigned int eventsel); DECLARE_BITMAP(cntr_mask, ARMPMU_MAX_HWEVENTS); + DECLARE_BITMAP(hw_cntr_mask, ARMPMU_MAX_HWEVENTS); bool secure_access; /* 32-bit ARM only */ struct platform_device *plat_device; struct pmu_hw_events __percpu *hw_events; @@ -129,6 +130,7 @@ struct arm_pmu { /* Only to be used by ACPI probing code */ unsigned long acpi_cpuid; + int max_guest_counters; }; #define to_arm_pmu(p) (container_of(p, struct arm_pmu, pmu)) -- 2.54.0.545.g6539524ca2-goog