From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FC63F5BE8; Fri, 15 May 2026 22:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778885113; cv=none; b=Ew2EFgY/j7kYPaVtZrNRsn6nqh1VVwjrInf8a13EpyK00mwxAGKvKGuz6Coi5gGWA0hKQenMOIFWdBKn6LORhslqXVJETY25gl5XSDXoDmJimKD2G7bNv8NYJCCRS4kgDhJQI016a1rWXDu79jHsKgGivxYHZx8meedylCDURuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778885113; c=relaxed/simple; bh=ydRK5g3saq9BrrM766AplduDjW0hwrabEOSpQKx/B+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HklPQ1aYeGmrZz3cg/AkZKLk2qMvJMxkuGGy85jI8HIO910x0mi8GOaxdbUcjK9cdxal4moslSZpTmKybFDpjAIcaAIw46QCOfyKRzZ56p+S8evdXgU/LGVPZPAzZwpjjFe6FAKcQoUyGjXL70SKdBW1I/inBLNK6K4byVwtV88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S/kCIrZ5; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S/kCIrZ5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778885111; x=1810421111; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ydRK5g3saq9BrrM766AplduDjW0hwrabEOSpQKx/B+w=; b=S/kCIrZ5VPLOSlaah7WS8kwOtdUhrxzUEEkXKbHcWjjOaW8K0ebP0xL2 VmjEIJAwYcxne3N5Q9D82CYWITp24JZW50iNmIaZ1fQrwZCJEjFldmokQ nggMjYDXeOVBNCdJC8SP5zlsb1RASZzS0LYHpFw7BWNQRmKlpSnh+vfo3 B/HoUjI5O7Mx9u6vNboCQ16VS+PU/b8Z4EG80HcWtIgqsp2gusmc5FWmw 1SD/BCjkE3A9+sqZwfOJRrycfH4K2v0rlkIoxEWqqiDzOFmb5faGcH0H2 gk8LXaLQIpYf6YGlKuT4muV/aadEp1skodfHvrutbUxzDpuc/twS5dhSv g==; X-CSE-ConnectionGUID: UiS0/zs5QVGZLg53ebc+FQ== X-CSE-MsgGUID: 0spVbsczRvqGbjGICxzcnw== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="90949240" X-IronPort-AV: E=Sophos;i="6.23,237,1770624000"; d="scan'208";a="90949240" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 15:45:07 -0700 X-CSE-ConnectionGUID: f+pWVtZyS+6fYtZck7jigg== X-CSE-MsgGUID: fS16ZW9fSXiYIso7Gzd56g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,237,1770624000"; d="scan'208";a="243146685" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa004.jf.intel.com with ESMTP; 15 May 2026 15:45:07 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Larysa Zaremba , anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, anjali.singhai@intel.com, michal.swiatkowski@linux.intel.com, maciej.fijalkowski@intel.com, emil.s.tantilov@intel.com, madhu.chittim@intel.com, joshua.a.hay@intel.com, jacob.e.keller@intel.com, jayaprakash.shanmugam@intel.com, jiri@resnulli.us, horms@kernel.org, corbet@lwn.net, richardcochran@gmail.com, linux-doc@vger.kernel.org, Aleksandr Loktionov , Samuel Salin Subject: [PATCH net-next v3 10/14] idpf: print a debug message and bail in case of non-event ctlq message Date: Fri, 15 May 2026 15:44:34 -0700 Message-ID: <20260515224443.2772147-11-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260515224443.2772147-1-anthony.l.nguyen@intel.com> References: <20260515224443.2772147-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Larysa Zaremba Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Kubiak Signed-off-by: Larysa Zaremba Tested-by: Samuel Salin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index 8936c2a67ce0..7c3dd89b61d6 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; adapter = container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode != VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payload for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, -- 2.47.1