From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19B5D330324; Sun, 17 May 2026 15:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779030076; cv=none; b=IQnVWcKdDWj0CO9VFvvUZFcrOmgNnweb9ftZmvcG5QLaW7aa8NoAie9mvakHivGmty7nq7s3C2QEI5Yk+jzRVibWhzqPuhdBq8rIILBpI6Fe/rAMeRRf2LyKEi9ArOrjVo8jNNultRzQWXHS/9jNcibuUWmuMqK1V4ICtub39hA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779030076; c=relaxed/simple; bh=+p/T8f8U9P6+mPDJp11pUIiEZbrCsqeSPkt/HUib5V8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zs3Ec/El3OmjEpYpAaTlJMJEXRtIvexsygl5cbofN6fBiQkMnYYzgKhREsQ1UriAdrMa+56ULbP5NQM3q50Q4XHCbbOupfXUMkhugzKEAoJw1YleFLI0Ypv2+fj3Cr6eHJTihMkHK3QZppbeget1uE4FRgFZIMGOOWGO5HQ0FMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KxY2GF8e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KxY2GF8e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9433EC2BCB8; Sun, 17 May 2026 15:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779030075; bh=+p/T8f8U9P6+mPDJp11pUIiEZbrCsqeSPkt/HUib5V8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KxY2GF8edvsnWPYhkTvlD9sJ/ueXhu6iUoG6HmnRof4HMVl/oJ8CkC2eqCxr5K4On w4TDOYGHQmzQZ7pXp9qsn7Tnn4BJeAmDsQv61IwGdV8VKkwHD/0XOQBzNd6nqcq6LO CDYT3sPoRN7jV1m85rPNv4hCBkoZcwyD/WzmYl0z6HSubMK2vV2wuJS72sCJe1W4wp IRtQCC8HUE1cGNa5fGjpFOxTxcQtMMKhf96ssf23Rf1c1Rx8yuHdh2wKgy1G7lmMbb UXtsHQiwT0uy55eYm93bLwQ/R2MTn2o+AmX84Ustp7+IhywFFlMo4HLPrXhSrWG/o7 vG10IhCc8aDWA== Date: Sun, 17 May 2026 16:01:05 +0100 From: Jonathan Cameron To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH RFC v4 05/10] iio: frequency: ad9910: add digital ramp generator support Message-ID: <20260517160105.362d9208@jic23-huawei> In-Reply-To: <20260508-ad9910-iio-driver-v4-5-d26bfd20ee3d@analog.com> References: <20260508-ad9910-iio-driver-v4-0-d26bfd20ee3d@analog.com> <20260508-ad9910-iio-driver-v4-5-d26bfd20ee3d@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 08 May 2026 18:00:21 +0100 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Add Digital Ramp Generator channels with destination selection (frequency, > phase, or amplitude) based on attribute writes, dwell mode control, > configurable upper/lower limits, step size controlled with rate of change > config, and step rate controlled as sampling frequency. > > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/frequency/ad9910.c | 511 ++++++++++++++++++++++++++++++++++++++++- > static const struct iio_chan_spec_ext_info ad9910_phy_ext_info[] = { > AD9910_EXT_INFO("powerdown", AD9910_POWERDOWN, IIO_SEPARATE), > { } > @@ -677,6 +939,14 @@ static const struct iio_chan_spec_ext_info ad9910_pp_ext_info[] = { > { } > }; > > +static const struct iio_chan_spec_ext_info ad9910_drg_ramp_ext_info[] = { > + AD9910_EXT_INFO("dwell_en", AD9910_DRG_DWELL_EN, IIO_SEPARATE), > + AD9910_DRG_EXT_INFO("frequency_roc", AD9910_DRG_FREQ_ROC), > + AD9910_DRG_EXT_INFO("phase_roc", AD9910_DRG_PHASE_ROC), > + AD9910_DRG_EXT_INFO("scale_roc", AD9910_DRG_AMP_ROC), See abi docs reply. This scale made me wonder if we can make this just roc with it scaled to be in the base units for altvoltage. > + { } > +};