From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03011C5F1B; Mon, 18 May 2026 09:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779097522; cv=none; b=URg+7/nbxDv81Oa0J3O1S+fqpN2P5fTBXVsesETyXcvZTn03UZ32GMytx1WTU3tQgRC9ElxCBgcwDo7HH+OFxpwVfEtSvc//ZcvyW+ssKDerU+0EekhgjC9T3wgAiM0OVFAZ/6BKAzJHMo5sUJ8ylQBnK4GucFnbCeEYfHhbdcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779097522; c=relaxed/simple; bh=ekbdShwcIxczhnsKIWa5bcQgD9P1oaKt+Qc+Ga35PGU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fs3N63NmnQIUrdl53qinBK/RohMjIiXx2pIY8w22DJAuQOhRiPFt89iacBrbLuObeJ2hV9LpKS1q7G1yg4BU3PJ/0DquGrjUWX40SKQGZMVWX5mc/33R/yUKs2wdPLgZ/y5ZX64g2ip73a6ugiSadW7mvDPQHoThIzntQyH/fhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kPoXYC2h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kPoXYC2h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45244C2BCB7; Mon, 18 May 2026 09:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779097522; bh=ekbdShwcIxczhnsKIWa5bcQgD9P1oaKt+Qc+Ga35PGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kPoXYC2hN7yFXRGj+mmaf5+EWHtMyUlMGer2z8EUGdgB+G6SggudlVIi5YY/a3f6A 9pdMlZ6t7c+1Au4btqsOP2AcCYj5JdOlsOK4F9ukUEfM1Wxro7eTjVe1Z+wZl07ART Xe8kIVMzB/bZqairmvVTuC+qBVqfFTxnhNRiRA1lFvZsxyHJOHw4bu1ze1R2P1ylzt mLma86T5QAw4cK3568/VtvPzxeBuo93VSsfzmd6tdJb+xiw1dyf6THKXh9g2HBkaVf Lrzt/pKdBHrk8LftQiEXmuBKgsFjVJ8Nj1Ym067Q+7eYHiejLOaFV/6n3Xnptdovjh mb0rSoWG5ODvg== Date: Mon, 18 May 2026 10:45:15 +0100 From: Conor Dooley To: Krzysztof Kozlowski Cc: Kaustabh Chakraborty , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , =?iso-8859-1?Q?Andr=E9?= Draszik , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , =?utf-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC Message-ID: <20260518-succulent-plethora-2dba60fad426@spud> References: <20260515-s2mu005-pmic-v6-0-1979106992d4@disroot.org> <20260515-s2mu005-pmic-v6-3-1979106992d4@disroot.org> <20260515-justly-recite-6028f4bfb24a@spud> <20260516-esquire-chitchat-0fffa597e2f3@spud> <20260517-corrode-tuesday-a598ca734b38@spud> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5969qpGlZ4GaGWK4" Content-Disposition: inline In-Reply-To: --5969qpGlZ4GaGWK4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 18, 2026 at 09:15:11AM +0200, Krzysztof Kozlowski wrote: > On 17/05/2026 22:52, Conor Dooley wrote: > > On Sun, May 17, 2026 at 06:39:37PM +0530, Kaustabh Chakraborty wrote: > >>>>>>> + > >>>>>> + properties: > >>>>>> + compatible: > >>>>>> + const: samsung,s2mu005-rgb > >>>>>> + > >>>>>> + required: > >>>>>> + - compatible > >>>>>> + > >>>>>> + unevaluatedProperties: false > >>>>>> + > >>>>>> + reg: > >>>>>> + maxItems: 1 > >>>>> > >>>>> Move this above the child nodes please. > >>>> > >>>> But properties are sorted in lex order? > >>> > >>> Typically the binding is sorted in the same order as properties go in > >>> nodes. Common stuff like reg/clocks/interrupts therefore send up above > >>> child nodes. > >> > >> So, do I change this? For one, I don't see the same being followed in > >> other schemas of samsung in the same dir (not that I'm trying to pose = it > >> as an argument against your suggestion), and this was reviewed by > >> Krzysztof and is adderssed in v7. > >=20 > > If Krzysztof doesn't care, then I won't ask you to change it. >=20 > This builds on top of bindings for previous Samsung PMIC devices, so > that's why it keeps the compatibles for children, I guess. No one > complained about this at v1-v2 reviews, so when I joined reviewing in v3 > I did not, either. >=20 > I don't think the compatible should be here, but I also don't want to > stall that patchset. I understand that it is inconsistent review from my > side, because other similar patchsets receive comment to drop the > compatible. But I don't think we will be fair asking to drop the > compatible now, when we did not ask for that in the early versions at all. I think you misunderstood, we were talking about the ordering of the properties in the binding file being alphanumerical, rather than the more typical approach of approximately following the order of dts-coding-style. --5969qpGlZ4GaGWK4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCagrfqwAKCRB4tDGHoIJi 0isLAPoC+2ifH81uWfXMtAlvAAtTQaUV7X6qh6Nc+Z94/owFvwD/exMi5AYart1x BVUZIUTuLRbJ1/eK5g8MJY+2kZ7vjAo= =wtO+ -----END PGP SIGNATURE----- --5969qpGlZ4GaGWK4--