From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB6CE392803 for ; Mon, 18 May 2026 20:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779136453; cv=none; b=RNglHmMjQf5DXmBy6mKZ8D/vu9KGwErQZtipxTBt5v9zUQtIpwPv5BOKMulvrjDDXmQQihJZnyp4wBN+Qcsfn8VCEldASbrtT+O4+MSM57ARtEJPLCNqj+MSA9t89zgeefEidCvdSvpKXMA1O7wqg8uSLzygXU6mOXitpIksDBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779136453; c=relaxed/simple; bh=6I+QElhAtc/8WabSKYbV0PXAFvgWpATjbvBd61/xDHI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XKmKB/aJCzrpkGnYxdmqPp16XNZhQGBDhgNiDKGJgIu5r/5Oi3QmgIwaGcKO4TPIunULR7cLgtWd3Kua6Mx3CXhuc0lyLPHqbBvaO3Vo/YAu4Cml3ULoHgmh2LcToo2ppwf9ycudJa+X0URGyNitS6VDNvaW2+EAE6JCoD2N8rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=drMkUY+c; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="drMkUY+c" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-44dd5cb0f81so2513945f8f.0 for ; Mon, 18 May 2026 13:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779136450; x=1779741250; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sTgYcEc55BDnl6ROBsBVO2eyQ8MbIi/0Xe4r8X6dKhw=; b=drMkUY+ciugqawq3ukBhLpwunBhAUQuwYrkglE29OG13pigY/pc31FwwbTyX/UZQXe keRKJUNZE0nRVsHt5XnQumz+hBjSdwSeURsAkBI2KFQjFT7tMtvVZbPkLtbfh5NzX39a xa/WHepdwHjbmnJLqiHhLIveq7BtmV4usTMl9r92d1oLK8zj0ryJcS70kPlVc4e9grtp sU0yfVkkEIb71vFGBsVluQJVF7qCYX+UGd11pPUAZAAVN0dtOMBawuirOSg18uqHz4yN +VDc3Q36ODvlFvsKV1sAWcO+fQHCTKznwNAvm7qKXeWUwk4jCZHBn6KQj0V8KD3eAdpO 9RNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779136450; x=1779741250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sTgYcEc55BDnl6ROBsBVO2eyQ8MbIi/0Xe4r8X6dKhw=; b=I6SHn6ZivbABIgc/zjnrI1MXWurx0kGYhwHoG6057+GSEhfPVNz829drbqOKSqndMc aYYhsZBX0Rwt5Ku7MKd5lf457tv+lKpeTXsm/haTywa36zf7cTzYxBafPxyFyP6UJsZh VoYF3UR4M14M6HiCM71ukyzAp4hpJbniDFaQQltLFIlgUR4LIboNBpJ94fk66M7TpqOw ga9ezcnuCSpXKIaygyEB80m/rSDMC6fQQpb6R5YPz+Tj8Q8QGM9tJutkJaCbAhvrgXZw H9UGfW5migBNfw8uhwqh6gqz9G+zP2x5oeWVOSc+PrEuja+9ijRSsp8dSCA5ODKaTd/8 PMyA== X-Forwarded-Encrypted: i=1; AFNElJ+zK/wLnzFOIKAiKmj6xof5frNDB/ISj1ZrsGjy9KBPTkOq9fS2j3XLolOPj6Arv3751hcVemRjA+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzdYU/nrRRebznOSrOJhHopRUosUW21wg7GD046O0YjN7KX835n QmoUpU3Kbex/BVopKJjWITC1GOvLqU7LV62wHXb/+dQ53Cy1Fn6bpKEm X-Gm-Gg: Acq92OGz0mbTLrnZY5pbrls4SkMl1sBHxcRrwEvl1Z+t/3OB0CtvJx+j2oQxMZQ4bYj fZOiJZ58yLpn4i1GMKnaoUx2YM25segmKjEJNUYc+OvaM0GXz7rnZ2poUN5S9j5RZZhtCpqEuSj AepAMHJI75WL2vBHTheRxeQmWwghjUmetCSJE4osHqeq5Ry6AMg20fUn3JQW9nLEY6iZ52O29Es mGwrOSrIB1VT2sQnOD6QgZtyKyMvOnSk+sgwagmSDaUP2SuQCfYHiWOuVu7GTBhBOArCt06fqns xn8Ssd7XcoJvS3nhgjn42YmnJzzln4mFK0KLWW+wh6fol+VQQVOv2ss/Afljqqt2MdZUOyrbPP5 kyHVFuvgm+Y7Jir0C+dQLd7yxdCv0ccT43C6nL2P+KrZT05KHIkcCsqayj34hlp76PoRE4uibuE vlmQr2u+wJH2f+aqVWYA4HBy5MIZ5l91U8r+Eggl3Pi/g= X-Received: by 2002:a05:6000:402c:b0:453:9897:76aa with SMTP id ffacd0b85a97d-45d93eccfbfmr34057576f8f.21.1779136450085; Mon, 18 May 2026 13:34:10 -0700 (PDT) Received: from foxbook (bfk48.neoplus.adsl.tpnet.pl. [83.28.48.48]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3b18fsm36967631f8f.11.2026.05.18.13.34.08 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 18 May 2026 13:34:09 -0700 (PDT) Date: Mon, 18 May 2026 22:34:05 +0200 From: Michal Pecio To: Guenter Roeck Cc: Jihong Min , Greg Kroah-Hartman , Mathias Nyman , Jonathan Corbet , Shuah Khan , Mario Limonciello , Basavaraj Natikar , linux-usb@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Mario Limonciello (AMD)" , Yaroslav Isakov Subject: Re: [PATCH v6 1/2] usb: xhci-pci: add AMD Promontory 21 PCI glue Message-ID: <20260518223405.06cd8fbd.michal.pecio@gmail.com> In-Reply-To: References: <20260517130407.795157-1-hurryman2212@gmail.com> <20260517130407.795157-2-hurryman2212@gmail.com> <20260517232147.34931718.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 03:55:52 -0700, Guenter Roeck wrote: > On 5/17/26 14:21, Michal Pecio wrote: > > Instead of the X86 heuristic, would it be possible to build glue > > code if and only if SENSORS_PROM21_XHCI is enabled? > > > > This seems to work: > > > > config SENSORS_PROM21_XHCI > > tristate "AMD Promontory 21 xHCI temperature sensor" > > - depends on USB_XHCI_PCI_PROM21 > > + depends on USB_XHCI_PCI > > > > config USB_XHCI_PCI_PROM21 > > tristate > > - depends on X86 > > depends on USB_XHCI_PCI > > - default USB_XHCI_PCI > > + default USB_XHCI_PCI if SENSORS_PROM21_XHCI != 'n' > > select AUXILIARY_BUS > > > > I don't know if it's the best way, perhaps it would be preferable for > > the hwmon driver to select the glue, but then I'm not sure how to force > > glue to become 'y' when xhci-pci is 'y'. > > > > Unless I am missing something, that would disable the entire controller > if the hwmon device is not enabled. That seems a bit draconian to me. I haven't tested (I don't have this chipset), but it should work like the similar xhci-pci-renesas module, which I'm familiar with. When the special unicorn module is disabled by Kconfig, xhci-pci no longer rejects its devices and works with them normally, like it always did before the unicorn module even existed. It should be the same with xhci-pci-prom21. You don't need to enable this module to use USB, only for the special functions. So if hwmon is disabled then you can disable it too. I always found this dual-driver solution (for Renesas) rather ugly and confusing, but so far it's the least bad option tried. Hmm, maybe the next iteration should be an aux bus interface for FW loaders... Regards, Michal