From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9679C4218A5; Fri, 22 May 2026 14:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460288; cv=none; b=ERXvPSw0IA02/FEPDtyfqBrW91qLPoWcmz6jR8deruajexlLm59rOCvpOSFiGDQIlmMITkEBYljm9DR6c9SUqAQEuFEZu3OVG7A9cwsJavOn4z8WBIsJfiY08S5JmxfGL8cHLcCmBydFIElLldsWdMo3j29lnqwOUcPFj6L8Tmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460288; c=relaxed/simple; bh=HuCwUi/7uO46kT1qwJq0hEJtdMEHa0AgvWi1UReZ1Po=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rVOFJSvr3SmvIcyvAAqM0hTMBxB6aueAXByzokM6HO5Ud1W/vNSNMqgPXB04B7pyu8Ea8vmjaOrHQMUBnUUE66tW4p9Uz4LaKDtWxVur/fyoY4uewLL6f8Wh6u/Oepx0NC44MlkRY2mfMJCsAGuKOrpbbcJkIE3E1KJFn/e3SJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf04.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0AB021407E6; Fri, 22 May 2026 14:31:11 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf04.hostedemail.com (Postfix) with ESMTPA id 65B5220027; Fri, 22 May 2026 14:31:08 +0000 (UTC) Date: Fri, 22 May 2026 10:31:31 -0400 From: Steven Rostedt To: Jeff Layton Cc: Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Alexander Aring , Amir Goldstein , Jan Kara , Alexander Viro , Christian Brauner , Calum Mackay , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v4 11/21] nfsd: add tracepoint to dir_event handler Message-ID: <20260522103131.080908fc@gandalf.local.home> In-Reply-To: <20260522-dir-deleg-v4-11-2acb883ac6bc@kernel.org> References: <20260522-dir-deleg-v4-0-2acb883ac6bc@kernel.org> <20260522-dir-deleg-v4-11-2acb883ac6bc@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 65B5220027 X-Stat-Signature: oc4per67rmyow4fptwqcwqmbnptpbm8x X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/j7aqctpg9NW2tR4A8PFF+/r4vzAO23pU= X-HE-Tag: 1779460268-493531 X-HE-Meta: U2FsdGVkX1980suR8vYXPXd8kAHBWSTcK55rwb76Mgvgewo0jZMr8NP2QwbyW/W9cHeMv1c3bAMVgZH9FNJFf1qT7n/hNIM0Fsx/AgtJeiyk3wsXkwfKuyuf2+SArmvHmoIrTL+K9anGCXeKfvDPUr+iJyfnUtthWNttkPoVg2OHRGD2qp58vPH0KRBb51QuL6zxibUvVybbnzOurXe82g1UySpoiEKbh5KTNeQ9K0A4qE4JDrKLIbl72oigNfZoCQv32gOafSfy9CPAM8jZb2ZCbPxUPsn0w4mFK4cj0PT+cov1eIiEwhUGG6OES/HX+6UxuZGT5Kz0C9WrJvM01Z+A9SonK8xdytCljhRP+bRFsbJYMLmwdnyv9MbY1j5iXjynnBQpnCzZrzzgTJimTw== On Fri, 22 May 2026 08:29:00 -0400 Jeff Layton wrote: > Add some extra visibility around the fsnotify handlers. > > Reviewed-by: Steven Rostedt (Google) > Signed-off-by: Jeff Layton > --- > fs/nfsd/nfs4state.c | 2 ++ > fs/nfsd/trace.h | 22 ++++++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 3afde2e91efe..8d73203297e5 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -10032,6 +10032,8 @@ nfsd_handle_dir_event(u32 mask, const struct inode *dir, const void *data, > struct file_lock_core *flc; > struct nfsd_notify_event *evt; > > + trace_nfsd_handle_dir_event(mask, dir, name); > + > /* Normalize cross-dir rename events to create/delete */ > if (mask & FS_MOVED_FROM) { > mask &= ~FS_MOVED_FROM; > diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h > index ebf5677c4e73..e8e121a52e82 100644 > --- a/fs/nfsd/trace.h > +++ b/fs/nfsd/trace.h > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -1377,6 +1378,27 @@ TRACE_EVENT(nfsd_file_fsnotify_handle_event, > __entry->nlink, __entry->mode, __entry->mask) > ); > > +TRACE_EVENT(nfsd_handle_dir_event, > + TP_PROTO(u32 mask, const struct inode *dir, const struct qstr *name), > + TP_ARGS(mask, dir, name), > + TP_STRUCT__entry( > + __field(u32, mask) > + __field(dev_t, s_dev) > + __field(ino_t, i_ino) > + __string_len(name, name->name, name->len) > + ), > + TP_fast_assign( > + __entry->mask = mask; > + __entry->s_dev = dir->i_sb->s_dev; > + __entry->i_ino = dir->i_ino; > + __assign_str(name); > + ), > + TP_printk("inode=0x%x:0x%x:0x%lx mask=%s name=%s", > + MAJOR(__entry->s_dev), MINOR(__entry->s_dev), > + __entry->i_ino, show_fsnotify_mask(__entry->mask), Hmm, I don't have the show_fsnotify_mask() function in my repos and don't see it defined in the patch series (I scanned lore). Have a link to the patch or repo that creates it? -- Steve > + __get_str(name)) > +); > + > DECLARE_EVENT_CLASS(nfsd_file_gc_class, > TP_PROTO( > const struct nfsd_file *nf >