Re: [PATCH v12 1/6] dt-bindings: iio: adc: add AD4691 family

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 19 May 2026 15:20:22 +0300
Radu Sabau via B4 Relay <devnull+radu.sabau.analog.com@kernel.org> wrote:

> From: Radu Sabau <radu.sabau@analog.com>
> 
> Add DT bindings for the Analog Devices AD4691 family of multichannel
> SAR ADCs (AD4691, AD4692, AD4693, AD4694).
> 
> The binding describes the hardware connections:
> 
> - Power domains: avdd-supply (required), vio-supply, ref-supply or
>   refin-supply (external reference; the REFIN path enables the
>   internal reference buffer). Digital core VDD is supplied either
>   externally via vdd-supply, or generated by the on-chip LDO fed
>   from ldo-in-supply; the two are mutually exclusive and one must
>   be present.
> 
> - Optional PWM on the CNV pin selects CNV Burst Mode; when absent,
>   Manual Mode is assumed with CNV tied to SPI CS.
> 
> - An optional reset GPIO (reset-gpios) for hardware reset.
> 
> - Up to four GP pins (gp0..gp3) usable as interrupt sources,
>   identified in firmware via interrupt-names "gp0".."gp3".
> 
> - gpio-controller with #gpio-cells = <2> for GP pin GPIO usage.
> 
> - #trigger-source-cells = <1>: one cell selecting the GP pin number
>   (0-3) used as the SPI offload trigger source.
> 
> Two binding examples are provided: CNV Burst Mode with SPI offload
> (DMA data acquisition driven by DATA_READY on a GP pin), and Manual
> Mode for CPU-driven triggered-buffer or single-shot capture.

Doesn't really matter, but why include so much detail that is easy enough
seen in the binding?  If there is information we need to capture it better
be in the binding!

Not actually worth the effort of changing it though - more something
for future reference (unless someone else is asking for this levle
of detail).

> 
> The four variants are not compatible with each other: AD4691/AD4692 have
> 16 analog input channels while AD4693/AD4694 have 8, and AD4691/AD4693
> top out at 500 kSPS while AD4692/AD4694 reach 1 MSPS. These differences
> in channel count and maximum sample rate require distinct compatible
> strings so the driver can select the correct channel configuration and
> rate limits.
This bit indeed belongs here.

> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Radu Sabau <radu.sabau@analog.com>
> ---