Linux Documentation
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Lance Yang <lance.yang@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
	mattsva.kernel@gmail.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, akpm@linux-foundation.org,
	david@kernel.org, ljs@kernel.org, liam@infradead.org,
	vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, corbet@lwn.net, skhan@linuxfoundation.org,
	ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com,
	ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs/mm: fix spelling mistakes in memory management docs
Date: Sun, 24 May 2026 11:43:13 -0700	[thread overview]
Message-ID: <20260524184313.1991-1-sj@kernel.org> (raw)
In-Reply-To: <20260524133701.3470-1-lance.yang@linux.dev>

On Sun, 24 May 2026 21:37:01 +0800 Lance Yang <lance.yang@linux.dev> wrote:

> Hi,
> 
> On Sun, May 24, 2026 at 02:49:21PM +0200, mattsva wrote:
> >Signed-off-by: mattsva <mattsva.kernel@gmail.com>
> 
> Missing changelog ... and Signed-off-by should use your real identity,
> not a handle :)
> 
> checkpatch.pl is your friend, please run it next time :)
> 
> >---
> > Documentation/admin-guide/mm/damon/lru_sort.rst | 2 +-
> > Documentation/admin-guide/mm/damon/reclaim.rst  | 2 +-
> > Documentation/admin-guide/mm/transhuge.rst      | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/Documentation/admin-guide/mm/damon/lru_sort.rst b/Documentation/admin-guide/mm/damon/lru_sort.rst
> >index 14cc6b2db897..25e2f042a383 100644
> >--- a/Documentation/admin-guide/mm/damon/lru_sort.rst
> >+++ b/Documentation/admin-guide/mm/damon/lru_sort.rst
> >@@ -75,7 +75,7 @@ Make DAMON_LRU_SORT reads the input parameters again, except ``enabled``.
> > 
> > Input parameters that updated while DAMON_LRU_SORT is running are not applied
> > by default.  Once this parameter is set as ``Y``, DAMON_LRU_SORT reads values
> >-of parametrs except ``enabled`` again.  Once the re-reading is done, this
> >+of parameters except ``enabled`` again.  Once the re-reading is done, this
> > parameter is set as ``N``.  If invalid parameters are found while the
> > re-reading, DAMON_LRU_SORT will be disabled.
> > 
> >diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst
> >index d7a0225b4950..01a34c215b66 100644
> >--- a/Documentation/admin-guide/mm/damon/reclaim.rst
> >+++ b/Documentation/admin-guide/mm/damon/reclaim.rst
> >@@ -67,7 +67,7 @@ Make DAMON_RECLAIM reads the input parameters again, except ``enabled``.
> > 
> > Input parameters that updated while DAMON_RECLAIM is running are not applied
> > by default.  Once this parameter is set as ``Y``, DAMON_RECLAIM reads values
> >-of parametrs except ``enabled`` again.  Once the re-reading is done, this
> >+of parameters except ``enabled`` again.  Once the re-reading is done, this
> > parameter is set as ``N``.  If invalid parameters are found while the
> > re-reading, DAMON_RECLAIM will be disabled.
> 
> Already fixed in mm-new:
> 
> https://lore.kernel.org/20260426231619.107231-3-sj@kernel.org

Thank you for checking this, Lance!

I also double confirm the typos in DAMON docs are already fixed in mm.git.

> 
> >diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> >index 5fbc3d89bb07..5d08a2a1c15f 100644
> >--- a/Documentation/admin-guide/mm/transhuge.rst
> >+++ b/Documentation/admin-guide/mm/transhuge.rst
> >@@ -210,7 +210,7 @@ PMD-mappable transparent hugepage::
> > 	cat /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
> > 
> > All THPs at fault and collapse time will be added to _deferred_list,
> >-and will therefore be split under memory presure if they are considered
> >+and will therefore be split under memory pressure if they are considered
> 
> This one as well:
> 
> https://lore.kernel.org/20260520051751.74396-1-leon.hwang@linux.dev

I also double checked this.  Lance is correct.

> 
> > "underused". A THP is underused if the number of zero-filled pages in
> > the THP is above max_ptes_none (see below). It is possible to disable
> > this behaviour by writing 0 to shrink_underused, and enable it by writing
> >-- 
> 
> So this patch is stale now: all three hunks are already covered in
> mm-new.

I agree to Lance.


Thanks,
SJ

[...]

      reply	other threads:[~2026-05-24 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 12:49 [PATCH] docs/mm: fix spelling mistakes in memory management docs mattsva
2026-05-24 13:37 ` Lance Yang
2026-05-24 18:43   ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260524184313.1991-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mattsva.kernel@gmail.com \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox