From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC33282F1D; Tue, 26 May 2026 12:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779798930; cv=none; b=mV1wPKFzIdbQjFbi14rE/iYJsAbSP9zfK3x5gpN57PO9BjHnYc4LUG/fyoZ5KR5GB7CNwlTeLtWz8zplJWvjhIDDzPcy/ykytuLOTEdEH1SY8n+cB5Sg5saIIIfREnSoEExq1K3OILrttZ4iWJHuYpjJcO2/9gqXEMDTmkS2n8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779798930; c=relaxed/simple; bh=n7j2xB/p2/bpJ4PAZFAH2CPKG+pYjXlg/jFOgnW2DLY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ABO4aED5VdF4oSxk/QNAuPmgGCTU24CQHU5AG3n2F+yYGge/1j2frlaQpj0qpbWqJFdNITIY2CJ1+TA0NOCi6LTdNhennFC4+DyflaY7JTQggYYsrSGzaDndJwOmm0Ba+hL7ElX1+Fcr6X1Bn8gemLNpzOEDzcvxW26k9MLn8CU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mVrWbuS1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mVrWbuS1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E9121F000E9; Tue, 26 May 2026 12:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779798928; bh=A4I37u3pxMkDLwlxmTpz4QG4dLPJrI76nlF19AT6q0I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mVrWbuS1XS8D3hQMpCtLJLpnHf6D6jAOgx476wTlix+2MGFvfbpg1YBsuH9+iOE3M ehoBHdgaQhjGCN3XnDZiu495rlZ0RS9alDi9zTJGtWSYv06o/tia5kgRIpWvUTomr8 6S/kpe1YRlyltFd7QyJ+a9idd7tpmWMwWnB4DIcn/ch/peJ5jLNgBAWTbn0z+gQnyP TvygqtFjVDwlMKiXi55/NLyDFTQpbIBnNWfXKrp+NxGsl5hru6fZ/T1QAeXv/yyXW5 W2ujko2fWTBrm/4rbOIoTmgEOL0Cg2nds0hZZo0b8OWj12xabcqpiyKv4Llh49MCaE WhR4tpzTt0/SA== Date: Tue, 26 May 2026 13:35:19 +0100 From: Jonathan Cameron To: Conor Dooley Cc: Janani Sunil , Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Janani Sunil Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R Message-ID: <20260526133519.232fd9d6@jic23-huawei> In-Reply-To: <20260525-dedicator-strut-6f7618a92180@spud> References: <20260519-ad5529r-driver-v3-0-267c0731aa68@analog.com> <20260519-ad5529r-driver-v3-1-267c0731aa68@analog.com> <20260522180207.63b725fb@jic23-huawei> <20260525-dedicator-strut-6f7618a92180@spud> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 25 May 2026 17:30:02 +0100 Conor Dooley wrote: > On Fri, May 22, 2026 at 06:02:07PM +0100, Jonathan Cameron wrote: > > On Tue, 19 May 2026 17:42:58 +0200 > > Janani Sunil wrote: > > =20 > > > Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage, > > > buffered voltage output digital-to-analog converter (DAC) with an > > > integrated precision reference. =20 > >=20 > > Note that I'm seeing this as Changes Requested in the DT-binding patchw= ork > > but didn't see any replies. > >=20 > > Seems I didn't get the sashiko reply - nor did the IIO patchwork. > > Hopefully Janani did! > > https://patchwork.kernel.org/project/devicetree/patch/20260519-ad5529r-= driver-v3-1-267c0731aa68@analog.com/ =20 >=20 > The sashiko stuff is per subsystem or something, so dt stuff only goes > to us and the submitters. I think that's kinda stupid but also probably > required to avoid pissing people off. There's quite a bit of noise > generated by it, especially with it repeating the same incorrect stuff > on every version. When I get on top of the long weekend's backlog I'll start a discussion on whether we ask for emails from Sashiko be sent to linux-iio. I was nervous about doing that until I had some experience of how=20 reliable the reviews are but given I'm either cutting and pasting stuff into threads or telling people to go look, might as well have those emails. Jonathan >=20 > > =20 > > >=20 > > > Signed-off-by: Janani Sunil > > > --- > > > .../devicetree/bindings/iio/dac/adi,ad5529r.yaml | 217 +++++++++++= ++++++++++ > > > MAINTAINERS | 7 + > > > 2 files changed, 224 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.ya= ml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml > > > new file mode 100644 > > > index 000000000000..eb66f6ca063d > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml > > > @@ -0,0 +1,217 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/dac/adi,ad5529r.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices AD5529R 16-Channel 12/16-bit High Voltage DAC > > > + > > > +maintainers: > > > + - Janani Sunil > > > + > > > +description: | > > > + The AD5529R is a 16-channel, 12-bit or 16-bit, high voltage, buffe= red voltage output =20 > >=20 > > Long line. Check the wrap. > > =20 > > > + digital-to-analog converter (DAC) with an integrated precision ref= erence. > > > + The device operates from unipolar and bipolar supplies. It is guar= anteed > > > + monotonic and has built-in rail-to-rail output buffers that can so= urce or > > > + sink up to 25mA. > > > + > > > + Specifications: > > > + * 16 independent 12-bit or 16-bit DAC channels > > > + * Independently programmable output ranges: 0V to 5V, 0V to 10V, 0= V to 20V, > > > + 0V to 40V, =C2=B15V, =C2=B110V, =C2=B115V, and =C2=B120V > > > + * The device supports SPI communication with Mode 0 and Mode 3. > > > + * 4.096V precision reference, 12ppm/=C2=B0C maximum > > > + * Built-in function generation: Toggle, Sinusoidal Dither, and Ram= p waveforms > > > + * Multiplexer for output voltage, load current sense and die tempe= rature > > > + > > > + Datasheet: https://www.analog.com/media/en/technical-documentation= /data-sheets/ad5529r.pdf > > > + =20 > > =20 > > > +patternProperties: > > > + "^channel@([0-9]|1[0-5])$": =20 > >=20 > > Sashiko commented that this should be hex. Why the forcing to decimal? > > =20