From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD95842EED9; Wed, 27 May 2026 16:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779899340; cv=none; b=J1ThBsoD5n06/JgnzI3blXrgIzlkkRyQa2nvZr+CxKRObQEQ3/NvKqg2UpA3IAwx0YwZ9RvTAW79LG2JQ/Baw0eZjCXzIWkHcvR8l7A4pzGRiuQ6hX1kDR3DloXfzmOZG6sUAgdF8MbPeZ/lZdphDROBX4OPupYJgYL/JJZjidg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779899340; c=relaxed/simple; bh=j6Qi8RJirgt6HV90UspX/padkb98DsmtXE9Yl4eElY0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sh8WMzf2oHJvgXPLGB3KdsiisQ72xizfW6+Jn+UFrtqWNZMML5kul8XhrtTOujptw36jUbTHj4FFdBXmrJnTcwfUfZmxG93WZi+q874rqwmzuwN50lRHA9p8XGw+w9Qxmg7Phnp4nZQ62pjYOD07V1CDqOgRCno7Y5Y4ZaYxqfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y1gEPvDa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y1gEPvDa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C87981F000E9; Wed, 27 May 2026 16:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779899332; bh=PNpYzInmKsvKeoIGvFdlPsMH8iJ4KB96xES+eyOmuy8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Y1gEPvDaPsgxSqj07YccbrM3D7EQ9pb9VD8l7tTtDMhRM5H4pI/TE10CqQVYtAR9K Aiqsz779DFlSCyFOm6VXkZX/aLqddqK0jnSt5HrTVg42v3+Hm2zcnx9eFWLVqH9hw5 tHhrCLAoau6+NNFMERiAGRMQ7XdKXdqaIqV1S3bXbAoaRDuFInsPAVVltq1U6/RP/z kPBvb4A735+t7INyUzwvNqs1Ce0wPKZggjWRuROF4ifjgh/VcW1zAZFUK0YmoLswYV MgsZGRWqOB0d5pTq1FS2N6l9UqH1ovOPljofL1u6ut4A/yokL+ccld7JsHEGoQEQ3L ecNhuNu2CP3TQ== Date: Wed, 27 May 2026 09:28:50 -0700 From: Jakub Kicinski To: Fan Gong Cc: Zhu Yikai , , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei , Mohsin Bashir , , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen , Maxime Chevallier Subject: Re: [PATCH net-next v06 3/6] hinic3: Add ethtool coalesce ops Message-ID: <20260527092850.0c30c375@kernel.org> In-Reply-To: <4bead457b595de335c10878bc09af9b86cea65d0.1779867397.git.zhuyikai1@h-partners.com> References: <4bead457b595de335c10878bc09af9b86cea65d0.1779867397.git.zhuyikai1@h-partners.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 May 2026 15:55:58 +0800 Fan Gong wrote: > Implement following ethtool callback function: > .get_coalesce > .set_coalesce > > These callbacks allow users to utilize ethtool for detailed > RX coalesce configuration and monitoring. > > Co-developed-by: Zhu Yikai > Signed-off-by: Zhu Yikai > Signed-off-by: Fan Gong The NIPA CI coccicheck test is failing on the hinic3 ethtool series (coalesce ops and/or rss ops patches). Four new Coccinelle warnings were introduced in drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c: hinic3_ethtool.c:1021:11-45: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD hinic3_ethtool.c:1055:12-37: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD hinic3_ethtool.c:1078:11-62: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD hinic3_ethtool.c:1215:29-58: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD The NL_SET_ERR_MSG_MOD() and NL_SET_ERR_MSG_FMT_MOD() macros must not be given a message string that ends with '\n'. The netlink error-message infrastructure handles message termination itself; a trailing newline results in malformed extack messages visible to user space. Please remove the trailing '\n' from all four call sites, e.g.: - NL_SET_ERR_MSG_FMT_MOD(extack, "some message\n"); + NL_SET_ERR_MSG_FMT_MOD(extack, "some message"); The same rule applies to NL_SET_ERR_MSG_MOD() and the other NL_SET_ERR_MSG* family of macros throughout the driver.