From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04C733AD9B; Tue, 16 Jun 2026 01:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781572523; cv=none; b=Ao7J3kvpApgu6ZF7AvSvk4xPReg+v+Ik74flZBibNTkx8dbdmQnTIb78s3zyhnGBARY6z2ldwwcYRD1HF9ACsIbyrcPYMFRPTEfNwuuMl+eXZ7S3ezsyow03gDw9yZQMctTYRdQ/UMUR/knGLmSgHBVo3SYXqZ8seD+z4jGZaBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781572523; c=relaxed/simple; bh=n+HgkcKRqSR/TDoR2qCULFHNYu47wmD5t1x0bjlCi04=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=nBHwJpAlRbQz684K0e65X+o04R5S7GIDcXTyXEq+TmGdqHC5V8+LxsUq70Fc9OwXFJ8xLvc6UjoWeUd3LhLhShCK9RKQzv+N/RiXK9+Fb71wjw7QHRiJcApdCZF4HAH0oCe/4W+LECdacxyz3Hp4WDRs6MNinGNBcZaHy6rtBZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OqdXuC1d; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OqdXuC1d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F3191F000E9; Tue, 16 Jun 2026 01:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781572522; bh=GJEPYwfhOR8QzZX+HHyPEWvX+nK3bmcjPuI6opafco4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=OqdXuC1dupVyt3MP7yoE7+t4yFMuiBEj7Vb5NGaRFzOg0J6dZNpFeg/l07Q3Atg0P yGiTvSmm5GAxZVWRzCqGqS/6pPHMIPrQl6oLbp1PfK/mUaqrVUc1w5uWWT3GQbWaKw dqnw6qsUgo7OC7LAtjEu/cHBNcHFNHOzIcXiexB+NRanH5Xm2ntRE6DrFQn6e+oy79 WP+bg0nbXkPRMowKCS4ar2soY+OoUigl0FFNHs8F6m36v76V8Sgs8qCn0qcFcjqJwu 61I82oyayTzUHaStIyV4i3mKFjXP1/kSW1vP0nLXL8u3NysPp9GbePAKwLgJJ9Xqiq GJJ6NSfD/oBOA== Date: Tue, 16 Jun 2026 10:15:18 +0900 From: Masami Hiramatsu (Google) To: "Masami Hiramatsu (Google)" Cc: Steven Rostedt , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 6/7] tracing/probes: Add this_cpu_read() and this_cpu_ptr() dereference method to fetcharg Message-Id: <20260616101518.798465295df36bec64f0f279@kernel.org> In-Reply-To: <178148609402.185520.8189233495763938815.stgit@devnote2> References: <178148603548.185520.3389196102475741865.stgit@devnote2> <178148609402.185520.8189233495763938815.stgit@devnote2> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jun 2026 10:14:54 +0900 "Masami Hiramatsu (Google)" wrote: > + case FETCH_OP_DEREF_CPU: > + val = (unsigned long)this_cpu_ptr((void __percpu *)val); > + ret = probe_mem_read(&val, (void *)val, sizeof(val)); > + break; > + case FETCH_OP_CPU_PTR: > + val = (unsigned long)this_cpu_ptr((void __percpu *)val); > + ret = 0; > + break; Hmm, maybe I can just convert the FETCH_OP_DEREF_CPU to FETCH_OP_CPU_PTR + FETCH_OP_DEREF to simply the code. > + default: > + lval = llval; > + goto out; > + } > if (ret) > return ret; > + llval = lval; > code++; > } while (1); > +out: > > s3 = code; > stage3: > @@ -181,6 +195,10 @@ process_fetch_insn_bottom(struct fetch_insn *code, unsigned long val, > case FETCH_OP_ST_UMEM: > probe_mem_read_user(dest, (void *)val + code->offset, code->size); > break; > + case FETCH_OP_ST_CPUMEM: > + val = (unsigned long)this_cpu_ptr((void __percpu *)val); > + probe_mem_read(dest, (void *)val, code->size); > + break; Then, I can just drop this change. Thanks, -- Masami Hiramatsu (Google)