Re: [PATCH v5 1/3] dt-bindings: spi: Add spi,device-addr peripheral property

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

On Wed, Jul 01, 2026 at 08:40:39AM +0200, Janani Sunil wrote:
> Some SPI devices support sharing a single chip select across multiple
> physical chips by encoding a device address in the SPI frame itself.
> Add a generic spi,device-addr property to document this per-peripheral
> address. This property belongs in channel or sub-device nodes of
> peripherals that use this addressing scheme.
> 
> Signed-off-by: Janani Sunil <janani.sunil@analog.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> index 880a9f624566..3774e8018355 100644
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> @@ -142,6 +142,11 @@ properties:
>      minItems: 2
>      maxItems: 4
>  
> +  spi,device-addr:

To match other generic spi properties, s/,/-/.

However, you don't actually use this as a spi peripheral's property in
your device binding, so you've got your wires crossed here somewhere.

If it's a generic dac channel property (as you use it) it should be in
dac.yaml (or adc.yaml for the other device that I asked you to add it
for as proof of being generic), or it is a spi peripheral property and
needs to go into the dac node itself.

pw-bot: changes-requested

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Device address used when multiple peripherals share a single chip select.
> +
>    st,spi-midi-ns:
>      deprecated: true
>      description: |
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]